From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm2-f13.google.com (mail-wm2-f13.google.com [74.125.225.141]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 810F7328267 for ; Mon, 5 Oct 2026 06:06:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.225.141 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791180413; cv=none; b=nfdbkKv5OQyedb3vf+X2raKVoIZrbVgiPX+NdV+isI51vor5HL3WgoQRpC/Q7wQ7Y76KVRO2rP2ldHvX6IfZ0tfr8ayitmxqYkhh6Ac7Cm0nlpk/Hy5trsXi1TATTZdL/rlNjkSJPJ8+Lp0SFBcRim3PULQzhMu+lzGiaB6aywg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791180413; c=relaxed/simple; bh=lVF+Ieq6VFNaQlfh6SXbpbgQq2pYNgR30DDLcDHwqH4=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=X4rtza7repdIuKKfGYYrybQbl/jD6a7Kpv37J6utz7XI3K9ZxNm6D5fmboeUIVI5+PBP5bUMsKdf/30V22vyqURPKHebFNOiM6ozMQA+IW6h8U3gRyLJI7XOnip80QzN7sTTBjhExTdQPA3PNYCQ+VADU7ieD20jZuSJ3Zhj+v0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=BwXM6bSh; arc=none smtp.client-ip=74.125.225.141 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="BwXM6bSh" Received: by mail-wm2-f13.google.com with SMTP id 5b1f17b1804b1-49e7d2bb404so4801335e9.1 for ; Sun, 04 Oct 2026 23:06:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1791180411; x=1791785211; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=i12y/n1I7Joev3/O6opsapKYTtaoZWQvHYQMKgmIotE=; b=BwXM6bShH/knLvgKPLVt1Gvvp2Vbg9Ozokb9VRvayJjc6uNArvpToi9GT94ptl5lUP oxo/HIZLs3+Xi5V8gyE8/uEq5PWls8QltfKbC+4cmYuviysr1vcIZb7KfFYLdGAdMEjP UcvAEqqnDWlGUFEXvprYvvrxaSo0h7uZj97wo9XkSihBXM67bXWp5IkI7rXLJi5cwE9h tpfzRZpxf0Sza8X9602CKN+niwCsyfj67aT4vMBRV8pXZtLr6XskrRGSzcBgVc3YpyJI RI9peN0OBFwNp9FAI18BXmqW21nT/jiO4LjK4ImPWzlhylye0AvV/csG+dHN+2kV58Vg u+YQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1791180411; x=1791785211; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=i12y/n1I7Joev3/O6opsapKYTtaoZWQvHYQMKgmIotE=; b=jPWDIO4oftJc3vIZByNXgcK5cW9ERqI0+Mz+hhT0Gw6OmL9kAKqtbVg3I/ChD2TNrN QwD6NplRPziXkt3R/DGA5TLUR1guzJZYUgAAaa4dCscRI+wJOuZFy6/dUCoaIBWHilOx RYbNeu8UCUldVPkEuOPj4pr1HJf4NJEN49vGvnb9lnBclnKBrFbhxmSUadesEN1zaMZn yba52h5TyiDr3LYH9xIrrIY1aICvtza8jsiUT05Icrj/9CJLvyUGo4c+/EK0K5JofrcQ aZ0r3Zcc+E6/ydgI7FPUsXfSMu/fYW0KJUP7qrmAGi/Szn4vvqx0GHul8gz13vn9GxtO eSFw== X-Forwarded-Encrypted: i=1; AKwUvBzEaHBG+XTpc+BTyb0B2uV/AD4hIPPhB2s1/oqtOkzdg0VOuLJY1eExWrDgESCt341BE5g/bC7asnLvB/s=@vger.kernel.org X-Gm-Message-State: AFuF++mOY2iChWd5aqJ2epvXXBPe5MlPn8kg1RNqQzVkQ1GV4LymQJqf wvI3VnTWiXFjE94yQg2p5tAFxkbM0HIfxiCs3EQHKNZoQdL5HSzGVqj7 X-Gm-Gg: AYBFou1l665mKDZ1La3pKUS2YMrbQE1YaP39wJLeyVr2XYjrrBjbhFna+POJsqtzC29 t2A3fgI8u8vVlz7og+KrCXd/veDTcAanBjgkVRicnMiFGZFg/Wy1teoZC3+NB6IB0xVUmkIdOUa EOWzNFDB/4zLwbTv3EYCfLcflhLYJYyk2rGJXE6NvMpzz+oTsuuwDPvxT0jvGJUJ6K/pTAFJUNU IWJWA0cWyy5FrgX/dfIZcrDWbzA0fPulFeHqUGKE6nPZTkbXz0ZEOeJoKAdOUNZYwB0ywpdjtgU AZWaqqyqUdrsfw0S/W/UrFqmuYPfgyWBExA07IVAfHkNEhLTswSHf+P8Up7YkyC6SL+/qWuA++T oAtGRlt2ekWI6eCBi3Dyc7zvY+bKBGymckK7kkP+P9O5xNmV3a+RVktrSZgmToiria2gxJtwzfl Knv4/VHn4L7xTIP8McobrWe+Ka6sK+hPU0nZae5UHvIzWPYptfksvVXyh0qQGULE+y44OWQTZqB r+0IFkX4wxzrxmEagBfZ5W8aeVZuSWG X-Received: by 2002:a05:600c:1d0d:b0:4a1:6d2d:d8bb with SMTP id 5b1f17b1804b1-4a16d2dd8c5mr77010345e9.12.1791180410483; Sun, 04 Oct 2026 23:06:50 -0700 (PDT) Received: from localhost.localdomain ([182.189.185.133]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4a027727cecsm324625325e9.9.2026.10.04.23.06.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 04 Oct 2026 23:06:50 -0700 (PDT) From: Saad Anjum To: Linus Walleij , Sean Wang Cc: AngeloGioacchino Del Regno , Matthias Brugger , Hao Chang , Qingliang Li , linux-gpio@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Saad Anjum Subject: [PATCH] pinctrl: mediatek: common-v2: Fix of_iomap() error check Date: Mon, 5 Oct 2026 11:06:41 +0500 Message-ID: <20261005060641.32674-1-saadanjum239@gmail.com> X-Mailer: git-send-email 2.50.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit of_iomap() returns NULL on failure, never an error pointer, so the IS_ERR() check in mtk_build_eint() can never be true. The check was carried over from the previous devm_platform_ioremap_resource_byname() call, which does return an error pointer, when the EINT registers were switched to being mapped with of_iomap() to support multiple bases. If mapping one of the EINT register ranges fails, for example because the device tree node lists more "reg-names" than "reg" entries so that of_address_to_resource() fails, or because ioremap() itself fails, the NULL pointer is stored in hw->eint->base[] and probing continues. mtk_eint_do_init() then calls mtk_eint_hw_init(), which writes to eint->base[i] + regs->dom_en, causing a NULL pointer dereference instead of a clean probe failure. Check for NULL and return -ENOMEM instead. The existing error path already skips NULL entries when unmapping, so any ranges mapped before the failure are still released. Fixes: 3ef9f710efcb ("pinctrl: mediatek: Add EINT support for multiple addresses") Signed-off-by: Saad Anjum --- drivers/pinctrl/mediatek/pinctrl-mtk-common-v2.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/pinctrl/mediatek/pinctrl-mtk-common-v2.c b/drivers/pinctrl/mediatek/pinctrl-mtk-common-v2.c index faa6dbf0f..bf9d20b59 100644 --- a/drivers/pinctrl/mediatek/pinctrl-mtk-common-v2.c +++ b/drivers/pinctrl/mediatek/pinctrl-mtk-common-v2.c @@ -398,8 +398,8 @@ int mtk_build_eint(struct mtk_pinctrl *hw, struct platform_device *pdev) for (i = hw->soc->nbase_names, j = 0; i < count_reg_names; i++, j++) { hw->eint->base[j] = of_iomap(np, i); - if (IS_ERR(hw->eint->base[j])) { - ret = PTR_ERR(hw->eint->base[j]); + if (!hw->eint->base[j]) { + ret = -ENOMEM; goto err_free_eint; } } base-commit: a90ee4305c4a5df72c11b31dacfdc76e00fcf78a -- 2.50.1 (Apple Git-155)