From: Stanislaw Gruszka <stf_xl@wp.pl>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: Runyu Xiao <runyu.xiao@seu.edu.cn>,
"David S . Miller" <davem@davemloft.net>,
"John W . Linville" <linville@tuxdriver.com>,
Zhu Yi <yi.zhu@intel.com>,
linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org,
stable@vger.kernel.org, Jianhao Xu <jianhao.xu@seu.edu.cn>
Subject: Re: [PATCH] wifi: iwlegacy: 3945: protect sysfs TX power update with mutex
Date: Mon, 5 Oct 2026 17:37:41 +0200 [thread overview]
Message-ID: <20261005153741.GA25122@wp.pl> (raw)
In-Reply-To: <7360e480d5eb194dc7c16c6e82944dfb73f3892f.camel@sipsolutions.net>
On Mon, Oct 05, 2026 at 03:14:20PM +0200, Johannes Berg wrote:
> On Tue, 2026-09-29 at 20:14 +0200, Stanislaw Gruszka wrote:
> > On Tue, Sep 29, 2026 at 08:33:29PM +0800, Runyu Xiao wrote:
> > > The sysfs tx_power store handler calls il3945_hw_reg_set_txpower(), whose
> > > command path requires il->mutex to be held. The callback bypasses the mutex
> > > used by the other 3945 control paths, triggering the lockdep assertion and
> > > allowing concurrent TX power updates to race with other command or state
> > > transitions. Serialize the update with the same mutex.
> > >
> > > Fixes: b481de9ca074 ("[IWLWIFI]: add iwlwifi wireless drivers")
> > > Cc: stable@vger.kernel.org
> > > Assisted-by: LLM
> > > Signed-off-by: Runyu Xiao <runyu.xiao@seu.edu.cn>
> > Acked-by: Stanislaw Gruszka <stf_xl@wp.pl>
>
> I think we should rather remove these files: custom, undocumented sysfs
> shouldn't be there anyway...
Maybe some of them should be moved to debugfs. I'll consider that,
and move/remove them.
Regards
Stanislaw
prev parent reply other threads:[~2026-10-05 15:37 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-29 12:33 Runyu Xiao
2026-09-29 18:14 ` Stanislaw Gruszka
2026-10-05 13:14 ` Johannes Berg
2026-10-05 15:37 ` Stanislaw Gruszka [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261005153741.GA25122@wp.pl \
--to=stf_xl@wp.pl \
--cc=davem@davemloft.net \
--cc=jianhao.xu@seu.edu.cn \
--cc=johannes@sipsolutions.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=runyu.xiao@seu.edu.cn \
--cc=stable@vger.kernel.org \
--cc=yi.zhu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®