mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jakub Kicinski <kuba@kernel.org>
To: "Théo Lebrun" <theo.lebrun@bootlin.com>
Cc: netdev-bot+sinfo@kernel.org,
	"Conor Dooley" <conor.dooley@microchip.com>,
	"Andrew Lunn" <andrew+netdev@lunn.ch>,
	"David S. Miller" <davem@davemloft.net>,
	"Eric Dumazet" <edumazet@google.com>,
	"Paolo Abeni" <pabeni@redhat.com>,
	netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
	"Nicolai Buchwitz" <nb@tipi-net.de>,
	"Vladimir Kondratiev" <vladimir.kondratiev@mobileye.com>,
	"Gregory CLEMENT" <gregory.clement@bootlin.com>,
	"Benoît Monin" <benoit.monin@bootlin.com>,
	"Tawfik Bayouk" <tawfik.bayouk@mobileye.com>,
	"Thomas Petazzoni" <thomas.petazzoni@bootlin.com>
Subject: Re: [PATCH net-next] net: macb: move printk() calls out of bp->lock critical section
Date: Mon, 5 Oct 2026 16:19:42 -0700	[thread overview]
Message-ID: <20261005161942.2a23f861@kernel.org> (raw)
In-Reply-To: <DLSVOPXORTQN.3VAUYHPWRAYVO@bootlin.com>

On Wed, 30 Sep 2026 20:55:47 +0200 Théo Lebrun wrote:
> >  - How the issue was discovered, e.g. hit in production, hit during
> >    development, syzbot report, manual code inspection, LLM or static
> >    analysis tool scan.  
> 
> This is mentioned two fold; in the commit message:
> 
>    The netconsole deadlock is theoretical & never reproduced.
> 
> And in the cover letter (folded below the '--' line):
> 
>    Technically it is a fix, in practice I'm happy for it to go through
>    net-next/main for more testing and it is a theoretical bugfix (as usual
>    nowadays). Decided after seeing Jakub taking a similar patch into
>    net-next this morning:

It's borderline, indeed. But "theoretical" does not tell us how you
stumbled upon this.

> - Maybe it could trust the driver maintainers, especially regarding the
>   second question about having access to real hardware?

I'd like it to keep asking. It's also useful to know which SoC you used
for testing. Of course this patch is quite trivial so the biggest
miss for the bot IMO is that it bothered looking at this patch in
the first place. Hard to tune these things :/

  reply	other threads:[~2026-10-05 23:19 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-30 18:35 Théo Lebrun
2026-09-30 18:38 ` netdev-bot+sinfo
2026-09-30 18:55   ` Théo Lebrun
2026-10-05 23:19     ` Jakub Kicinski [this message]
2026-10-02  9:53 ` Nicolai Buchwitz
2026-10-05 23:30 ` patchwork-bot+netdevbpf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261005161942.2a23f861@kernel.org \
    --to=kuba@kernel.org \
    --cc=andrew+netdev@lunn.ch \
    --cc=benoit.monin@bootlin.com \
    --cc=conor.dooley@microchip.com \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=gregory.clement@bootlin.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nb@tipi-net.de \
    --cc=netdev-bot+sinfo@kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=tawfik.bayouk@mobileye.com \
    --cc=theo.lebrun@bootlin.com \
    --cc=thomas.petazzoni@bootlin.com \
    --cc=vladimir.kondratiev@mobileye.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®