From: Rob Herring <robh@kernel.org>
To: netdev-bot+sashiko@kernel.org
Cc: andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@kernel.org,
kuba@kernel.org, pabeni@redhat.com, krzk+dt@kernel.org,
conor+dt@kernel.org, shenjian15@huawei.com, shaojijie@huawei.com,
netdev@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next v2] dt-bindings: net: Convert HiSilicon hns-dsaf to DT schema
Date: Mon, 5 Oct 2026 15:16:38 -0500 [thread overview]
Message-ID: <20261005201638.GA1807068-robh@kernel.org> (raw)
In-Reply-To: <179115213771.434549.6434616017051204695@kernel.org>
On Sun, Oct 04, 2026 at 10:15:37PM +0000, netdev-bot+sashiko@kernel.org wrote:
> Thank you for your contribution! Sashiko AI review found 6 potential
> issue(s) to consider.
>
> Critical: 0 · High: 0 · Medium: 2 · Low: 4
>
> If you believe none of the issues are legitimate, please reply to each
> issue of Medium severity or higher and explain why the AI is wrong.
> If any of them are legitimate and you plan to respin, please let patchwork
> know by including "pw-bot: cr" as a separate line at the end of your reply
> (one such reply per series is enough).
>
> - [Medium] The conversion drops the two leading legacy 'reg' regions
> (sub-control and SerDes) that the old binding documented as the…
The old binding was deprecated for a long time and there are no users.
Will detail in commit msg.
> - [Medium] The top-level 'required' list in hisilicon,hns-dsaf-v1.yaml
> leaves out 'desc-num' and 'buf-size', although the deleted text…
Will fix.
> - [Low] The patch deletes
> Documentation/devicetree/bindings/net/hisilicon-hns-dsaf.txt, but…
Not an issue. Fixed when other binding is converted.
> - [Low] The deleted text binding had the buf-size and desc-num ranges
> swapped ('buf-size: ... should be 16-1024', 'desc-num: ... should be…
Based on the .dts files and driver, the text binding is wrong.
> - [Low] The concern says that 'mc-mac-mask' with only 'maxItems: 6'
> accepts 1–5 bytes, while hns_mac_get_info() needs exactly ETH_ALEN (6)…
Not an issue.
> - [Low] reg and reg-names use 'minItems: 1' for every 'mode'.
Not worth the complexity to try to express that.
pw-bot: cr
Rob
prev parent reply other threads:[~2026-10-05 20:16 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-30 20:19 Rob Herring (Arm)
2026-10-04 22:15 ` netdev-bot+sashiko
2026-10-05 20:16 ` Rob Herring [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261005201638.GA1807068-robh@kernel.org \
--to=robh@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=conor+dt@kernel.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=edumazet@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev-bot+sashiko@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=shaojijie@huawei.com \
--cc=shenjian15@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®