From: SJ Park <sj@kernel.org>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Liew Rui Yan <aethernet65535@gmail.com>,
Brendan Higgins <brendan.higgins@linux.dev>,
David Gow <davidgow@davidgow.net>, SJ Park <sj@kernel.org>,
damon@lists.linux.dev, kunit-dev@googlegroups.com,
linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org,
linux-mm@kvack.org
Subject: [PATCH 3/3] mm/damon/tests/core-kunit: add test for unconditionally skipping the last region
Date: Mon, 5 Oct 2026 23:52:07 -0700 [thread overview]
Message-ID: <20261006065209.41507-4-sj@kernel.org> (raw)
In-Reply-To: <20261006065209.41507-1-sj@kernel.org>
From: Liew Rui Yan <aethernet65535@gmail.com>
Commit b3723b596b54 ("mm/damon/core: fix unconditionally skip last
region") fixed a minor bug.
Add a KUnit test case to cover this behavior and prevent regressions in
the future.
Signed-off-by: Liew Rui Yan <aethernet65535@gmail.com>
Reviewed-by: SJ Park <sj@kernel.org>
Signed-off-by: SJ Park <sj@kernel.org>
---
Changes from v3
- v3: https://lore.kernel.org/20260927175159.60703-1-aethernet65535@gmail.com
- Collect R-b: from SJ.
- Rebase to the latest mm-new.
Changes from v2:
- v2: https://lore.kernel.org/damon/20260925045350.66595-1-aethernet65535@gmail.com
- Change the commit message, mention the fix rather than the original
bug.
Changes from v1 RESEND:
- v1 RESEND: https://lore.kernel.org/damon/20260919080453.628679-1-aethernet65535@gmail.com
- Drop braces for single line, as suggested [1] in coding-style.
- Set min_region_sz initial value to power-of-2 value, '1'.
Changes from v1:
- v1: https://lore.kernel.org/damon/20260831113735.3349-1-aethernet65535@gmail.com
- Resend since the dependent patch is merged into mm-new, that would
help us getting AI review help.
mm/damon/tests/core-kunit.h | 42 +++++++++++++++++++++++++++++++++++++
1 file changed, 42 insertions(+)
diff --git a/mm/damon/tests/core-kunit.h b/mm/damon/tests/core-kunit.h
index ef146ca2ae8a..3fbb4e4e36fa 100644
--- a/mm/damon/tests/core-kunit.h
+++ b/mm/damon/tests/core-kunit.h
@@ -2439,6 +2439,47 @@ static void damos_test_esz_goal_temporal(struct kunit *test)
damon_destroy_ctx(ctx);
}
+static void damon_test_last_region_quota_reset(struct kunit *test)
+{
+ struct damos s = {0};
+ struct damon_target *t;
+ struct damon_region *r1, *r2;
+ unsigned long min_region_sz = 1;
+ bool skipped;
+
+ t = damon_new_target();
+ if (!t)
+ kunit_skip(test, "target alloc fail");
+
+ r1 = damon_new_region(0, 100);
+ if (!r1) {
+ damon_free_target(t);
+ kunit_skip(test, "region 1 alloc fail");
+ }
+ damon_add_region(r1, t);
+
+ r2 = damon_new_region(100, 200);
+ if (!r2) {
+ damon_free_target(t);
+ kunit_skip(test, "region 2 alloc fail");
+ }
+ damon_add_region(r2, t);
+
+ s.quota.charge_target_from = t;
+ s.quota.charge_addr_from = r1->ar.end;
+
+ skipped = damos_skip_charged_region(t, r2, &s, min_region_sz);
+
+ /* 'r2' is not processed, it should not skip */
+ KUNIT_EXPECT_EQ(test, skipped, false);
+
+ /* 'r2' is last region, it should reset charge_{target,addr}_from */
+ KUNIT_EXPECT_PTR_EQ(test, s.quota.charge_target_from, NULL);
+ KUNIT_EXPECT_EQ(test, s.quota.charge_addr_from, 0);
+
+ damon_free_target(t);
+}
+
static struct kunit_case damon_test_cases[] = {
KUNIT_CASE(damon_test_target),
KUNIT_CASE(damon_test_regions),
@@ -2482,6 +2523,7 @@ static struct kunit_case damon_test_cases[] = {
KUNIT_CASE(damon_test_walk_control_obsolete),
KUNIT_CASE(damon_test_rand),
KUNIT_CASE(damos_test_esz_goal_temporal),
+ KUNIT_CASE(damon_test_last_region_quota_reset),
{},
};
--
2.47.3
prev parent reply other threads:[~2026-10-06 6:52 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-06 6:52 [PATCH 0/3] mm/damon: fix a minor bug, clean code, and add a test SJ Park
2026-10-06 6:52 ` [PATCH 1/3] mm/damon/ops-common: fix age_in_sec overflow on 32-bit SJ Park
2026-10-06 6:52 ` [PATCH 2/3] mm/damon: use damon_get_monitor_folio() for hugetlb entries SJ Park
2026-10-06 6:52 ` SJ Park [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261006065209.41507-4-sj@kernel.org \
--to=sj@kernel.org \
--cc=aethernet65535@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=brendan.higgins@linux.dev \
--cc=damon@lists.linux.dev \
--cc=davidgow@davidgow.net \
--cc=kunit-dev@googlegroups.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®