From: Sergey Tiraspolsky <stiraspo@gmail.com>
To: James Fairweather <james.a.fairweather@gmail.com>,
Tzung-Bi Shih <tzungbi@kernel.org>
Cc: "Sergey Tiraspolsky" <stiraspo@gmail.com>,
"Benson Leung" <bleung@chromium.org>,
"Łukasz Bartosik" <ukaszb@chromium.org>,
"Andrei Kuchynski" <akuchynski@chromium.org>,
"Jameson Thies" <jthies@google.com>,
"Rafael J. Wysocki" <rafael.j.wysocki@intel.com>,
chrome-platform@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] platform/chrome: cros_usbpd_notify: Only use parent drvdata when parent is GOOG0004
Date: Tue, 6 Oct 2026 00:14:50 -0700 [thread overview]
Message-ID: <20261006071452.11422-1-stiraspo@gmail.com> (raw)
In-Reply-To: <20261003222855.23707-1-james.a.fairweather@gmail.com>
On Sat, Oct 03, 2026 at 06:28:53PM -0400, James Fairweather wrote:
> Only read the parent's driver data when the parent's ACPI node is
> GOOG0004, and otherwise continue without an EC pointer. While at it,
> drop the reference taken by fwnode_get_parent().
Tested on a 2017 Google Pixelbook (Eve), where GOOG0003 is also a child
of PNP0C09, on 7.2.5 (linux-omarchy 7.2.5-3), with this patch built as an
out-of-tree module. The probe prints "Couldn't get Chrome EC device
pointer.", a charger unplug/replug while awake and another while
suspended produced 13 USB PD notifications, all taking the "EC device
inaccessible; sending 0 event status" path, the suspend resumed normally,
and there were no oopses. Without a fix the same machine oopsed on
charger events and on resume.
The test was set up and checked with the help of an AI coding assistant;
I ran it on the hardware.
Tested-by: Sergey Tiraspolsky <stiraspo@gmail.com>
next prev parent reply other threads:[~2026-10-06 7:14 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-03 22:28 James Fairweather
2026-10-05 3:41 ` Tzung-Bi Shih
2026-10-06 7:14 ` Sergey Tiraspolsky [this message]
2026-10-06 10:28 ` Tzung-Bi Shih
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261006071452.11422-1-stiraspo@gmail.com \
--to=stiraspo@gmail.com \
--cc=akuchynski@chromium.org \
--cc=bleung@chromium.org \
--cc=chrome-platform@lists.linux.dev \
--cc=james.a.fairweather@gmail.com \
--cc=jthies@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rafael.j.wysocki@intel.com \
--cc=tzungbi@kernel.org \
--cc=ukaszb@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®