From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f49.google.com (mail-wr1-f49.google.com [209.85.221.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 454C137F8CB for ; Tue, 6 Oct 2026 07:46:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.49 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791272792; cv=none; b=by12vPL2LHRgnxuf8e1sczmYqTQKKIMizx74Nia7dNvRPwYq9NJ9DV73Np5tAsJXe2Z/zt0xX2LPXWjpxBlz1ZJ2uqIfSu9xeGDi+NkW9i/lxDkm9OOBfzI93Tkf2+oUk8Gb99ntCra3QNzxD30qpKOExCpNqbgpVR/meegacOs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791272792; c=relaxed/simple; bh=Dbh4ppydX74jlkNg4Kn6ybU3AG2ilsWVZs+ROAx3A9U=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Fq1gJqu4qzQagCpSSrX1cdemgDgOI6y+dvYJ/v8k8Ri8JBGAiSIkLZ8xNO583cUqq3px3G0dJx18MNve46c1D/5yOBKvZnUNn7sYVj+oiYjPXWODW2Zi1tH7BLJXJxgc7sVkj1immOlFLKmkJuJqytuUYzGooWj84w58GBWh4X0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=D9/kTnK3; arc=none smtp.client-ip=209.85.221.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="D9/kTnK3" Received: by mail-wr1-f49.google.com with SMTP id ffacd0b85a97d-48c4d99c32bso289774f8f.1 for ; Tue, 06 Oct 2026 00:46:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1791272789; x=1791877589; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=Dbh4ppydX74jlkNg4Kn6ybU3AG2ilsWVZs+ROAx3A9U=; b=D9/kTnK3xgWTzVttlACBbQ1Lwo7yDUZFuUFLYPIMOWhVp3qOJglSxo8YWcjNrcGMGu XGaz3siZPuFc9zMfpkkI+veb7R2uIuNNXKWp1DexYRUbG50fAat4n5RYRB+xnjdhmLnC rR0T4Nqz9X7Ru3dbuA1Uy9YFl1s8p/eZj1WPC/lYun5zR1JyfO0s/paKvJ+8G3a94/rr uXtYuWHnfc+iGp4dfLwP3ReAHBvi4N0tYFoErD3Ih6tB1NL/5sLqCvF+eusaqIdqjHZ1 /7nxsrvU4sAI0LmIR4+AtjHpSakFTN+8P0vl4vBYH5J+ZC87jHFdVSAt5WWDiSn5BVUY y8gg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1791272789; x=1791877589; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=Dbh4ppydX74jlkNg4Kn6ybU3AG2ilsWVZs+ROAx3A9U=; b=Ro3eL8fT4RUjyn0jfUEnW/krgTLPUgE+DAc/zSZjXEDFBa8faycy30+jvcF870y5xl 0dLZc0roGkwuWgwN/DeKOJTefWY9Vl2neU9qig8jFZTCokcvWSS3Ha3p3PTHqQ4U1A4Q igTtqXw/4peL9PlzqmvW8O+ZJPGcqXSkV15FY5F3Ik3bfrISIlFFLYZdJMkV+KBeQJw6 5pKnqnCvoj4H1CmEOBAmv0XcAdojK8Qpt2bS1wTaUTlDjiDpHoYTon0y8VrqYcEkRwp2 YLSUuMvq7lSZ7bq9CVTUfRp/8sUEqpI8qaxNbimi5PVEVipCUALezDhNClhnqSy/bdzM cJUg== X-Forwarded-Encrypted: i=1; AKwUvBwgy4o75HdQLrEOKg9jpRSfmFjLUnti0nMru6Uk5+/H2hiq2xSnb/ZI2Ej+rUyWYzNHa8UJzeO/NeQPLKw=@vger.kernel.org X-Gm-Message-State: AFq9FYIKqFjtA18830HdIjdhZ+wED2BI9BfS4xrqqJ5H9yawd9yRgxL4 gIOdeTu+G6UnqS2mByBjqmPJlqCuc368ZEQv2As0HSLZX4ZAL7SkXNqd X-Gm-Gg: AYBFou29/yNWb+oEeUD6M9OSgO5rLs60sGbPy4k9+4+cYjLaRI3IMRYFNvVjQQbZa+y 8X4FmdnFJEuuIHhIp3j3vXiSbTadjqwpqY/VikYqAQW4PRqD1FFU0oWkIV6hMeAoXB3G0K1QAyZ 4Vp9k/YGpvIHU0fuedJNp/6TwaDc4kU8eypQrJMaxCi3tgJUwL5SoWp0nkCaMEdX4PB7IkRhRch lYKCcOrOjbt4Q/igZM0jawGrENHBevGmyTjTSIvPX2uPm89HUapmC/wsM1C8AfT1izQHkOC7UGq oxP3i6wnK/Q//XTw4QAUeORYjtQonSRRpCOXP+Cu+TkqQeV4bJnqAjDqwUuDGvL/eDdMgH9eUZV Uq5is/nyW2gdv7vgQCGljLda3DcANZrGkxgYQHbssds3Ms10ETQ6DmuniPInu5Tks3jfy3N1NUr TQzCpyzwlqmxIFDehoPk7SJ3xXyfPoyNaWR0sS34CS8/mFf2IhaSt7EW8LkjrXLq4bOAAgn/IqP zfP X-Received: by 2002:a5d:5d0b:0:b0:488:8525:4979 with SMTP id ffacd0b85a97d-48c6d1aa7f7mr1024551f8f.45.1791272789223; Tue, 06 Oct 2026 00:46:29 -0700 (PDT) Received: from deb05.proceq.com ([213.160.61.66]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-48c6cd7c326sm1526081f8f.53.2026.10.06.00.46.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 06 Oct 2026 00:46:28 -0700 (PDT) From: Mehmet Fide To: Ping-Ke Shih Cc: Luka Gejak , Bitterblue Smith , linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org, mehmet.fide@screeningeagle.com Subject: Re: [PATCH rtw-next v3 2/2] wifi: rtw88: support channel switch in AP mode Date: Tue, 6 Oct 2026 09:46:27 +0200 Message-ID: <20261006074627.372751-1-mehmet.fide@gmail.com> X-Mailer: git-send-email 2.55.0 In-Reply-To: <151d3d60da614e00b3a94bebd4f4f3a8@realtek.com> References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Hi Ping-Ke, On 2026-10-06 Ping-Ke Shih wrote: > There is single one caller, so just squash into rtw_fw_csa_active(). > > I asked to move CS work to vif, because I want to avoid this kind of > getting vif from rsvd_pkt->rtwvif. Is there any way to avoid this? > I'm thinking if we move back csa work to rtwdev (like v2) to avoid this kind of > iterative. > and avoid this iterative. Yes. v4 puts the work back in rtw_dev, initialised once in rtw_core_init(), and adds rtwdev->csa_vif, set when the countdown starts and cleared when it finishes or is cancelled. rtw_fw_csa_active() is then a test of that pointer, and the lookup through the reserved page and both iterations are gone. > Will it be a problem just unconditionally initializing csa work? It was: a hardware restart replays add_interface() with the work still armed, and initialising it again would lose the pending timer. With the work in rtw_dev the question does not arise any more. > As the comment, this is to download new CAM settings. If CSA is ongoning, > you ignore the download. Then, my question is when will you download > this properly? The countdown work downloads the whole reserved page, which includes the PG info page built from the current CAM, once per beacon interval while the switch is announced, so the new settings reach the firmware at most one beacon interval later. The same holds for the TIM update and the download on association, which v4 skips too (Luka). The commit message says so now. Best regards, Mehmet