mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Prashant Singh <singhpra@juniper.net>
To: Ard Biesheuvel <ardb@kernel.org>, Jeremy Kerr <jk@ozlabs.org>,
	"Sebastian Andrzej Siewior" <bigeasy@linutronix.de>
Cc: Prashant Singh <singhpra@juniper.net>,
	Clark Williams <clrkwllms@kernel.org>,
	Steven Rostedt <rostedt@goodmis.org>,
	Jonathan Corbet <corbet@lwn.net>,
	Shuah Khan <skhan@linuxfoundation.org>,
	Randy Dunlap <rdunlap@infradead.org>,
	"Luis Claudio R. Goncalves" <lgoncalv@redhat.com>,
	Steve McIntyre <93sam@debian.org>, <joaoanandalima@gmail.com>,
	<linux-efi@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	<linux-doc@vger.kernel.org>, <linux-rt-devel@lists.linux.dev>
Subject: Re: [PATCH v5] efivarfs: add nostatfs mount option to skip QueryVariableInfo()
Date: Tue, 6 Oct 2026 01:41:58 -0700	[thread overview]
Message-ID: <20261006084158.11523-1-singhpra@juniper.net> (raw)
In-Reply-To: <fd8750f7-a30c-4b60-9254-395858bc9aca@app.fastmail.com>

On Tue, 06 Oct 2026 09:09:33 +0200, Ard Biesheuvel wrote:
> So what happens with uid=/gid= in this case. Do they get reset to the
> default or not? And before this patch?

Preserved, not reset to the GLOBAL_ROOT default -- and unchanged from
before this patch.

efivarfs_reconfigure() applies only nostatfs to the live superblock; it
never touches uid/gid. uid/gid are parsed in efivarfs_parse_param() and
stamped onto inodes at creation in efivarfs_get_inode() (inode->i_uid/i_gid
= opts->uid/gid); reconfigure() has never re-applied them, so they are
effectively mount-time-only. A uid=/gid= given on remount lands in the
throwaway reconfigure fs_context and is ignored -- the live inodes and
show_options keep the original mount values.

Before this patch efivarfs_reconfigure() only had the ro/rw guard
(efivar_supports_writes()) and never applied uid/gid, so there is no
behavioural change; the patch only adds the nostatfs line.

Verified on 6.12 (Xeon), identical on a stock 6.12 without the patch:
  mount -o uid=1000,gid=1000   -> uid=1000,gid=1000  (opts + inode owner)
  mount -o remount             -> still 1000:1000     (preserved)
  mount -o remount,uid=2000    -> still 1000:1000     (ignored)

Thanks,
Prashant

  reply	other threads:[~2026-10-06  8:43 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-05 23:22 Prashant Singh
2026-10-06  7:09 ` Ard Biesheuvel
2026-10-06  8:41   ` Prashant Singh [this message]
2026-10-06 10:04     ` Ard Biesheuvel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261006084158.11523-1-singhpra@juniper.net \
    --to=singhpra@juniper.net \
    --cc=93sam@debian.org \
    --cc=ardb@kernel.org \
    --cc=bigeasy@linutronix.de \
    --cc=clrkwllms@kernel.org \
    --cc=corbet@lwn.net \
    --cc=jk@ozlabs.org \
    --cc=joaoanandalima@gmail.com \
    --cc=lgoncalv@redhat.com \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-efi@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rt-devel@lists.linux.dev \
    --cc=rdunlap@infradead.org \
    --cc=rostedt@goodmis.org \
    --cc=skhan@linuxfoundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®