From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E5DD63B42CB for ; Tue, 6 Oct 2026 09:35:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791279343; cv=none; b=KVSK0ZBExbT296sla/QFD3miMjuq1BPdpxsp2eyYnggnNmxk/UkE/snlnW+gkqNpRguXNb2r/BRrUffkYpftwiVq9wdVAhERG2MdbKTAFeMRP2ppkj0WUhmkwztEEuZoF2vqeqz3Ta2fI1v2YeNRbGHiKK2FRI4a2fByDceSBNQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791279343; c=relaxed/simple; bh=SR50l6vfw4QRs416ALVlOjgrIEeaalnThuxPXEY/1W4=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=FRw0aXapbZHwID3lMEgn9IHCU4Dsf7rS4JNm2HMsJQKX3Qm/iM/YqKG+b36JEdp3TLz2e4mOiXPVdPzvv84Pxv1aavEtcfsVIFL7XgCMAJsrgBdC65BkF/rqUNN/G8lj3knAdz3pIEzyereiXVpfZ4LDwBuGrNh6EGNc0DINsLA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=X6e+X0do; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=T2yer1lt; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="X6e+X0do"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="T2yer1lt" Received: from pps.filterd (m0279867.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 6969QmSR1447197 for ; Tue, 6 Oct 2026 09:35:41 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to; s=qcppdkim1; bh=CQoauwzkMGyF9WpxZI/9afok 1rx7ghu7rviA237AL9Q=; b=X6e+X0do6J+VxdHoFc/REsGh+HIZbaYb2jJAw9QL S43rDz0q/0QJiuckGbbbtq6uoOt6I4G+5mnWEBxlYcSmAVnEYBl5DuRyz+grjq+x FsL8cFmX0xvGleBWxXE5RxBTQRW/85e2eCy0KEW/SgObBR3POGtVD0wJV8ubBJ3Q HcyidC0qSuAnCqTesPc2PO7iOywrMYKVoA0Jt/5FMuX56QmA2J+8QduESq48unJ4 4NrT0tj0ltyfdDKI18+DtqyPb//qAL7faNlTrtfBudnoNyApQxMPUgnXgnHGc/0Q /yrdw7AedaKwS+KbGngu5iQfzB8hyawrSsCaxwcyQAbkhQ== Received: from mail-dy1-f200.google.com (mail-dy1-f200.google.com [74.125.82.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4h4xc5013g-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 06 Oct 2026 09:35:41 +0000 (GMT) Received: by mail-dy1-f200.google.com with SMTP id 5a478bee46e88-341eff9e381so996397eec.1 for ; Tue, 06 Oct 2026 02:35:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1791279340; x=1791884140; darn=vger.kernel.org; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:from:to:cc:subject :date:message-id:reply-to:content-type; bh=CQoauwzkMGyF9WpxZI/9afok1rx7ghu7rviA237AL9Q=; b=T2yer1ltCSfNKCNbTf2RXQOmIvkVWrmgK1bsRp0F+DzYeAZMJaupijmFFtiP0Dy76l JXMG3gjx2/8ifcN101HRP6sLYasFMrFyqZAQ2kXGdqGMkn4GvK4Q9YlBXaRAjkZY2j8W Rwo+zOP6go3eBxc1bvzh8jWVD2At9p1zAGv7M+Uz6C4BEgMDErvAHpHdEaiPe6WEabOV 9ezZxtrI5qqXHmqELZOAlIG0nRSQ0UdUAPJFVBiYzWF/ukuwjA0vpAlOFrbFJPQwo27B fsY0wdBi2PaLNz8z7EQNiZXkqd7AK5LrIq32t4KtNV9U8WqQN9xxj5n7FxS+QDVPLFDd JL5w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1791279340; x=1791884140; h=in-reply-to:content-disposition:content-type:mime-version :references:message-id:subject:cc:to:from:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=CQoauwzkMGyF9WpxZI/9afok1rx7ghu7rviA237AL9Q=; b=XmImse3/pNLSryXho2e6hOVzq552CzxmoKBNJ5V3MEdgUFzp4dRDp9c8FoPWl9AxUa k/0lxid/rYVv8gYt1qJzqFrkluDzF/vK/0v9nwtafCpjzDMTxWk0FFK3RugTRhSxubGL kvhR747YLmZ3B1J4qEeWU+5hyxPneZ/xYkZAlhf44GSAr8NIySDRFQxzgzeAW1p8pxqD YUMGiq1x6tfYnb3dETo+dx89wnf7IE5lZz8fj9CkgTlbpfv4dXdhyMbz7/13+dTG5sph exeAr0VDwLbxPkdwqKdqx5raWp3du2nSqUSrgW7Priox5RqnFjhXCARLu9+xEcBZuey+ icfg== X-Forwarded-Encrypted: i=1; AKwUvBziORRe+aVbp6OemMzlspp2M/iGta/5jzJ5fQNPBKSKFBqOSjInoOQhWZs0V/35Se/GJzzmU7kM1EwIamw=@vger.kernel.org X-Gm-Message-State: AFq9FYIcDmDjcu5AhjD2tWLVs5JprTXbEmu8LLNpf5yzOGZR6L64juhK Ys3kYpcLJb+W9YKe093qlwPVtX75dnNyhoh+5NotqEeHk6Qw1KF2GQQFHF8dINnrGZmrO7mvGRG Zn0pxFDJtdINy+2iii7CAUlKk3d4ZPjq4Sqa4IuP4uZwP4GRric89Tp+NAJiCS22izYE= X-Gm-Gg: AYBFou1tBvLf71gZyGzFEtfwrL2E4tXrOIIKRxcGsfSuNMZHMj5IB2cGB4qf5cK8osU kvbFt0dPgEd+Ck6WNKQQEb1ZIun9nBQpoR04wRQoQqBbetocn5ZNxZ/9TctN13medxxA7biXdI7 3hEnRnd3YEix9R3kewLEFFrOI6dQ2TQuxjS9dZ4T4vgRiGgoOyVPYV/nYxHzQOit4inyNOAXIFn e+9g3BbKMwk/oFFl08mJGxraPOpruGqmzDfShKx8wfddUyQI3yReTg3EksHQRT1mq4EJQhLGXZV vSmBcL30gi/ShiEscXUHA4tsK8qiJn72iWSyBE5J8lROxcjXIn2hNmJgKMDK+poIsQ/t0lRXMCf Tm/2007TRLy6OIZYxLoYjd32+t+I= X-Received: by 2002:a05:693c:8207:b0:328:3cce:4b3b with SMTP id 5a478bee46e88-3514dcbf19cmr1052620eec.4.1791279340334; Tue, 06 Oct 2026 02:35:40 -0700 (PDT) X-Received: by 2002:a05:693c:8207:b0:328:3cce:4b3b with SMTP id 5a478bee46e88-3514dcbf19cmr1052578eec.4.1791279339612; Tue, 06 Oct 2026 02:35:39 -0700 (PDT) Received: from hu-mojha-hyd.qualcomm.com ([202.46.23.25]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-35146b0fdc4sm6903108eec.25.2026.10.06.02.35.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 06 Oct 2026 02:35:39 -0700 (PDT) Date: Tue, 6 Oct 2026 15:05:33 +0530 From: Mukesh Ojha To: Anup Vishwakarma Cc: Manivannan Sadhasivam , Jassi Brar , Huang Yiwei , Sudeep Holla , Jassi Brar , linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/2] mailbox: qcom-ipcc: Remove redundant mbox_controller_unregister() on probe failure Message-ID: <20261006093533.vbaihilgcbxonefv@hu-mojha-hyd.qualcomm.com> References: <20261006-b4-mbox_double_unregister_fix-v1-0-9011ca208d36@oss.qualcomm.com> <20261006-b4-mbox_double_unregister_fix-v1-1-9011ca208d36@oss.qualcomm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20261006-b4-mbox_double_unregister_fix-v1-1-9011ca208d36@oss.qualcomm.com> X-Authority-Analysis: v=2.4 cv=X5THu2Te c=1 sm=1 tr=0 ts=6ac4c0ed cx=c_pps a=PfFC4Oe2JQzmKTvty2cRDw==:117 a=ZePRamnt/+rB5gQjfz0u9A==:17 a=kj9zAlcOel0A:10 a=660iZSQnnn4A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=eoimf2acIAo5FJnRuUoq:22 a=EUspDBNiAAAA:8 a=xVKd0v4-oltqwKU808gA:9 a=CjuIK1q_8ugA:10 a=6Ab_bkdmUrQuMsNx7PHu:22 X-Proofpoint-Spam-Info: AW1haW4tMjYxMDA2MDAzOCBTYWx0ZWRfX55nzrGSZZbPL AGd0MNS0UYiV9J3r+qRJkbZ1tcveQuD6cVApePzLx6Js1EnoB7W8TJK1Ko4dOMjeMR8bADtc0B+ mxbL5XQxYvHkTC45wWfFL7yYjZ5IKB8= X-Proofpoint-GUID: 5isHJZTmj55qb6GNaJnfdjgtkqKvsofu X-Proofpoint-ORIG-GUID: 5isHJZTmj55qb6GNaJnfdjgtkqKvsofu X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYxMDA2MDAzOCBTYWx0ZWRfX8qFrIjBFcgvZ /ND6QA0TJjT5OAI0wR09nDWoi4iIUsrghpRw3p+8sP2+QnOJydM5cj5sDWwZIfbu8+opX/H0ej6 W2KRqI/dTU+qTZAYemGGAMyrJdjVTpzUy8hNUXaH1KrspZchdRHHlQoqRxeyjIFrcSlE0oiyPnr rE1Q37FR9PwUNU42Ob3QicLmESql/zUOpRDpGrZMNBKQ3xdX9sMZ7cv1YrUrKVe021vw7oFe74M dJO5++DVnHvcIhyFGYqPZDVccCmMaClnLrbpvDl50zkc/XMXb0eNTmXJi//eZGxwunEC2cm7Q57 dX2Iaw0rnhkX7s2rj2MCLU/nM/UzMz6CLRDVYggXtA7hjTxqqhn4Cq2YHfYuupg8gHgcFMQDJrK tu6OkW6ec8Sno48N4DCGiROGObtAmUdbovzueqiXDLCEkTLnn2e2hvIoEUe17cKYdZFCh3jOvfM UhL7dlpxdqSiJRCAjRw== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-10-06_02,2026-10-05_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 adultscore=0 malwarescore=0 clxscore=1015 phishscore=0 priorityscore=1501 suspectscore=0 impostorscore=0 spamscore=0 lowpriorityscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2609040000 definitions=main-2610060038 On Tue, Oct 06, 2026 at 02:44:14PM +0530, Anup Vishwakarma wrote: > qcom_ipcc_probe() registers the mailbox controller via > devm_mbox_controller_register(), which automatically calls > mbox_controller_unregister() through devres when the device is removed > or probe fails. If devm_request_irq() subsequently fails, the > err_req_irq: label also manually calls mbox_controller_unregister(), > resulting in a double call that corrupts the global mailbox controller > list and causes a kernel panic. > > Remove the redundant manual call and rely on devres for cleanup. > > Fixes: e9d50e4b4d04 ("mailbox: qcom-ipcc: Dynamic alloc for channel arrangement") > Signed-off-by: Anup Vishwakarma > --- > drivers/mailbox/qcom-ipcc.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/mailbox/qcom-ipcc.c b/drivers/mailbox/qcom-ipcc.c > index 185b63f724d4..206ad4884987 100644 > --- a/drivers/mailbox/qcom-ipcc.c > +++ b/drivers/mailbox/qcom-ipcc.c > @@ -336,8 +336,6 @@ static int qcom_ipcc_probe(struct platform_device *pdev) > return 0; > > err_req_irq: Get rid of label as well.. > - if (ipcc->num_chans) > - mbox_controller_unregister(&ipcc->mbox); > err_mbox: > irq_domain_remove(ipcc->irq_domain); > > with the above fix.. Reviewed-by: Mukesh Ojha -- -Mukesh Ojha