From: Rob Clark <robin.clark@oss.qualcomm.com>
To: dri-devel@lists.freedesktop.org
Cc: linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org,
"Jianfeng Liu" <liujianfeng1994@gmail.com>,
"Christian König" <christian.koenig@amd.com>,
"Rob Clark" <robin.clark@oss.qualcomm.com>,
"Abel Vesa" <abelvesa@kernel.org>,
"Abhinav Kumar" <abhinav.kumar@linux.dev>,
"Andrei Kuchynski" <akuchynski@chromium.org>,
"Benson Leung" <bleung@chromium.org>,
"Chia-Lin Kao (AceLan)" <acelan.kao@canonical.com>,
"David Airlie" <airlied@gmail.com>,
"Dmitry Baryshkov" <lumag@kernel.org>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Heikki Krogerus" <heikki.krogerus@linux.intel.com>,
"Hsin-Te Yuan" <yuanhsinte@chromium.org>,
"Jessica Zhang" <jesszhan0024@gmail.com>,
"Johan Hovold" <johan@kernel.org>,
linux-kernel@vger.kernel.org (open list),
linux-usb@vger.kernel.org (open list:USB TYPEC CLASS),
"Marijn Suijten" <marijn.suijten@somainline.org>,
"Pooja Katiyar" <pooja.katiyar@intel.com>,
"Sean Paul" <sean@poorly.run>, "Simona Vetter" <simona@ffwll.ch>
Subject: [RFT 0/5] drm/msm: DMABUF_DEBUG fixes
Date: Tue, 6 Oct 2026 06:09:51 -0700 [thread overview]
Message-ID: <20261006131000.81501-1-robin.clark@oss.qualcomm.com> (raw)
With DMABUF_DEBUG=y, the page information is stripped from the sgt that
we get for an externally allocated buffer that is dma-buf imported (as
opposed to an exported GEM buffer that is re-imported). This is a bit
unfortunate, since we need that information for mapping the buffer in
both paths:
1. Userspace GPU pgtables (TTBR0), where we use io_pgtable directly.
Fortunately this we can fix ourselves easily.
2. Iommu managed pgtables (scanout, kernel GPU buffers (TTBR1)). In
normal usage that iommu subsystem envisions the dma-mapping and
iommu-mapping are combined. We can't really work around this but
we can stop trying to pretend to be a normal iommu user and just
go directly to the iommu_domain_ops.
This all depends on being dma_map_direct() for the dma_map_sgtable()
to work. This should be the case on modern things that use arm-smmu.
It's less clear when it comes to older pre-arm-smmu hw. It's possible
that this series causes those things to catch fire. If so, look to
commit 0e764a01015d ("iommu/arm-smmu: Allow client devices to select
direct mapping") for inspiration.
Rob Clark (5):
drm/msm: Cleanup if pages_to_sg() fails
drm/msm/gem: dma_map/unmap_sgtable()
drm/msm: Extract out map/unmap helpers
drm/msm: Convert iommu map/unmap to helpers
drm/msm: Convert map helper to use dma-address
drivers/gpu/drm/msm/msm_gem.c | 57 ++++++----
drivers/gpu/drm/msm/msm_iommu.c | 182 ++++++++++++++++++++------------
2 files changed, 153 insertions(+), 86 deletions(-)
--
2.55.0
next reply other threads:[~2026-10-06 13:10 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-06 13:09 Rob Clark [this message]
2026-10-06 13:09 ` [RFT 1/5] drm/msm: Cleanup if pages_to_sg() fails Rob Clark
2026-10-06 13:09 ` [RFT 2/5] drm/msm/gem: dma_map/unmap_sgtable() Rob Clark
2026-10-06 13:09 ` [RFT 3/5] drm/msm: Extract out map/unmap helpers Rob Clark
[not found] ` <20261006131920.6870D1F000FF@smtp.kernel.org>
2026-10-07 5:19 ` Karl Mehltretter
2026-10-06 13:09 ` [RFT 4/5] drm/msm: Convert iommu map/unmap to helpers Rob Clark
[not found] ` <20261006132545.8BFD51F000FF@smtp.kernel.org>
2026-10-07 5:23 ` Karl Mehltretter
2026-10-06 13:09 ` [RFT 5/5] drm/msm: Convert map helper to use dma-address Rob Clark
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261006131000.81501-1-robin.clark@oss.qualcomm.com \
--to=robin.clark@oss.qualcomm.com \
--cc=abelvesa@kernel.org \
--cc=abhinav.kumar@linux.dev \
--cc=acelan.kao@canonical.com \
--cc=airlied@gmail.com \
--cc=akuchynski@chromium.org \
--cc=bleung@chromium.org \
--cc=christian.koenig@amd.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=freedreno@lists.freedesktop.org \
--cc=gregkh@linuxfoundation.org \
--cc=heikki.krogerus@linux.intel.com \
--cc=jesszhan0024@gmail.com \
--cc=johan@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=liujianfeng1994@gmail.com \
--cc=lumag@kernel.org \
--cc=marijn.suijten@somainline.org \
--cc=pooja.katiyar@intel.com \
--cc=sean@poorly.run \
--cc=simona@ffwll.ch \
--cc=yuanhsinte@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®