mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Yongzhao Chen <yongzhao.derek@gmail.com>
To: netdev-bot+sashiko@kernel.org
Cc: netdev@vger.kernel.org, Andrew Lunn <andrew@lunn.ch>,
	Heiner Kallweit <hkallweit1@gmail.com>,
	Russell King <linux@armlinux.org.uk>,
	"David S. Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@kernel.org>,
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
	linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net v2] net: phy: qca83xx: read resolved QCA8337 link status
Date: Tue,  6 Oct 2026 18:03:04 +0200	[thread overview]
Message-ID: <20261006160304.1563-1-yongzhao.derek@gmail.com> (raw)
In-Reply-To: <179113606534.434549.7144959528343737840@kernel.org>

Thanks for the review. I have prepared v3 with the following changes.

For the idle error counter, QCA8337 data sheet 80-Y0619-3 Rev. D,
Table 5-352, page 325 confirms that reads consume the count. My MDIO
model reproduces the loss with v2. The revision keeps
genphy_read_status(), so a steady autonegotiated link no longer causes
the extra MII_STAT1000 read. Reads on link transitions remain as in
the generic path.

For MSFAIL, page 324 confirms that the bit clears on read. The model
reproduces the reported difference when a one-shot fault and AN complete
are visible together. I have not established whether QCA8337 can reach
that combination on hardware. Keeping genphy_read_status() restores
the master/slave-before-LPA order and the generic error handling.

For MDI-X control, I confirmed that QCA8337 has no configuration path
that writes the crossover setting. The revision clears mdix_ctrl to
ETH_TP_MDI_INVALID after each successful status read, including steady
polls, while retaining the MDI-X status report. It does not add a
configuration callback or change the generic ethtool setter.

The revised model checks and arm64 W=1 object build pass. v3 has not
been tested on hardware. I will send it separately.

Thanks,
Yongzhao Chen

pw-bot: cr

      reply	other threads:[~2026-10-06 16:03 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-03 17:32 Yongzhao Chen
2026-10-04 17:47 ` netdev-bot+sashiko
2026-10-06 16:03   ` Yongzhao Chen [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261006160304.1563-1-yongzhao.derek@gmail.com \
    --to=yongzhao.derek@gmail.com \
    --cc=andrew@lunn.ch \
    --cc=davem@davemloft.net \
    --cc=edumazet@kernel.org \
    --cc=hkallweit1@gmail.com \
    --cc=kuba@kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@armlinux.org.uk \
    --cc=netdev-bot+sashiko@kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®