From: Jakub Kicinski <kuba@kernel.org>
To: Karl Mehltretter <kmehltretter@gmail.com>
Cc: netdev@vger.kernel.org, Siddharth Vadapalli <s-vadapalli@ti.com>,
Roger Quadros <rogerq@kernel.org>,
Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@kernel.org>,
Paolo Abeni <pabeni@redhat.com>, Keerthy <j-keerthy@ti.com>,
Kevin Hao <haokexin@gmail.com>,
Alexander Sverdlin <alex@sverdlin.org>,
Arnd Bergmann <arnd@arndb.de>,
linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org,
stable@vger.kernel.org
Subject: Re: [PATCH net 1/2] net: cpsw: unregister secondary netdev on probe failure
Date: Tue, 6 Oct 2026 17:57:21 -0700 [thread overview]
Message-ID: <20261006175721.75e77a3b@kernel.org> (raw)
In-Reply-To: <2f459154f5bca89a07dc978c834e98198c08c331.1791035789.git.kmehltretter@gmail.com>
On Sat, 3 Oct 2026 16:09:14 +0200 Karl Mehltretter wrote:
> + bool secondary_registered = false;
the rule of thumb is that error unwind should match the remove()
If not possible match the condition of the code, don't add local vars
Sashiko is right to suggest to fold the two fixes together.
--
pw-bot: cr
next prev parent reply other threads:[~2026-10-07 0:57 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-03 14:09 [PATCH net 0/2] net: cpsw: fix failed-probe cleanup Karl Mehltretter
2026-10-03 14:09 ` [PATCH net 1/2] net: cpsw: unregister secondary netdev on probe failure Karl Mehltretter
2026-10-07 0:57 ` Jakub Kicinski [this message]
2026-10-03 14:09 ` [PATCH net 2/2] net: cpsw: cancel RX mode work " Karl Mehltretter
2026-10-03 14:13 ` [PATCH net 0/2] net: cpsw: fix failed-probe cleanup netdev-bot+sinfo
2026-10-03 14:29 ` Karl Mehltretter
2026-10-04 14:10 [PATCH net 1/2] net: cpsw: unregister secondary netdev on probe failure netdev-bot+sashiko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261006175721.75e77a3b@kernel.org \
--to=kuba@kernel.org \
--cc=alex@sverdlin.org \
--cc=andrew+netdev@lunn.ch \
--cc=arnd@arndb.de \
--cc=davem@davemloft.net \
--cc=edumazet@kernel.org \
--cc=haokexin@gmail.com \
--cc=j-keerthy@ti.com \
--cc=kmehltretter@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=rogerq@kernel.org \
--cc=s-vadapalli@ti.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®