From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f197.google.com (mail-pl1-f197.google.com [209.85.214.197]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 929F53EF0AA for ; Tue, 6 Oct 2026 20:24:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.197 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791318287; cv=none; b=WDRYeOnFpaONUzPtSuGNY5XcXGZa3vs69534vcFs1RixkykNfueTCOcwhwPENPEfwbAIdp15nGqLDvn9xt76BRKTxYwUd/kG9vPgNNR0hFyQfa76KP7+znVEGWoIF31nvuENxIR03oSawR2mgkaVRyOVH0IZYk+2kqYVR1jrkjI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791318287; c=relaxed/simple; bh=ZMs1I0vHEJ58LnW7kl3Pxyj2r0+UXZyY7hpZLdur94U=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=Vui9GJ/vtiq03XHqT2hiMzqpCiNSJebvcmYrAMOz9EYSXwsW/YlaTt/4JmO0hMISsypBNfHlmfvtA+p3uOI9luvvZrnozwaoSs7I6mLQ6oOSugOKMB9GzRbH7L2Z5ECaWvxzyn/JhmvzuK5tQ8mGaA8GuMU7n5QS/i+7ZWoNj/E= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--shansinha.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=CwGxn/gu; arc=none smtp.client-ip=209.85.214.197 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--shansinha.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="CwGxn/gu" Received: by mail-pl1-f197.google.com with SMTP id d9443c01a7336-2d7443e0f0bso54400875ad.1 for ; Tue, 06 Oct 2026 13:24:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1791318286; x=1791923086; darn=vger.kernel.org; h=content-type:cc:to:from:subject:message-id:references:mime-version :in-reply-to:date:from:to:cc:subject:date:message-id:reply-to :content-type; bh=iP6xZp/taTTzoZCVyCIXKC0KFbdOjG51cDdoA/0MxQM=; b=CwGxn/gueoaO1C/MMRZGjnVY7WxlEwMbCtfPPAsbxQX72d7B7vjxwAd3KlOEeNBJyg GOKaFFlq3b+DJ23739iQ5CzQj3NJKZgQEEFzy+6YS/8Bro5LpT5dGTXlqykfsCtb+65e SIaM+QN32Q5A6vcK3BbyZHRqJ+9Ny2ZtQygmSdfmjc2vFE/qtXxH9kBZj7kMQAUtbxvP bBDlF9+8Xm88MeSqaR606xtZUZCsPgfawf5Bv16mhmbZYDcJ0iGEGY1N9D8ooPd6t+XE DFoHE7HsCJ0E85//L7cfIIsgKmlE2LUFyUDm6b72Ik0Ww24KNTz/fA1GUFaYEuBAe8cr 1+hw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1791318286; x=1791923086; h=content-type:cc:to:from:subject:message-id:references:mime-version :in-reply-to:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=iP6xZp/taTTzoZCVyCIXKC0KFbdOjG51cDdoA/0MxQM=; b=oEEi4R9Sl16GuV1A0sXgNnL/Zrep5F3WufVUmYB1RJw1ZyRhUmxWpag6tzdWXuLSfL REyljL4Qkg9d6KYoP/Z3hmN/J7QrpkYQCP00ZB4A892O/5bpqBJB71lxvbXHhYKSO2Tv bpvcZ9bHAh3mRcqHATQ8w2FjlxYiK5J9t5ADP0KXVLVMtW22hQL1wrWlotnbVT7dMjRq T7G3CrGhzzqwyjvg0bR0svHt1CzdWdIdC81MS8NMSGrLYHDXD7f7bhG2LIsYaS80T2kv RaVkgCHn75eoSwg3OGI70xTzVLEU70FQQeEgmrNrDIfsJm5ZQlPS9qXKu2bq64v9HBE7 wrCA== X-Forwarded-Encrypted: i=1; AKwUvByJ02A6PetVC7bEPUwOr/63ThJuRX/HtBWCsc+wCFVetRCuGlPeK8nJWx+G3nXw+sNrN2lx8vM0Px3UZLQ=@vger.kernel.org X-Gm-Message-State: AFq9FYIrUMCR5knmcSDE/QtX28D7LRFyRbKrQn2xWOFJIpXa/ihwgXc3 /Cd5J3ovF3V2xe6J0aeQ32qD+Plhu7hkmApUwKK6kXM8SPoRW2nc8ep64RBz+Y6TzpS75Cj0c/d uyAw0ZpyNVrhLGz79kQ== X-Received: from plbli6.prod.google.com ([2002:a17:903:2946:b0:2e5:35ae:2a7a]) (user=shansinha job=prod-delivery.src-stubby-dispatcher) by 2002:a17:903:b86:b0:2db:3d84:effc with SMTP id d9443c01a7336-2e5ffabc0c4mr4755845ad.6.1791318285725; Tue, 06 Oct 2026 13:24:45 -0700 (PDT) Date: Tue, 6 Oct 2026 20:24:44 +0000 In-Reply-To: <35ce536c154380a2f8f3af9b2b50069ce16804d0.1791212077.git.prsampat@amd.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <35ce536c154380a2f8f3af9b2b50069ce16804d0.1791212077.git.prsampat@amd.com> X-Mailer: git-send-email 2.56.0.rc1.315.gc6ed9934b7-goog Message-ID: <20261006202444.2676092-1-shansinha@google.com> Subject: Re: [Patch v3 6/7] crypto/ccp: Register with fw_uploader and always fail From: Shantanu Sinha To: prsampat@amd.com, thomas.lendacky@amd.com Cc: mcgrof@kernel.org, russ.weight@linux.dev, dakr@kernel.org, ashish.kalra@amd.com, herbert@gondor.apana.org.au, davem@davemloft.net, linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org, gregkh@linuxfoundation.org, rafael@kernel.org, chao.gao@intel.com, aik@amd.com, tycho@kernel.org, nikunj@amd.com, michael.roth@amd.com Content-Type: text/plain; charset="UTF-8" On 10/5/26 9:15 AM, Pratik R. Sampat wrote: > +#ifdef CONFIG_FW_UPLOAD [...] > +#else /* CONFIG_FW_UPLOAD */ > +static void register_sev_fw_uploader(struct sev_device *sev) { } > +static void unregister_sev_fw_uploader(struct sev_device *sev) { } > +#endif /* CONFIG_FW_UPLOAD */ There's no Kconfig change in this patch. Should CRYPTO_DEV_SP_PSP select FW_UPLOAD? It defaults to N, and the other fw_upload users select it. Thanks, Shantanu