From: Gerd Bayer <gbayer@linux.ibm.com>
To: Niklas Schnelle <schnelle@linux.ibm.com>,
Heiko Carstens <hca@linux.ibm.com>,
Benjamin Block <bblock@linux.ibm.com>,
Ramesh Errabolu <ramesh@linux.ibm.com>,
Matthew Rosato <mjrosato@linux.ibm.com>
Cc: Vasily Gorbik <gor@linux.ibm.com>,
Alexander Gordeev <agordeev@linux.ibm.com>,
Christian Borntraeger <borntraeger@linux.ibm.com>,
Sven Schnelle <svens@linux.ibm.com>,
Gerald Schaefer <gerald.schaefer@linux.ibm.com>,
"Joerg Roedel (AMD)" <joro@8bytes.org>,
Farhan Ali <alifm@linux.ibm.com>, Cam Miller <cam@linux.ibm.com>,
Will Deacon <will@kernel.org>,
Robin Murphy <robin.murphy@arm.com>,
linux-s390@vger.kernel.org, linux-kernel@vger.kernel.org,
iommu@lists.linux.dev, Gerd Bayer <gbayer@linux.ibm.com>
Subject: [PATCH 0/3] s390/pci: Updates to PCI insn tracing
Date: Wed, 07 Oct 2026 13:07:01 +0200 [thread overview]
Message-ID: <20261007-rpcit_trcfh_upstream-v1-0-8a2718cfb90b@linux.ibm.com> (raw)
While debugging some issues, I found that insn traces for RPCIT are
lacking an indication for which PCI function translation tables needed
to be synchronized with hypervisors and/or firmware and that the 64bit
address fields are traced at odd addresses. While looking into how to
address this, I found another small oddity in that the code leading to
the RPCIT instruction was expanding the 32bit function handle to a 64bit
value for the inline assembly way too high in the call-chain.
So I started this small series to address these three issues:
1/3 - Insert padding into the insn trace at natural boundaries
2/3 - Pass function handle in 32bit variables as long as possible
3/3 - Introduce a RPCIT variant of insn trace - adding function handle
With this series applied (+ a test patch to trace RPCIT even in CC0
situations) an entry in /sys/kernel/debug/s390dbf/pci_error/hex_ascii
looks like the following (removed time-stamp and ASCII transcription,
replaced instruction address with "<IA>"):
2 - 0001 <IA> 52 00 00 00 00 00 00 00 85 00 32 2e 00 00 00 00
^ ^ ^ <--------->
| | Status function handle
| Condition Code
"encoded" insn
2 - 0001 <IA> 00 00 00 01 ff 04 90 00 00 00 00 00 00 00 10 00
<--------------------->
<---------------------> IOVA range
start IOVA
I hope you'll find this useful,
Gerd
Signed-off-by: Gerd Bayer <gbayer@linux.ibm.com>
---
Gerd Bayer (3):
s390/pci: Adjust alignment in insn trace
s390/pci: Use 32-bit fh outside of inline asm
s390/pci: Add function handle to RPCIT insn trace
arch/s390/include/asm/pci_insn.h | 2 +-
arch/s390/pci/pci_insn.c | 43 +++++++++++++++++++++++++++++++++-------
drivers/iommu/s390-iommu.c | 8 +++-----
3 files changed, 40 insertions(+), 13 deletions(-)
---
base-commit: 602042bf29f6efde39cfb5fdd9289bf4854bc0c5
change-id: 20261007-rpcit_trcfh_upstream-3e6fa73dff1b
Best regards,
--
Gerd Bayer <gbayer@linux.ibm.com>
next reply other threads:[~2026-10-07 11:07 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-07 11:07 Gerd Bayer [this message]
2026-10-07 11:07 ` [PATCH 1/3] s390/pci: Adjust alignment in insn trace Gerd Bayer
2026-10-07 11:07 ` [PATCH 2/3] s390/pci: Use 32-bit fh outside of inline asm Gerd Bayer
2026-10-07 11:07 ` [PATCH 3/3] s390/pci: Add function handle to RPCIT insn trace Gerd Bayer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261007-rpcit_trcfh_upstream-v1-0-8a2718cfb90b@linux.ibm.com \
--to=gbayer@linux.ibm.com \
--cc=agordeev@linux.ibm.com \
--cc=alifm@linux.ibm.com \
--cc=bblock@linux.ibm.com \
--cc=borntraeger@linux.ibm.com \
--cc=cam@linux.ibm.com \
--cc=gerald.schaefer@linux.ibm.com \
--cc=gor@linux.ibm.com \
--cc=hca@linux.ibm.com \
--cc=iommu@lists.linux.dev \
--cc=joro@8bytes.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=mjrosato@linux.ibm.com \
--cc=ramesh@linux.ibm.com \
--cc=robin.murphy@arm.com \
--cc=schnelle@linux.ibm.com \
--cc=svens@linux.ibm.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®