From: Hermes Wu via B4 Relay <devnull+Hermes.wu.ite.com.tw@kernel.org>
To: Hermes Wu <Hermes.Wu@ite.com.tw>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Hans Verkuil <hverkuil+cisco@kernel.org>
Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org,
Hermes Wu <Hermes.wu@ite.com.tw>
Subject: [PATCH v2 1/2] media: i2c: it6625: wait 1s after reset release
Date: Wed, 07 Oct 2026 18:31:52 +0800 [thread overview]
Message-ID: <20261007-upstream-it6625-reset-delay-v2-1-c5d6b2522bbe@ite.com.tw> (raw)
In-Reply-To: <20261007-upstream-it6625-reset-delay-v2-0-c5d6b2522bbe@ite.com.tw>
From: Hermes Wu <Hermes.wu@ite.com.tw>
The IT6625/IT6626 are controlled through an on-chip MCU, which needs up
to 1s after the reset line is released before it boots and answers on
the I2C interface. The probe path only waits 10 ms before reading the
chip ID, so the read can happen before the MCU is up and probe then
fails.
Wait 1s after releasing reset.
Fixes: 142e5f00bd57 ("media: i2c: add driver for ITE IT6625/IT6626")
Signed-off-by: Hermes Wu <Hermes.wu@ite.com.tw>
---
drivers/media/i2c/it6625.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/media/i2c/it6625.c b/drivers/media/i2c/it6625.c
index b74df9dbf8c2cab7461c69bc0f926141ed7a506c..fc8b22cc1c9ba3612f9c55bea1de61fa9a9c0e84 100644
--- a/drivers/media/i2c/it6625.c
+++ b/drivers/media/i2c/it6625.c
@@ -2260,7 +2260,8 @@ static int it6625_probe(struct i2c_client *client)
if (it6625->reset_gpio) {
usleep_range(1000, 2000);
gpiod_set_value_cansleep(it6625->reset_gpio, 0);
- usleep_range(10000, 11000);
+ /* the MCU needs up to 1s to boot after reset release */
+ msleep(1000);
}
err = it6625_regmap_i2c_init(client, it6625);
--
2.34.1
next prev parent reply other threads:[~2026-10-07 10:31 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-07 10:31 [PATCH v2 0/2] media: i2c: it6625: fix MCU reset and host control timing Hermes Wu via B4 Relay
2026-10-07 10:31 ` Hermes Wu via B4 Relay [this message]
2026-10-07 10:31 ` [PATCH v2 2/2] media: i2c: it6625: allow 250 ms for host control requests to complete Hermes Wu via B4 Relay
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261007-upstream-it6625-reset-delay-v2-1-c5d6b2522bbe@ite.com.tw \
--to=devnull+hermes.wu.ite.com.tw@kernel.org \
--cc=Hermes.Wu@ite.com.tw \
--cc=hverkuil+cisco@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®