From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pg1-f173.google.com (mail-pg1-f173.google.com [209.85.215.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 24BC7221F24 for ; Wed, 7 Oct 2026 02:29:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.173 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791340165; cv=none; b=ZOeAm/40JzIqtn2ift9gR0XXBLXYb8ZLxJgKs0eNCBhuv2IvNmWl0uIMnK6y66eHTRmk/um3mQD9tDQ9A5vw7fMzL+81KjRYDvKfijN5y/3rppUVcFdHqU7cU9CtST3XKTbHgLpKochrIARTLQGdyuXJ0QZy1L1s0X4abO71ot4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791340165; c=relaxed/simple; bh=9T6d1BZ8/LWdQTJFhtX7GkFtSnfVgUks/xtRX7qiAOg=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=IFc+4dHtzVh9Ukim/Setc0surQkFuPL7pLdnao/8USL//SXuaIoI/nKX9VWTN7Kpk7qSpZgjfuu4dKP8uAL/wbOkvna1IiEVXJslKdWmmco4PCLK8tz124A8MpFAGCEGxsZmqo3KG6oaET1LJWs2UteItPSqHuCbtRUHjxUmcRA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=CTYYgQo5; arc=none smtp.client-ip=209.85.215.173 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="CTYYgQo5" Received: by mail-pg1-f173.google.com with SMTP id 41be03b00d2f7-ccce6d9abfeso895566a12.1 for ; Tue, 06 Oct 2026 19:29:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1791340163; x=1791944963; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=dxeJdMFoW0J78hQBPAdY2BYch+3WAegpP1Gcc/5JA+k=; b=CTYYgQo5Ka0RLAdsbHsAwyd10k7YxJcd5F52KrF4lv/1Zf0w6Wf0HbDE7jExZgbWXG 6BPCDavIpCYCxq0veX4vTFJV6/nq1x/vbI/NItAnMe04jlC9BkKumfVp6PI2jQcz7nRd CKRq8OH4fWB/YvnWV2jWvev0OyZ5rfh70ibJEv48EQUF4BsrH4u8Ifioi/kSUg6A4Na7 k/L9ojCdNIosrZ9KQnU95RU1Hozs5Ztcfe5C/xX3PnTEiihTgzxQtsrrz/CEwshMXfXo t5JHNbnk74JPaYx+xMra3GfgnF79ujTpbWQqh2O9ARAcp2aFlgtjr9O+0bPIXqHkvY3/ rPGA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1791340163; x=1791944963; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=dxeJdMFoW0J78hQBPAdY2BYch+3WAegpP1Gcc/5JA+k=; b=UFpAVAzvHyNt3joXW9nWCpnZLrSHWNrb3aJUptJreO36TsvZ1qcAVecAetuzqvqlth 44CG7rAWNruSCgWyGLcm203KWl6UX8T6R3TX6w1OVdydP9kzlG0RAMLvPJjiPFIZr3Ex m7o+1d8McnXBroC5E0slBZGeSdxlHTOsEbnLDaHu6NLTq5DTUk9XO+8Dhhj7ef3pjjjy vLlIN9etPTnXlZC5t6ueV2HGNLP6DIRdxzU6FN2a7kFpkqDIqD2ym1mh8EzIZ6+webF0 2dNDHEyngv81s384Rv/qWciSrzp3hCGCQ/5FwG4XcrYnSgaTMc2qiD4NgdEzSebS+YeI 5YwQ== X-Forwarded-Encrypted: i=1; AKwUvBwfS9xZhvE/kA9uR4ZQ9kHQfGitdKjUOxieTZrdVTkPn7oZiRLe29uDEYlM7o9NBPbxnjC2R00s729guqc=@vger.kernel.org X-Gm-Message-State: AFq9FYIbyO1sIVv7s9tLzB5MhIDvj099QXLWAIdDTs36svlGj+JiNyzs ETxUu++xfiAIrSrxZuIey8+8hFkeqFat/k//rdptC9WrkRnXfMSJwva6 X-Gm-Gg: AYBFou3rSv+GkYp1WTpVybHO6hjoZejdMQZQtt622XaZTZuLBWfwpcnOnI89WmcjPlW VPk8apvnY0WOQG1eAsym5d6fCq3QW5FuJaATx2b6Dg26PRGDQxpta25D/BjOkVyLGZsk3GXEYlk ulE/bcDkg4b2FNLNT/xkURYpmVEtVzF6Lx4RFAjhzLKjEy1mpMOZGCJogRtbIZOiuNwJuWHuynp 9o5AfuTZVqkOaKIa5yaNP2VPK9BwFOP9yiUH6xsaLjM3Iij1vR5WN2+4zWcTgGZERrbVfGtxO8/ O1cpOes2xr8QxpKOH5NZBFzyGVIdsHW3vyi6Dr8sssSrBiZPOyeGUwxPyhAIwoP23c4SCJR9Qh5 hZgA/7G26IcAzGalTzEZrHWvKuCnVyx8IcDttlywHuWX7DIZPun7+4i4oQT+Sr0JTiMbahMncxX 3SSfEOW5ZQiBbxQlAx9JsTr/Qa/07RvJTqaVS/VvdGki8d6E1ABfPBRitoci5wzXoFiyM6cGp7w 2PbjzfnoWU2hRtcQ2qgI0Z8KBqtMw== X-Received: by 2002:a17:90b:4a02:b0:3a6:e99b:bbdb with SMTP id 98e67ed59e1d1-3a8a12c36efmr870489a91.50.1791340162941; Tue, 06 Oct 2026 19:29:22 -0700 (PDT) Received: from kernel.tail6741c6.ts.net ([216.195.201.24]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-3a89b5c5d9asm2090836a91.11.2026.10.06.19.29.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 06 Oct 2026 19:29:22 -0700 (PDT) From: Kunwu Chan To: arnd@arndb.de, anna-maria@linutronix.de, frederic@kernel.org, mingo@kernel.org, tglx@kernel.org Cc: linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org, Kunwu Chan Subject: [PATCH v3 2/2] timers/nohz: Mark got_idle_tick accesses as same-CPU races Date: Wed, 7 Oct 2026 10:28:59 +0800 Message-ID: <20261007022859.60101-3-kunwu.chan@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20261007022859.60101-1-kunwu.chan@gmail.com> References: <20261007022859.60101-1-kunwu.chan@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit got_idle_tick is a per-CPU flag set by the tick interrupt handler in tick_sched_do_timer() and read and cleared by the idle path in tick_nohz_idle_got_tick(). The flag is intentionally accessed without ordering or locking; a concurrent set can be overwritten by the clear. Use WRITE_ONCE_THIS_CPU() and READ_ONCE_THIS_CPU() to identify these as intentional races between execution contexts on the same CPU, rather than accesses that may race across CPUs. Suggested-by: Thomas Gleixner Reviewed-by: Frederic Weisbecker Signed-off-by: Kunwu Chan --- kernel/time/tick-sched.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/kernel/time/tick-sched.c b/kernel/time/tick-sched.c index 6c3fea386..a136bb247 100644 --- a/kernel/time/tick-sched.c +++ b/kernel/time/tick-sched.c @@ -269,7 +269,7 @@ static void tick_sched_do_timer(struct tick_sched *ts, ktime_t now) } if (tick_sched_flag_test(ts, TS_FLAG_INIDLE)) - ts->got_idle_tick = 1; + WRITE_ONCE_THIS_CPU(ts->got_idle_tick, 1); } static void tick_sched_handle(struct tick_sched *ts, struct pt_regs *regs) @@ -1248,8 +1248,8 @@ bool tick_nohz_idle_got_tick(void) { struct tick_sched *ts = this_cpu_ptr(&tick_cpu_sched); - if (ts->got_idle_tick) { - ts->got_idle_tick = 0; + if (READ_ONCE_THIS_CPU(ts->got_idle_tick)) { + WRITE_ONCE_THIS_CPU(ts->got_idle_tick, 0); return true; } return false; -- 2.43.0