From: Ido Schimmel <idosch@nvidia.com>
To: Daehyeon Ko <4ncienth@gmail.com>
Cc: David Ahern <dsahern@kernel.org>,
"David S . Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Simon Horman <horms@kernel.org>, Amit Cohen <amcohen@nvidia.com>,
Roopa Prabhu <roopa@nvidia.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net] ipv4: do not warn on route notification size race
Date: Wed, 7 Oct 2026 14:40:03 +0300 [thread overview]
Message-ID: <20261007114003.GA1011260@shredder> (raw)
In-Reply-To: <20261007045410.3806739-1-4ncienth@gmail.com>
On Wed, Oct 07, 2026 at 01:54:10PM +0900, Daehyeon Ko wrote:
> Commit 680aea08e78c ("net: ipv4: Emit notification when fib hardware
> flags are changed") added asynchronous route notifications for hardware
> flag changes.
>
> fib_alias_hw_flags_set() sizes the skb with fib_nlmsg_size() and later
> fills it with fib_dump_info() while holding only RCU. With nexthop
> compatibility mode enabled, a concurrent replacement can grow the group
> between these independent snapshots. fib_dump_info() can then
> legitimately return -EMSGSIZE, so the warning does not prove a sizing bug.
>
> Remove the warning. The existing error path still frees the skb and
> reports the error to listeners.
>
> Fixes: 680aea08e78c ("net: ipv4: Emit notification when fib hardware flags are changed")
> Reported-by: Ido Schimmel <idosch@nvidia.com>
> Link: https://lore.kernel.org/netdev/20261004082043.GB92032@shredder/
> Suggested-by: Ido Schimmel <idosch@nvidia.com>
> Cc: stable@vger.kernel.org
> Assisted-by: LLM
> Signed-off-by: Daehyeon Ko <4ncienth@gmail.com>
> ---
> No new build or runtime test was run. This is the exact two-line deletion
> suggested in the linked review.
The previous series was IPv4-specific and I forgot that
fib6_info_hw_flags_set() has the same problem. Please include the IPv6
fix as patch 2 of v2. Wait 24h before posting per:
https://docs.kernel.org/next/process/maintainer-netdev.html
prev parent reply other threads:[~2026-10-07 11:40 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-07 4:54 Daehyeon Ko
2026-10-07 4:59 ` netdev-bot+sinfo
2026-10-07 11:40 ` Ido Schimmel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261007114003.GA1011260@shredder \
--to=idosch@nvidia.com \
--cc=4ncienth@gmail.com \
--cc=amcohen@nvidia.com \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=roopa@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®