mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Muhammad Bilal <meatuni001@gmail.com>
To: "Jorge Lopez" <jorge.lopez2@hp.com>,
	"Hans de Goede" <hansg@kernel.org>,
	"Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>
Cc: "Andy Shevchenko" <andriy.shevchenko@linux.intel.com>,
	"Thomas Weißschuh" <linux@weissschuh.net>,
	platform-driver-x86@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	"Muhammad Bilal" <meatuni001@gmail.com>
Subject: [PATCH v5 0/9] platform/x86: hp-bioscfg: buffer handling fixes
Date: Wed,  7 Oct 2026 18:47:02 +0500	[thread overview]
Message-ID: <20261007134711.473857-1-meatuni001@gmail.com> (raw)

Buffer handling fixes for hp-bioscfg.

Patches 1-2 fix hp_get_string_from_buffer(), 3-5 the password
handling, 6 the single line input check, 7-9 SPM and integer parsing.

Changes in v5:
 - Fix the multi-line comment style in patch 1 (Andy)
 - Reword the changelog of patch 4 (Ilpo)
 - Limit the scan in hp_enforce_single_line_input() to the string
   instead of copying the input past its first NUL in patch 6 (Ilpo)
 - Include array_size.h in patch 7 (Ilpo)
 - Copy the token with kstrndup() in patch 8 (Ilpo)

Changes in v4:
 - Add patches 4-9

Changes in v3:
 - Drop Suggested-by: Andy Shevchenko from patch 2, tidy its includes
   and declarations (Andy)
 - Return -E2BIG instead of -ERANGE in patch 3 (Andy)
 - Drop a blank line in the declarations in patch 1 (Andy)

Changes in v2:
 - Split the hp_get_string_from_buffer() fix in two (Ilpo)
 - Drop the lib/string_helpers patch, use @only of string_escape_mem()
   instead (Andy)
 - Add patch 3

Muhammad Bilal (9):
  platform/x86: hp-bioscfg: fix OOB reads in hp_get_string_from_buffer()
  platform/x86: hp-bioscfg: fix non-ASCII truncation in
    hp_get_string_from_buffer()
  platform/x86: hp-bioscfg: return -E2BIG from validate_password_input()
  platform/x86: hp-bioscfg: allow clearing current_password
  platform/x86: hp-bioscfg: fix off-by-one in password length check
  platform/x86: hp-bioscfg: fix heap OOB in
    hp_enforce_single_line_input()
  platform/x86: hp-bioscfg: validate SPM state returned by firmware
  platform/x86: hp-bioscfg: NUL-terminate the SPM auth token
  platform/x86: hp-bioscfg: fix oops on short integer attribute buffer

 drivers/platform/x86/hp/hp-bioscfg/bioscfg.c  | 82 ++++++-------------
 .../x86/hp/hp-bioscfg/int-attributes.c        |  7 +-
 .../x86/hp/hp-bioscfg/passwdobj-attributes.c  | 18 ++--
 .../x86/hp/hp-bioscfg/spmobj-attributes.c     |  9 +-
 4 files changed, 53 insertions(+), 63 deletions(-)

-- 
2.55.0


             reply	other threads:[~2026-10-07 13:47 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-07 13:47 Muhammad Bilal [this message]
2026-10-07 13:47 ` [PATCH v5 1/9] platform/x86: hp-bioscfg: fix OOB reads in hp_get_string_from_buffer() Muhammad Bilal
2026-10-07 13:47 ` [PATCH v5 2/9] platform/x86: hp-bioscfg: fix non-ASCII truncation " Muhammad Bilal
2026-10-07 13:47 ` [PATCH v5 3/9] platform/x86: hp-bioscfg: return -E2BIG from validate_password_input() Muhammad Bilal
2026-10-07 13:47 ` [PATCH v5 4/9] platform/x86: hp-bioscfg: allow clearing current_password Muhammad Bilal
2026-10-07 13:47 ` [PATCH v5 5/9] platform/x86: hp-bioscfg: fix off-by-one in password length check Muhammad Bilal
2026-10-07 13:47 ` [PATCH v5 6/9] platform/x86: hp-bioscfg: fix heap OOB in hp_enforce_single_line_input() Muhammad Bilal
2026-10-07 13:47 ` [PATCH v5 7/9] platform/x86: hp-bioscfg: validate SPM state returned by firmware Muhammad Bilal
2026-10-07 13:47 ` [PATCH v5 8/9] platform/x86: hp-bioscfg: NUL-terminate the SPM auth token Muhammad Bilal
2026-10-07 13:47 ` [PATCH v5 9/9] platform/x86: hp-bioscfg: fix oops on short integer attribute buffer Muhammad Bilal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261007134711.473857-1-meatuni001@gmail.com \
    --to=meatuni001@gmail.com \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=hansg@kernel.org \
    --cc=ilpo.jarvinen@linux.intel.com \
    --cc=jorge.lopez2@hp.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@weissschuh.net \
    --cc=platform-driver-x86@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®