From: Takashi Iwai <tiwai@suse.de>
To: linux-sound@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
Subject: [PATCH v3 3/7] ALSA: pcmtest: Use platform_device_register_simple()
Date: Wed, 7 Oct 2026 19:25:21 +0200 [thread overview]
Message-ID: <20261007172533.14667-4-tiwai@suse.de> (raw)
In-Reply-To: <20261007172533.14667-1-tiwai@suse.de>
It's more standard for this kind of device that doesn't need any
special handling. This allows us to delete the stub release callback.
Signed-off-by: Takashi Iwai <tiwai@suse.de>
---
sound/drivers/pcmtest.c | 23 ++++++++++-------------
1 file changed, 10 insertions(+), 13 deletions(-)
diff --git a/sound/drivers/pcmtest.c b/sound/drivers/pcmtest.c
index b4e333b4c438..393f132a438b 100644
--- a/sound/drivers/pcmtest.c
+++ b/sound/drivers/pcmtest.c
@@ -446,10 +446,6 @@ static snd_pcm_uframes_t snd_pcmtst_pcm_pointer(struct snd_pcm_substream *substr
return bytes_to_frames(substream->runtime, v_iter->buf_pos);
}
-static void pcmtst_pdev_release(struct device *dev)
-{
-}
-
static int snd_pcmtst_pcm_prepare(struct snd_pcm_substream *substream)
{
struct snd_pcm_runtime *runtime = substream->runtime;
@@ -586,15 +582,14 @@ static int pcmtst_probe(struct platform_device *pdev)
return 0;
}
-static struct platform_device pcmtst_pdev = {
- .name = "pcmtest",
- .dev.release = pcmtst_pdev_release,
-};
+#define SND_PCMTEST_DRIVER "pcmtest"
+
+static struct platform_device *pcmtst_pdev;
static struct platform_driver pcmtst_pdrv = {
.probe = pcmtst_probe,
.driver = {
- .name = "pcmtest",
+ .name = SND_PCMTEST_DRIVER,
},
};
@@ -706,12 +701,14 @@ static int __init mod_init(void)
err = init_debug_files(buf_allocated);
if (err)
goto err_free_patterns;
- err = platform_device_register(&pcmtst_pdev);
- if (err)
+ pcmtst_pdev = platform_device_register_simple(SND_PCMTEST_DRIVER, -1, NULL, 0);
+ if (IS_ERR(pcmtst_pdev)) {
+ err = PTR_ERR(pcmtst_pdev);
goto err_clear_debug;
+ }
err = platform_driver_register(&pcmtst_pdrv);
if (err) {
- platform_device_unregister(&pcmtst_pdev);
+ platform_device_unregister(pcmtst_pdev);
goto err_clear_debug;
}
@@ -730,7 +727,7 @@ static void __exit mod_exit(void)
free_pattern_buffers();
platform_driver_unregister(&pcmtst_pdrv);
- platform_device_unregister(&pcmtst_pdev);
+ platform_device_unregister(pcmtst_pdev);
}
MODULE_DESCRIPTION("Virtual ALSA driver for PCM testing/fuzzing");
--
2.55.0
next prev parent reply other threads:[~2026-10-07 17:25 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-07 17:25 [PATCH v3 0/7] ALSA: Fix yet more bugs reported by Sashiko Takashi Iwai
2026-10-07 17:25 ` [PATCH v3 1/7] ALSA: seq: Fix missing direction and ump_group handling in 32bit compat ioctl Takashi Iwai
2026-10-07 17:25 ` [PATCH v3 2/7] ALSA: pcmtest: Fix leak at probe error Takashi Iwai
2026-10-07 17:25 ` Takashi Iwai [this message]
2026-10-07 17:25 ` [PATCH v3 4/7] ALSA: info: Fix memory leak at card removal Takashi Iwai
2026-10-07 17:25 ` [PATCH v3 5/7] ALSA: aloop: Avoid a bad mixure of guard() and goto Takashi Iwai
2026-10-07 17:25 ` [PATCH v3 6/7] ALSA: core: Fix leaks at snd_card_init() error paths Takashi Iwai
2026-10-07 17:25 ` [PATCH v3 7/7] ALSA: seq: Don't lose partial read failure Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261007172533.14667-4-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®