From: Emerson Busson <emersonbusson@gmail.com>
To: mhklinux@outlook.com
Cc: kys@microsoft.com, haiyangz@microsoft.com, wei.liu@kernel.org,
decui@microsoft.com, andrew+netdev@lunn.ch, davem@davemloft.net,
edumazet@google.com, kuba@kernel.org, pabeni@redhat.com,
gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org,
linux-hyperv@vger.kernel.org, netdev@vger.kernel.org
Subject: [PATCH v2 03/14] uio: hv_generic: describe buffers for owned allocation
Date: Wed, 7 Oct 2026 16:07:41 -0300 [thread overview]
Message-ID: <20261007190752.336426-4-emersonbusson@gmail.com> (raw)
In-Reply-To: <20261007190752.336426-1-emersonbusson@gmail.com>
Group receive and send backing in VMBus descriptors before adopting the
owned allocation and release APIs. Keep the existing vzalloc and
ordinary GPADL path until the lifetime prerequisites land.
Signed-off-by: Emerson Busson <emersonbusson@gmail.com>
---
drivers/uio/uio_hv_generic.c | 70 +++++++++++++++++-------------------
1 file changed, 32 insertions(+), 38 deletions(-)
diff --git a/drivers/uio/uio_hv_generic.c b/drivers/uio/uio_hv_generic.c
index b3f41ffc74f8..2cb95b4786ca 100644
--- a/drivers/uio/uio_hv_generic.c
+++ b/drivers/uio/uio_hv_generic.c
@@ -56,12 +56,10 @@ struct hv_uio_private_data {
struct hv_device *device;
atomic_t refcnt;
- void *recv_buf;
- struct vmbus_gpadl recv_gpadl;
+ struct vmbus_buffer recv_buffer;
char recv_name[32]; /* "recv_4294967295" */
- void *send_buf;
- struct vmbus_gpadl send_gpadl;
+ struct vmbus_buffer send_buffer;
char send_name[32];
};
@@ -197,19 +195,13 @@ hv_uio_new_channel(struct vmbus_channel *new_sc)
static void
hv_uio_cleanup(struct hv_device *dev, struct hv_uio_private_data *pdata)
{
- if (pdata->send_gpadl.gpadl_handle) {
- if (vmbus_teardown_gpadl(dev->channel, &pdata->send_gpadl))
- pdata->send_gpadl.leak = true;
- if (!pdata->send_gpadl.leak && !pdata->send_gpadl.decrypted)
- vfree(pdata->send_buf);
- }
+ if (pdata->send_buffer.gpadl.gpadl_handle)
+ vmbus_teardown_gpadl(dev->channel, &pdata->send_buffer.gpadl);
+ vmbus_release_buffer(&pdata->send_buffer);
- if (pdata->recv_gpadl.gpadl_handle) {
- if (vmbus_teardown_gpadl(dev->channel, &pdata->recv_gpadl))
- pdata->recv_gpadl.leak = true;
- if (!pdata->recv_gpadl.leak && !pdata->recv_gpadl.decrypted)
- vfree(pdata->recv_buf);
- }
+ if (pdata->recv_buffer.gpadl.gpadl_handle)
+ vmbus_teardown_gpadl(dev->channel, &pdata->recv_buffer.gpadl);
+ vmbus_release_buffer(&pdata->recv_buffer);
}
/* VMBus primary channel is opened on first use */
@@ -306,48 +298,50 @@ hv_uio_probe(struct hv_device *dev,
pdata->info.mem[MON_PAGE_MAP].memtype = UIO_MEM_LOGICAL;
if (channel->device_id == HV_NIC) {
- pdata->recv_buf = vzalloc(RECV_BUFFER_SIZE);
- if (!pdata->recv_buf) {
+ pdata->recv_buffer.addr =
+ vzalloc(RECV_BUFFER_SIZE);
+ if (!pdata->recv_buffer.addr) {
ret = -ENOMEM;
goto fail_free_ring;
}
- ret = vmbus_establish_gpadl(channel, pdata->recv_buf,
- RECV_BUFFER_SIZE, &pdata->recv_gpadl);
- if (ret) {
- if (!pdata->recv_gpadl.leak &&
- !pdata->recv_gpadl.decrypted)
- vfree(pdata->recv_buf);
+ ret = vmbus_establish_gpadl(channel,
+ pdata->recv_buffer.addr,
+ RECV_BUFFER_SIZE,
+ &pdata->recv_buffer.gpadl);
+ pdata->recv_buffer.leak |= pdata->recv_buffer.gpadl.leak;
+ if (ret)
goto fail_close;
- }
/* put Global Physical Address Label in name */
snprintf(pdata->recv_name, sizeof(pdata->recv_name),
- "recv:%u", pdata->recv_gpadl.gpadl_handle);
+ "recv:%u", pdata->recv_buffer.gpadl.gpadl_handle);
pdata->info.mem[RECV_BUF_MAP].name = pdata->recv_name;
- pdata->info.mem[RECV_BUF_MAP].addr = (uintptr_t)pdata->recv_buf;
+ pdata->info.mem[RECV_BUF_MAP].addr =
+ (uintptr_t)pdata->recv_buffer.addr;
pdata->info.mem[RECV_BUF_MAP].size = RECV_BUFFER_SIZE;
pdata->info.mem[RECV_BUF_MAP].memtype = UIO_MEM_VIRTUAL;
- pdata->send_buf = vzalloc(SEND_BUFFER_SIZE);
- if (!pdata->send_buf) {
+ pdata->send_buffer.addr =
+ vzalloc(SEND_BUFFER_SIZE);
+ if (!pdata->send_buffer.addr) {
ret = -ENOMEM;
goto fail_close;
}
- ret = vmbus_establish_gpadl(channel, pdata->send_buf,
- SEND_BUFFER_SIZE, &pdata->send_gpadl);
- if (ret) {
- if (!pdata->send_gpadl.leak &&
- !pdata->send_gpadl.decrypted)
- vfree(pdata->send_buf);
+ ret = vmbus_establish_gpadl(channel,
+ pdata->send_buffer.addr,
+ SEND_BUFFER_SIZE,
+ &pdata->send_buffer.gpadl);
+ pdata->send_buffer.leak |= pdata->send_buffer.gpadl.leak;
+ if (ret)
goto fail_close;
- }
snprintf(pdata->send_name, sizeof(pdata->send_name),
- "send:%u", pdata->send_gpadl.gpadl_handle);
+ "send:%u", pdata->send_buffer.gpadl.gpadl_handle);
pdata->info.mem[SEND_BUF_MAP].name = pdata->send_name;
- pdata->info.mem[SEND_BUF_MAP].addr = (uintptr_t)pdata->send_buf;
+ pdata->info.mem[SEND_BUF_MAP].addr =
+ (uintptr_t)pdata->send_buffer.addr;
pdata->info.mem[SEND_BUF_MAP].size = SEND_BUFFER_SIZE;
pdata->info.mem[SEND_BUF_MAP].memtype = UIO_MEM_VIRTUAL;
}
--
2.43.0
next prev parent reply other threads:[~2026-10-07 19:08 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-07 19:07 [PATCH v2 0/14] hv: vmbus: make rings and host-visible buffers survive buddy fragmentation Emerson Busson
2026-10-07 19:07 ` [PATCH v2 01/14] hv: vmbus: convert ring backing through the chunk allocator Emerson Busson
2026-10-07 19:07 ` [PATCH v2 02/14] hv: vmbus: validate chunk buffer allocation and cleanup Emerson Busson
2026-10-07 19:07 ` Emerson Busson [this message]
2026-10-07 19:07 ` [PATCH v2 04/14] hv: vmbus: add KUnit tests for GPADL post failure injection Emerson Busson
2026-10-07 19:07 ` [PATCH v2 05/14] hv: vmbus: add KUnit test for order-zero allocation fallback Emerson Busson
2026-10-07 19:07 ` [PATCH v2 06/14] hv: vmbus: cover all shared-page policy combinations Emerson Busson
2026-10-07 19:07 ` [PATCH v2 07/14] hv: vmbus: distinguish host rescind from local channel unload Emerson Busson
2026-10-07 19:07 ` [PATCH v2 08/14] hv: vmbus: retain backing until ownership and references clear Emerson Busson
2026-10-07 19:07 ` [PATCH v2 09/14] hv: use owned VMBus buffers in NetVSC and UIO Emerson Busson
2026-10-07 19:07 ` [PATCH v2 10/14] hv: vmbus: pin buffer pages across UIO mmap to close the reclaim race Emerson Busson
2026-10-08 16:49 ` kernel test robot
2026-10-08 17:02 ` kernel test robot
2026-10-07 19:07 ` [PATCH v2 11/14] hv: vmbus: vmalloc requestor metadata Emerson Busson
2026-10-07 19:07 ` [PATCH v2 12/14] hv: netvsc: allocate RNDIS request descriptors with kvzalloc_obj() Emerson Busson
2026-10-07 19:07 ` [PATCH v2 13/14] hv: netvsc: handle a NULL request address on empty completions Emerson Busson
2026-10-07 19:07 ` [PATCH v2 14/14] hv: netvsc: use kvzalloc for device state Emerson Busson
2026-10-08 16:55 ` [PATCH v2 0/14] hv: vmbus: make rings and host-visible buffers survive buddy fragmentation Easwar Hariharan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261007190752.336426-4-emersonbusson@gmail.com \
--to=emersonbusson@gmail.com \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=decui@microsoft.com \
--cc=edumazet@google.com \
--cc=gregkh@linuxfoundation.org \
--cc=haiyangz@microsoft.com \
--cc=kuba@kernel.org \
--cc=kys@microsoft.com \
--cc=linux-hyperv@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mhklinux@outlook.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=wei.liu@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®