From: Bjorn Andersson <bjorn.andersson@oss.qualcomm.com>
To: Sebastian Reichel <sre@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Neil Armstrong <neil.armstrong@linaro.org>
Cc: linux-arm-msm@vger.kernel.org,
Sebastian Reichel <sebastian.reichel@collabora.com>,
linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org,
Bjorn Andersson <bjorn.andersson@oss.qualcomm.com>
Subject: [PATCH] power: supply: qcom_battmgr: report full batteries
Date: Thu, 08 Oct 2026 11:14:57 +0200 [thread overview]
Message-ID: <20261008-battmgr-full-v1-1-4f5485a9c421@oss.qualcomm.com> (raw)
The SC8280XP battery-status response has no explicit full state. When a
battery reaches its full capacity on external power, neither the charging
nor discharging bit is set. The driver consequently reports "Not
charging", which can make userspace show the system as battery powered.
Use the response's power-online bit and the reported capacity to identify
a battery that is full while externally powered. Preserve "Not charging"
for a battery whose charging is inhibited below its full capacity.
Fixes: 29e8142b5623 ("power: supply: Introduce Qualcomm PMIC GLINK power supply")
Assisted-by: LLM
Signed-off-by: Bjorn Andersson <bjorn.andersson@oss.qualcomm.com>
---
drivers/power/supply/qcom_battmgr.c | 16 +++++++++++-----
1 file changed, 11 insertions(+), 5 deletions(-)
diff --git a/drivers/power/supply/qcom_battmgr.c b/drivers/power/supply/qcom_battmgr.c
index 7716eb9e1aff..97cbe966ea84 100644
--- a/drivers/power/supply/qcom_battmgr.c
+++ b/drivers/power/supply/qcom_battmgr.c
@@ -1261,6 +1261,7 @@ static void qcom_battmgr_sc8280xp_callback(struct qcom_battmgr *battmgr,
unsigned int opcode = le32_to_cpu(resp->hdr.opcode);
unsigned int source;
unsigned int state;
+ unsigned int power_state;
size_t payload_len = len - sizeof(struct pmic_glink_hdr);
if (payload_len < sizeof(__le32)) {
@@ -1310,18 +1311,23 @@ static void qcom_battmgr_sc8280xp_callback(struct qcom_battmgr *battmgr,
}
state = le32_to_cpu(resp->status.battery_state);
+ battmgr->status.capacity = le32_to_cpu(resp->status.capacity) * 1000;
+ battmgr->status.power_now = le32_to_cpu(resp->status.rate) * 1000;
+ battmgr->status.voltage_now = le32_to_cpu(resp->status.battery_voltage) * 1000;
+ battmgr->status.temperature = qcom_battmgr_sc8280xp_convert_temp(le32_to_cpu(resp->status.temperature));
+
+ power_state = le32_to_cpu(resp->status.power_state);
if (state & BIT(0))
battmgr->status.status = POWER_SUPPLY_STATUS_DISCHARGING;
else if (state & BIT(1))
battmgr->status.status = POWER_SUPPLY_STATUS_CHARGING;
+ else if ((power_state & BIT(0)) &&
+ battmgr->info.last_full_capacity &&
+ battmgr->status.capacity >= battmgr->info.last_full_capacity)
+ battmgr->status.status = POWER_SUPPLY_STATUS_FULL;
else
battmgr->status.status = POWER_SUPPLY_STATUS_NOT_CHARGING;
- battmgr->status.capacity = le32_to_cpu(resp->status.capacity) * 1000;
- battmgr->status.power_now = le32_to_cpu(resp->status.rate) * 1000;
- battmgr->status.voltage_now = le32_to_cpu(resp->status.battery_voltage) * 1000;
- battmgr->status.temperature = qcom_battmgr_sc8280xp_convert_temp(le32_to_cpu(resp->status.temperature));
-
source = le32_to_cpu(resp->status.charging_source);
battmgr->ac.online = source == BATTMGR_CHARGING_SOURCE_AC;
battmgr->usb.online = source == BATTMGR_CHARGING_SOURCE_USB;
---
base-commit: f0406245cb9855e6318335a8a223551354291a46
change-id: 20261008-battmgr-full-0cc0c1b91bea
Best regards,
--
Bjorn Andersson <bjorn.andersson@oss.qualcomm.com>
next reply other threads:[~2026-10-08 9:15 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-08 9:14 Bjorn Andersson [this message]
2026-10-13 11:21 ` Konrad Dybcio
2026-10-17 23:23 ` Sebastian Reichel
2026-10-17 23:17 ` Sebastian Reichel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261008-battmgr-full-v1-1-4f5485a9c421@oss.qualcomm.com \
--to=bjorn.andersson@oss.qualcomm.com \
--cc=andersson@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=neil.armstrong@linaro.org \
--cc=sebastian.reichel@collabora.com \
--cc=sre@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®