From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from sender5-op-o11.zoho.com (sender5-op-o11.zoho.com [165.173.182.11]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CEFEC37E30C for ; Wed, 7 Oct 2026 23:43:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=pass smtp.client-ip=165.173.182.11 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791416629; cv=pass; b=ofzIDl5wilC00JlVx2Eclr07jeM8OuAGhMp7kOp9G4XsEY7pqPHi+wp2xDfcinEeVIUtJiHALJmTFSRdHQPEQ2NVlwKW6HHEDass6oFdx2gAOo7guNEOMhRpPbNux9001Z/79R9CX2X9iileGmTwXzKn70V8qSsgIjIPfEbvMt4= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791416629; c=relaxed/simple; bh=lnZA3WBfFFBXieQiXa+jWZXXOpFpf8LSvl0zyNsSIDw=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=efWUO5lJv6QLxbeV13+v+ahx9PgBQin9L3+5Bz3X++BQFFkZixN0ULpXaLDE5wghiPl0OyGOvfWjd0i3+S+oV9+gFnBsngr6eVpK+ICkCv7xj3I2rQ+ET8g16KodsVlWGfuCvClgmVRqh4HJwWPBeoatjAgd0RhIZF3A6Grd39U= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com; spf=pass smtp.mailfrom=collabora.com; dkim=pass (1024-bit key) header.d=collabora.com header.i=adrian.larumbe@collabora.com header.b=jKbASDgJ; arc=pass smtp.client-ip=165.173.182.11 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=collabora.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=collabora.com header.i=adrian.larumbe@collabora.com header.b="jKbASDgJ" ARC-Seal: i=1; a=rsa-sha256; t=1791416604; cv=none; d=zohomail.com; s=zohoarc; b=eQsR4aCna3vwM5wtB1AeNwvmdoV7nVdopMDGgCiRhnJXC9kNXuizK8P7vBGWK6fc5qiimV7SCzfBge98b9YcP8LtzfRDGXWUY9lIe85LCyeL+hSRkEvvH+R91Y+c1hbFIVveXMtx4W4CLyKgvoIhxg/CdvcSxlqtUoW6jje41DQ= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1791416604; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:MIME-Version:Message-ID:Subject:Subject:To:To:Message-Id:Reply-To; bh=Cz7nlaO9ug15k4wyc2p1bB4V9NQP7yWcZzYPbXi+vXY=; b=GXnZYWVDgx3rLek5nSc3Nuusdyn2atioqPxFMXMhDENkF6Wmxci+Yw0buRqaplR5FTTT3TK96W2Ic8JuKFRQTmsimZkVDQTAL+i6EELDz0NVBxyFu2+q0BaON5KN7YERnqATqv3OzCBUPDcfAO5kdpeLsztbOX5hCp6hxGN5McU= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=collabora.com; spf=pass smtp.mailfrom=adrian.larumbe@collabora.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1791416604; s=zohomail; d=collabora.com; i=adrian.larumbe@collabora.com; h=From:From:Date:Date:Subject:Subject:MIME-Version:Content-Type:Content-Transfer-Encoding:Message-Id:Message-Id:In-Reply-To:To:To:Cc:Cc:Reply-To; bh=Cz7nlaO9ug15k4wyc2p1bB4V9NQP7yWcZzYPbXi+vXY=; b=jKbASDgJECrUeMtTJILhOIKEG9VMN83bFhoN7yPg5zyVuHxJhC5Blx3JUd9aIo3a JfJFV+KcTvS49f9xen6Uh/2Gld6riiJ2tyJGA1U9icjJYUW3t6I5bF9FAeM1kPmhiwq JsDVcJv/lrE2VJjMzweJ9hMn5gWM8CGA4Nm5V2OY= Received: by smtp.zohomail.com with SMTPS id 1791416603103998.754207716527; Wed, 7 Oct 2026 16:43:23 -0700 (PDT) From: =?utf-8?q?Adri=C3=A1n_Larumbe?= Date: Thu, 08 Oct 2026 00:42:47 +0100 Subject: [PATCH v13 04/15] drm/panfrost: Skip NULL checks for clock enable/disabling Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit Message-Id: <20261008-claude-fixes-v13-4-d6a493185860@collabora.com> References: <20261008-claude-fixes-v13-0-d6a493185860@collabora.com> In-Reply-To: <20261008-claude-fixes-v13-0-d6a493185860@collabora.com> To: Boris Brezillon , Rob Herring , Steven Price , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Faith Ekstrand , "Marty E. Plummer" , Tomeu Vizoso , Eric Anholt , Robin Murphy , Philipp Zabel Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Collabora Kernel Team , =?utf-8?q?Adri=C3=A1n_Larumbe?= , Neil Armstrong X-Mailer: b4 0.15.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=1636; i=adrian.larumbe@collabora.com; h=from:subject:message-id; bh=lnZA3WBfFFBXieQiXa+jWZXXOpFpf8LSvl0zyNsSIDw=; b=owEB7QES/pANAwAKAQ4mfkzuU0M9AcsmYgBqxtj7brPj8iPgSr8H0flxfnuNlFZ1/DExeiZ8y pUK4YCW6JSJAbMEAAEKAB0WIQQyQDDowAUXXfk3B6QOJn5M7lNDPQUCasbY+wAKCRAOJn5M7lND Pc9jDACbAF0BBsY/GSKwJnazLbjEPd67QR6Z5muzGGzL49+V0QDJ7u7wlxvjKmwoiHezxQmlOmF KEUS9rhDw5+xYyMBOY7Y7j2CTw2dtEkERSmIaplrDDn8HR1DWg4kc1Qp5uYwSoO6mAPEeWU4+ux fPdx828q/ouIj9T2TTrhs4SuDKUCZN8QZ9gVbxMbuElXj0OPu0MMeZoSvmgkSFNq26t1bgOgPvL Wc6ssPxe4M8yXLnehfC9CRcxznZH5zgLltr6utxZGNjNTYLgQJiYSC5yjlfjRpZX+UC60Y1rH/n LJuEbuv8LR4SQlfy5dK4MYTvClcDhajPkUq32cgjBEg2PVcwOml/HTEA9U2qyRh1wMpuhp1VKcW qGq3ZpCj8vK814FShyRaUTiVy3cN9gMdb82QHZuOcPvPQaoGguRLdM9+AemQEdR6TIPIxcpqjgt RvuiQ5umXA4GNRlgJJ4Ph79UFnFMNaphM2REvucBMtlCgwbSrtj5v74AhpyiHSGMoF29k= X-Developer-Key: i=adrian.larumbe@collabora.com; a=openpgp; fpr=324030E8C005175DF93707A40E267E4CEE53433D The clk_* API can deal with NULL clock objects, so we can do away with NULL checks in client code. Reviewed-by: Boris Brezillon Reviewed-by: Steven Price Signed-off-by: Adrián Larumbe --- drivers/gpu/drm/panfrost/panfrost_device.c | 14 +++++--------- 1 file changed, 5 insertions(+), 9 deletions(-) diff --git a/drivers/gpu/drm/panfrost/panfrost_device.c b/drivers/gpu/drm/panfrost/panfrost_device.c index 5bf528f41278..b3a53504bd01 100644 --- a/drivers/gpu/drm/panfrost/panfrost_device.c +++ b/drivers/gpu/drm/panfrost/panfrost_device.c @@ -510,11 +510,9 @@ static int panfrost_device_resume(struct device *dev) if (ret) goto err_clk; - if (pfdev->bus_clock) { - ret = clk_enable(pfdev->bus_clock); - if (ret) - goto err_bus_clk; - } + ret = clk_enable(pfdev->bus_clock); + if (ret) + goto err_bus_clk; } ret = pm_runtime_force_resume(dev); @@ -524,7 +522,7 @@ static int panfrost_device_resume(struct device *dev) return 0; err_resume: - if (pfdev->comp->pm_features & BIT(GPU_PM_CLK_DIS) && pfdev->bus_clock) + if (pfdev->comp->pm_features & BIT(GPU_PM_CLK_DIS)) clk_disable(pfdev->bus_clock); err_bus_clk: if (pfdev->comp->pm_features & BIT(GPU_PM_CLK_DIS)) @@ -545,9 +543,7 @@ static int panfrost_device_suspend(struct device *dev) return ret; if (pfdev->comp->pm_features & BIT(GPU_PM_CLK_DIS)) { - if (pfdev->bus_clock) - clk_disable(pfdev->bus_clock); - + clk_disable(pfdev->bus_clock); clk_disable(pfdev->clock); } -- 2.55.0