From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from sender6-op-o11.zoho.com (sender6-op-o11.zoho.com [165.173.180.11]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8731A39021A for ; Wed, 7 Oct 2026 23:44:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=pass smtp.client-ip=165.173.180.11 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791416656; cv=pass; b=Q+353YAhSSKHW0Hmr/dSfg7hw67MC2N9NtBYG3fsnXMY7bAJxwZ99TjCpcLp0Lx9JGe4AiR4Wau5bCk7mGqxQp8C/BK+s3bxVvF9jTVWn+oxHv0CT54EPol5B4BVO96kImo26qkK+WreFIshAFFFp+lEOOgt5zi/kCKmM1LTQoc= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791416656; c=relaxed/simple; bh=C+aZNX7+BnRco3oE1Uwz3UD02CNIOs99szgIunWDsWQ=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=lzugKC9wSrzX8Jg4dhuOYhNBsyyz/Y8SGxLDXbiLssG67PfZSFp2uIRIVn6WLxyC+4dS9Xukkx8D7NlH6IqwQVn82XatRYotgKPGKzMvAMzkWwPsIW9gKc+Znc+6VwQzAY0AVOHarfOO99JGXzUs5XOaFGgxQqpTu3zkMxUD01U= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com; spf=pass smtp.mailfrom=collabora.com; dkim=pass (1024-bit key) header.d=collabora.com header.i=adrian.larumbe@collabora.com header.b=E0wTNBum; arc=pass smtp.client-ip=165.173.180.11 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=collabora.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=collabora.com header.i=adrian.larumbe@collabora.com header.b="E0wTNBum" ARC-Seal: i=1; a=rsa-sha256; t=1791416634; cv=none; d=zohomail.com; s=zohoarc; b=Rrf43TwJk9tzlfg+OSJdzptjRVMlqPT+8YMMKUDriv7WyNWHSxZEOpg0dB/m+Qk2/KPZK6guKPM8Sj7jZmuCmtoCt9bPvmjzNcUk1wYH2Gul9tyGs1YjCda85jYMQVeYz7AfHMaynILgkk32vph1TXcYCpkD3pjo+l1dqMmgZMo= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1791416634; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:MIME-Version:Message-ID:Subject:Subject:To:To:Message-Id:Reply-To; bh=1ZKPGzGFIKzRpgJ8bQvtWgmP876BGVh5STCt3ZGycg8=; b=fFylI5RFAxxIrYiktNKoFVE9PfyNPWGt7BmKduQVmTCtxlRcO6XznVhhHBmjWaJ1jUmaeRhX62wQrvkT7Q4ig6Dh/OfbRgAh9U5u0lhpS/90y+K34d2xqN1odq0gotB0USJ4nrDERyRAEOlKtJ3G7/B6+nwfvDh1Qc/Ih31mHIY= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=collabora.com; spf=pass smtp.mailfrom=adrian.larumbe@collabora.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1791416634; s=zohomail; d=collabora.com; i=adrian.larumbe@collabora.com; h=From:From:Date:Date:Subject:Subject:MIME-Version:Content-Type:Content-Transfer-Encoding:Message-Id:Message-Id:In-Reply-To:To:To:Cc:Cc:Reply-To; bh=1ZKPGzGFIKzRpgJ8bQvtWgmP876BGVh5STCt3ZGycg8=; b=E0wTNBumhjswqJorI8bMxAOUkjYlN2wnd81vTNTEWiXCuIYAkD57YxHC8gjG3n00 1qqbrPVgRqkx139u2lu234r8jDxtOcmqlp2Wyf3FxeBUZwY9QmeF4sRrmrMNH++lxgA dAHCeoxj3VIsepjwfcCTHvTLZWFoqTOC56QMzsvI= Received: by smtp.zohomail.com with SMTPS id 1791416632545991.1149379443405; Wed, 7 Oct 2026 16:43:52 -0700 (PDT) From: =?utf-8?q?Adri=C3=A1n_Larumbe?= Date: Thu, 08 Oct 2026 00:42:52 +0100 Subject: [PATCH v13 09/15] drm/panfrost: Warn of RPM get failure at device remove time Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit Message-Id: <20261008-claude-fixes-v13-9-d6a493185860@collabora.com> References: <20261008-claude-fixes-v13-0-d6a493185860@collabora.com> In-Reply-To: <20261008-claude-fixes-v13-0-d6a493185860@collabora.com> To: Boris Brezillon , Rob Herring , Steven Price , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Faith Ekstrand , "Marty E. Plummer" , Tomeu Vizoso , Eric Anholt , Robin Murphy , Philipp Zabel Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Collabora Kernel Team , =?utf-8?q?Adri=C3=A1n_Larumbe?= , Neil Armstrong X-Mailer: b4 0.15.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=1207; i=adrian.larumbe@collabora.com; h=from:subject:message-id; bh=C+aZNX7+BnRco3oE1Uwz3UD02CNIOs99szgIunWDsWQ=; b=owEB7QES/pANAwAKAQ4mfkzuU0M9AcsmYgBqxtj71OoGF8OuakUpeQxIzW2OMuPM6Z/7Uwuzs Z0iJgb1+8OJAbMEAAEKAB0WIQQyQDDowAUXXfk3B6QOJn5M7lNDPQUCasbY+wAKCRAOJn5M7lND PYXKC/9ecOYnmjNBVcWv9KgDkMaBAXbIOQ3C4ebR+jDWEjATgJLNTqHMEWyXkVq4YdxHx0AoDJE 2eufoacWtTi14lAuSqLTYIY/AFeMcrPWo4coj9XhuGn8MuVLQ02l2Sbi2/rj2AjXqYmhHPgIBMQ Gak16qCnIDbof2t0HMDoTalv+W4Ezh+b6VdZ5nkiuL9q1Mbvnv56JP7p6XRTOFOIiLMmbif6Ob4 WM+KYj/jBvKr8jf6uJ/ZVGHj8RJVE9bibigl+OgVDr2lx3k+7Y6RueGdTYCsBsbiO1bYtBG8aOq Vlon20h+PfpNOdjUZdDF0KvF01gmszxAx/8BR4w9EcF9WiHvDJcQhtuoG2zmsQnkJpiVUpzyBdD mGa/Km2EfF2GB4kGJt62C14sttTE4DkUsLmSL8hnXZ+kl6I+HgUZRgWcjmdCQ+W0MkIwRcsqAgJ KzOqi3xg6gDtCNFGgQRaCb4W+CxFjXgKvqmQ0UwBylwuLkaQ37Fx/fXLKE0inl8yj8rMk= X-Developer-Key: i=adrian.larumbe@collabora.com; a=openpgp; fpr=324030E8C005175DF93707A40E267E4CEE53433D Rather than just failing silently, let's warn the user of device removal not being able to take a PM reference, because it should be seen as fatal. Reviewed-by: Boris Brezillon Signed-off-by: Adrián Larumbe --- drivers/gpu/drm/panfrost/panfrost_device.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/panfrost/panfrost_device.c b/drivers/gpu/drm/panfrost/panfrost_device.c index a6deabb39fd2..687230225743 100644 --- a/drivers/gpu/drm/panfrost/panfrost_device.c +++ b/drivers/gpu/drm/panfrost/panfrost_device.c @@ -9,6 +9,7 @@ #include #include #include +#include #include "panfrost_device.h" #include "panfrost_devfreq.h" @@ -385,7 +386,7 @@ int panfrost_device_init(struct panfrost_device *pfdev) void panfrost_device_fini(struct panfrost_device *pfdev) { - pm_runtime_get_sync(pfdev->base.dev); + drm_WARN_ON(&pfdev->base, pm_runtime_get_sync(pfdev->base.dev) < 0); pm_runtime_dont_use_autosuspend(pfdev->base.dev); pm_runtime_disable(pfdev->base.dev); -- 2.55.0