From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5369630F927 for ; Thu, 8 Oct 2026 13:15:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791465313; cv=none; b=VrL4+vHVlcImLDm64Hnq36Ru9NP+WrhhqVlfjKbX/hW1xMF82AD2EoOW8MHZVUcQbNbjyC9hk18A3Ufqvzhm1r8X7NNb0L61hbE1mHe3tAILHCF2Sq77mKYh0zP0N1uEcPY3ofd5ncmWYk9Ye7yDy1GyAuFslwdftVVa8EtO5lU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791465313; c=relaxed/simple; bh=NDuP83zqW5zQSG3EkE86iDSunaWPu3MRqhYZ+iIkb74=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=bVsTjbFPGvlpumkk8FPwczpWFEQ8uRLxwyWKyMujJOJzntlr7gLnTnChjgRPoeTzmq0TRWA5uayhF42/lrJS4ZSca3rPv0ZGcLRcm/LdS67hYQ82f3YRpYkGQZYnli89iMdUtl6X3A57MvZgOu33DOgNNkDKVO3SoU1SB+ZRdVU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=VR/3bMV1; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=dcHRKjH8; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="VR/3bMV1"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="dcHRKjH8" Received: from pps.filterd (m0279872.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 698BKNAf1708598 for ; Thu, 8 Oct 2026 13:15:02 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= LmFgXz9bCUDEoCCFm4UoAId5Yo4tRXQx+o7RqBDpoyY=; b=VR/3bMV1ZVGwB4XI qnkVWK8/HT35hJVvXHej32VrFYVXtaI9Q79GPRLDJ3X4HQkXlbh2V6nhissOen1k 91WCtt7UYLeBPHSQ6iPhxy2qsK8Hbbuxhm47oRSDHpP2+k9h+lA7xDXURbxPoxWX A9vePFBLAfBXzBFSINDvmTMxBFLZc93yEkkN2BO2rkV75fw88xC1ved8GDfZQIQc 6O3GUt0OY3p7m7j6+HdEpswlOKViDCa/PIL/X1PSaljnNkdA0qKfaEsV7oZiPJfp 5hjufMqDz884H2kut4gUz5NAlCAISoeg7hJSIBBlmS63BK+tj134nXLREypjRyIH gVqPvw== Received: from mail-ua1-f70.google.com (mail-ua1-f70.google.com [209.85.222.70]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4h5xe3b016-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 08 Oct 2026 13:15:02 +0000 (GMT) Received: by mail-ua1-f70.google.com with SMTP id a1e0cc1a2514c-98c88cefeb3so480664241.3 for ; Thu, 08 Oct 2026 06:15:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1791465301; x=1792070101; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=LmFgXz9bCUDEoCCFm4UoAId5Yo4tRXQx+o7RqBDpoyY=; b=dcHRKjH8DdWAaFNHTzqTXANycPqsS6fov/OqKOeyZZCZpW2QP+XqpO8WR5S+ePM040 BG1Bo/z31X0KP1TLZqsw36Ja6L3TKGYOgK45ICMrV3xaDAtV3dD/3/UpOWoGxc5/zRcM YmvytDnZ00xAQQ5cPsEdNTa3mUiUSr8+SMcCloJHh41OzZvEqpAq8v88iFFFUvmYRbpj 0MMbvTfvh9tAcP+JvtjubO7t6cl2RL58W9DOVijY8WCiBRm7clpHEIaAVMiSl+BFaqtM bZevoV6tms4WR4jwvu6SwTahXo3NCHLvIG8ZnXbJ3yTJiLkb2rPVXZjhZ2llm2ra8zUi Fv7Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1791465301; x=1792070101; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=LmFgXz9bCUDEoCCFm4UoAId5Yo4tRXQx+o7RqBDpoyY=; b=uWK1lR2ai80RDDc0TW6Ddd8mQlJC6l6vC8CS7sOP+AvirsY9QbA0gqGsyz37ltqpzy WeP3VMg9XzAgCV5cejhDXxy2h3f5z8G9oQ3GjFjljew2j7AWC6NH1Y5Mndmji3kFEqzV WbWBwjRYIyFVck4aL07NWS9Q4nFjyi/xpinhzWuiZGGi5XJBNjkoAdvTORy337/bwHbv BPFapjnGuJCcWMKdtxLLFwSSqhhUoo/A+VhZjmCJyWtzJf455wtfR8eIOixNBo5r5r+l uh77ylrrg8nqQ4+b/H2je6W2a8LWCwUD/0mZjhbOVh8Z9uX/GDNLRzH5Lz8K905aDTv4 BlDQ== X-Forwarded-Encrypted: i=1; AKwUvBz35tfnxLX5IXegrp48wlaioEk7YHy/XAkrWl5PJ3o59MfX4bp/tdjXshLGzuAZ9TxkPXq6yTUIkBbvVpk=@vger.kernel.org X-Gm-Message-State: AFq9FYIuXC6htk5QW5UIKKvkZ/IDRlRukHb5Ka5jdCAP14SzJPCv8R2k hiUYX/WcJZx7SGmKmmiuHHjy0KnFl/NMXaggFPMwSQDxgEd2IYXvOKDe5IPie9tGFN+t4zc8dLQ shMCaEnQLOsmQWw8FNv8OUQikcDhJQAa1Y3nQtyXlPQ0RSjAII2aPDnf5qTp13HrAPvc= X-Gm-Gg: AYBFou1OMNNRXN+btT00IIyGkslGMpHftgy9/iujMg4iW6hRYmemOZP/9DX4+em+uTX +X3Knk/nOK7jeuahcBbvnU6Ax2TdnR2HiKTbKg+rD0XLX+NovIn6C/v2wsri2JXeibjbUhT8wHL RqybA+D65CV2jovYPXRUvtJl+K4kbguSy6dIsHfsa8d7iqKJnzln16IGjidZeQF4BNEqPU3XpQf p3KQK2uQpX+j7sYu3/rAlouZcTpTKj/lNzQRk2YM54a4bLMo3TDwDqVrqP3YwIzRhfj53cYd1+r st2jjN71SdBNNeY8HGhmsvVWv6RHqmgTNZehKsGqSa6MM/EswIJOoKsc7iXnzT2OE6zqW4lrsJb IPB2m5KnZ1PDOfY+sqcvRN+gsupMWwZheEpVyhTvWC49Mgk4+wcXSFJxc/qR4wqp0szo+G2/kPn L9ZGtnYb8da71E X-Received: by 2002:a05:6102:5114:b0:7c3:b15:a981 with SMTP id ada2fe7eead31-7ca38b56930mr1895328137.15.1791465301416; Thu, 08 Oct 2026 06:15:01 -0700 (PDT) X-Received: by 2002:a05:6102:5114:b0:7c3:b15:a981 with SMTP id ada2fe7eead31-7ca38b56930mr1895298137.15.1791465300727; Thu, 08 Oct 2026 06:15:00 -0700 (PDT) Received: from umbar.lan (2001-14ba-a073-af00-264b-feff-fe8b-be8a.rev.dnainternet.fi. [2001:14ba:a073:af00:264b:feff:fe8b:be8a]) by smtp.gmail.com with ESMTPSA id 38308e7fff4ca-3a9ae563df4sm8691441fa.30.2026.10.08.06.14.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 08 Oct 2026 06:14:58 -0700 (PDT) From: Dmitry Baryshkov Date: Thu, 08 Oct 2026 16:14:27 +0300 Subject: [PATCH RFC 5/9] drm/panel: add atomic_check callback Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20261008-panel-atomic-state-v1-5-b157fddb8de1@oss.qualcomm.com> References: <20261008-panel-atomic-state-v1-0-b157fddb8de1@oss.qualcomm.com> In-Reply-To: <20261008-panel-atomic-state-v1-0-b157fddb8de1@oss.qualcomm.com> To: Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Luca Ceresoli , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Jonathan Corbet , Shuah Khan , Randy Dunlap , Jessica Zhang , Konrad Dybcio , Val Packett Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org X-Mailer: b4 0.15.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=7281; i=dmitry.baryshkov@oss.qualcomm.com; h=from:subject:message-id; bh=NDuP83zqW5zQSG3EkE86iDSunaWPu3MRqhYZ+iIkb74=; b=owEBbQGS/pANAwAKAYs8ij4CKSjVAcsmYgBqx5dGknLGXeDIwrZ4oAApBaKXVGnq71wwJiGAH Ln84UGnPSCJATMEAAEKAB0WIQRMcISVXLJjVvC4lX+LPIo+Aiko1QUCaseXRgAKCRCLPIo+Aiko 1QZpCACwimdVnYYcDuqpMTmrHjg/Kzh69uM9YoV5/nrBhvGbqlZ+VBwRtqQwI79Bqx6fkETYqjX hgKvH3xEqQn/9RqdUeT6myXnYGKdKDC9f66D5xFwebw5WnSmAXv9eGXVFlXvC1+hC8F2cP0b1pS IkWAREbSs93PI+7rHrOrEd0WpuKPBVan6Dxu/onnnmn30EQDwerPNkpM6i/d36DxGoJUQ2Y5zs/ Dz3bzL85Nf0uXh5wd1HkjCL+L3XxUfXGAIpcAoeRU0r9xLs0iixRYd00JLikXKU5F3vIn7c3eh4 tKxzZDs0Skeq7pZPawg5A2wW9xcjQpu+BGfkQLl0KY8qk/PI X-Developer-Key: i=dmitry.baryshkov@oss.qualcomm.com; a=openpgp; fpr=8F88381DD5C873E4AE487DA5199BF1243632046A X-Proofpoint-GUID: KC64roHOZpxF4_m8LRpNxJHRSRtTjYGc X-Authority-Analysis: v=2.4 cv=QOz91QLL c=1 sm=1 tr=0 ts=6ac79756 cx=c_pps a=R6oCqFB+Yf/t2GF8e0/dFg==:117 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=660iZSQnnn4A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yx91gb_oNiZeI1HMLzn7:22 a=EUspDBNiAAAA:8 a=3mQ-IjTWdeCcQhJgvQ0A:9 a=QEXdDO2ut3YA:10 a=TD8TdBvy0hsOASGTdmB-:22 X-Proofpoint-Spam-Info: AW1haW4tMjYxMDA4MDA1MiBTYWx0ZWRfX82N41chBpC8c VDGH1vaS0c3J+FbJ8m4wEbkRpYZwshyAyujWI3rg0pwzv9/SNbE7Nr45YjhnFRK+/i1fyy4qef6 cB2UfjmJYZoJpPp9fS+iWNef3xPdqvU= X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYxMDA4MDA1MiBTYWx0ZWRfXxC7AEQzWf1E0 Tdh3zX3KoXap5NsXvG8/wSGeCfARUkPXgYMiiDygop6OMjl3QGW2oP8kli2f95g3O/hQGGbv9Gl 7TfML0UbEiy1JYqk5iaaw+U1fFk4WUScdOGdh13PQuvttky8fV0h983Yw+Afi2De0/CA3FWIquD 62C4qnZjAkc2jGOe8rxqptyqLbe8zB9Gk/iCWUL/LtXdKpgQnq6TktLXg2KAhZ4kWBb5xOALkSs 2qqsfmNH5ewamN9Sm9Mbl4FnM3pYo081m7HHvEykMHphAh+GnLmTutu7dXFmEBUA//doPniiTWm JWBInvo51I8DQt9Qn6HtrZ8vAPTd+OmNMl0bvnI4ibP+1DwTox9Gm6UUDExIrTWftee3nVPwzwM mnh2HYKjt10wnPKtfnZRkbuG3Bo5VlRCTe2uyyJZPnbyaUHmZcH5FuxPBaBGDWP5TEmwSJll4jg SyDcBhKSDTCkkf4q15A== X-Proofpoint-ORIG-GUID: KC64roHOZpxF4_m8LRpNxJHRSRtTjYGc X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-10-08_04,2026-10-08_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 priorityscore=1501 lowpriorityscore=0 spamscore=0 phishscore=0 impostorscore=0 adultscore=0 bulkscore=0 suspectscore=0 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2610020000 definitions=main-2610080052 A panel driver cannot reject a configuration it does not support, nor compute its state for the configuration that is being requested: none of its callbacks is called in the check phase of an atomic update. Add an optional atomic_check callback, called from the atomic_check of the bridge embedded in the panel. Following the other atomic_check callbacks it receives the whole commit rather than individual object states. Add helpers returning the new CRTC and connector states for a panel, so that panel drivers don't have to open-code the walk through the encoder. The callback is only meant for the panels using atomic state, warn about the panels implementing it without the state callbacks. Assisted-by: LLM Signed-off-by: Dmitry Baryshkov --- drivers/gpu/drm/drm_panel.c | 84 +++++++++++++++++++++++++++++++++++++++++++++ include/drm/drm_panel.h | 30 ++++++++++++++++ 2 files changed, 114 insertions(+) diff --git a/drivers/gpu/drm/drm_panel.c b/drivers/gpu/drm/drm_panel.c index 481caa294243..3a154be128a0 100644 --- a/drivers/gpu/drm/drm_panel.c +++ b/drivers/gpu/drm/drm_panel.c @@ -243,6 +243,19 @@ static void panel_bridge_debugfs_init(struct drm_bridge *bridge, panel->funcs->debugfs_init(panel, root); } +static int panel_bridge_atomic_check(struct drm_bridge *bridge, + struct drm_bridge_state *bridge_state, + struct drm_crtc_state *crtc_state, + struct drm_connector_state *conn_state) +{ + struct drm_panel *panel = drm_bridge_to_panel(bridge); + + if (!panel->funcs->atomic_check) + return 0; + + return panel->funcs->atomic_check(panel, crtc_state->state); +} + static struct drm_bridge_state * panel_bridge_atomic_create_state(struct drm_bridge *bridge) { @@ -297,6 +310,7 @@ static const struct drm_bridge_funcs panel_bridge_bridge_funcs = { .atomic_disable = panel_bridge_atomic_disable, .atomic_post_disable = panel_bridge_atomic_post_disable, .get_modes = panel_bridge_get_modes, + .atomic_check = panel_bridge_atomic_check, .atomic_create_state = panel_bridge_atomic_create_state, .atomic_duplicate_state = panel_bridge_atomic_duplicate_state, .atomic_destroy_state = panel_bridge_atomic_destroy_state, @@ -654,6 +668,9 @@ static void drm_panel_init(struct drm_panel *panel, struct device *dev, !funcs->atomic_create_state != !funcs->atomic_destroy_state, "Panel state callbacks have to be implemented together\n"); + dev_WARN_ONCE(dev, !funcs->atomic_create_state && funcs->atomic_check, + "Atomic callbacks require the panel state callbacks\n"); + INIT_LIST_HEAD(&panel->list); INIT_LIST_HEAD(&panel->followers); mutex_init(&panel->follower_lock); @@ -1185,6 +1202,73 @@ struct drm_panel_state *drm_panel_get_current_state(struct drm_panel *panel) } EXPORT_SYMBOL(drm_panel_get_current_state); +/** + * drm_atomic_get_new_crtc_state_for_panel() - get new CRTC state for a panel + * @commit: global atomic state object + * @panel: panel to get the CRTC state for + * + * This function returns the new state of the CRTC that drives @panel as of + * @commit. It is meant to be used from &drm_panel_funcs.atomic_check and the + * enable path. In the disable path the panel might not be driven by any CRTC + * anymore. + * + * Return: + * + * The new CRTC state, or NULL if the panel is not driven by a CRTC that is + * part of the global atomic state. + */ +struct drm_crtc_state * +drm_atomic_get_new_crtc_state_for_panel(struct drm_atomic_commit *commit, + struct drm_panel *panel) +{ + struct drm_encoder *encoder = panel->bridge.encoder; + struct drm_crtc *crtc; + + if (!encoder) + return NULL; + + crtc = drm_atomic_get_new_crtc_for_encoder(commit, encoder); + if (!crtc) + return NULL; + + return drm_atomic_get_new_crtc_state(commit, crtc); +} +EXPORT_SYMBOL(drm_atomic_get_new_crtc_state_for_panel); + +/** + * drm_atomic_get_new_connector_state_for_panel() - get new connector state for + * a panel + * @commit: global atomic state object + * @panel: panel to get the connector state for + * + * This function returns the new state of the connector that @panel is routed + * to as of @commit. It is meant to be used from &drm_panel_funcs.atomic_check + * and the enable path. In the disable path the panel might not be routed to + * any connector anymore. + * + * Return: + * + * The new connector state, or NULL if the panel is not routed to a connector + * that is part of the global atomic state. + */ +struct drm_connector_state * +drm_atomic_get_new_connector_state_for_panel(const struct drm_atomic_commit *commit, + struct drm_panel *panel) +{ + struct drm_encoder *encoder = panel->bridge.encoder; + struct drm_connector *connector; + + if (!encoder) + return NULL; + + connector = drm_atomic_get_new_connector_for_encoder(commit, encoder); + if (!connector) + return NULL; + + return drm_atomic_get_new_connector_state(commit, connector); +} +EXPORT_SYMBOL(drm_atomic_get_new_connector_state_for_panel); + /** * drm_panel_get - Acquire a panel reference * @panel: DRM panel diff --git a/include/drm/drm_panel.h b/include/drm/drm_panel.h index ff63bed934fa..a5879b7b986b 100644 --- a/include/drm/drm_panel.h +++ b/include/drm/drm_panel.h @@ -38,6 +38,8 @@ struct device_node; struct drm_atomic_commit; struct drm_bridge; struct drm_connector; +struct drm_connector_state; +struct drm_crtc_state; struct drm_device; struct drm_panel_follower; struct drm_panel; @@ -168,6 +170,28 @@ struct drm_panel_funcs { */ void (*debugfs_init)(struct drm_panel *panel, struct dentry *root); + /** + * @atomic_check: + * + * Check that the configuration requested in @commit can be handled by + * the panel and compute the new panel state. The new panel state can + * be retrieved with drm_atomic_get_new_panel_state(), the CRTC and + * connector states with drm_atomic_get_new_crtc_state_for_panel() and + * drm_atomic_get_new_connector_state_for_panel(). + * + * This function is called in the check phase of an atomic update, it + * must not touch the hardware or any persistent driver data. + * + * This function is optional. It can only be implemented together with + * @atomic_create_state. + * + * Return: + * + * Zero if the check passed, a negative error code otherwise. + */ + int (*atomic_check)(struct drm_panel *panel, + struct drm_atomic_commit *commit); + /** * @atomic_create_state: * @@ -438,6 +462,12 @@ drm_atomic_get_old_panel_state(const struct drm_atomic_commit *commit, struct drm_panel_state * drm_atomic_get_new_panel_state(const struct drm_atomic_commit *commit, struct drm_panel *panel); +struct drm_crtc_state * +drm_atomic_get_new_crtc_state_for_panel(struct drm_atomic_commit *commit, + struct drm_panel *panel); +struct drm_connector_state * +drm_atomic_get_new_connector_state_for_panel(const struct drm_atomic_commit *commit, + struct drm_panel *panel); #if defined(CONFIG_OF) && IS_ENABLED(CONFIG_DRM_PANEL) struct drm_panel *of_drm_find_panel(const struct device_node *np); -- 2.47.3