From: Daejun Park <daejun7.park@samsung.com>
To: "Darrick J. Wong" <djwong@kernel.org>
Cc: Chuck Lever <cel@kernel.org>, Jeff Layton <jlayton@kernel.org>,
NeilBrown <neil@brown.name>,
Olga Kornievskaia <okorniev@redhat.com>,
Dai Ngo <Dai.Ngo@oracle.com>, Tom Talpey <tom@talpey.com>,
Christoph Hellwig <hch@lst.de>,
Sergey Bashirov <sergeybashirov@gmail.com>,
Carlos Maiolino <cem@kernel.org>,
Amir Goldstein <amir73il@gmail.com>,
"linux-nfs@vger.kernel.org" <linux-nfs@vger.kernel.org>,
"linux-xfs@vger.kernel.org" <linux-xfs@vger.kernel.org>,
"linux-fsdevel@vger.kernel.org" <linux-fsdevel@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Daejun Park <daejun7.park@samsung.com>
Subject: RE:(2) [PATCH] nfsd: do not return overlapping extents in a block layout
Date: Thu, 08 Oct 2026 10:47:06 +0900 [thread overview]
Message-ID: <20261008014706epcms2p7f60dc9a1db6ca16a6fff03de67688c2e@epcms2p7> (raw)
In-Reply-To: <20261007165101.GD2705364@frogsfrogsfrogs>
On Wed, Oct 07, 2026 at 09:51:01AM -0700, Darrick J. Wong wrote:
> Nitpicking here, but the extent could extend beyond than the requested
> @offset/@length range too, right? Shouldn't the comment say that, since
> the header comment allows for both cases, right?
Yes, it can end past offset + length. Chuck had already applied the
patch to nfsd-testing (214e388464bf) when your reply came, so the
comment there still says "may be shorter than the requested length".
The ->map_blocks series that Christoph asked for removes that comment:
https://lore.kernel.org/r/20261008-xfs-nfsd-map-blocks-v1-0-560026cdccb6@samsung.com
nfsd4_block_map_extent() becomes nfsd4_block_iomap_to_extent(), which
only converts a mapping, and the ->map_blocks comment says that the
last mapping may end before or after @offset + @len.
If Chuck would rather fix it in nfsd-testing in the meantime, the
comment would read:
/*
* Get an extent from the file system that contains offset. It may start
* below offset and may end before or after offset + length.
*/
next prev parent reply other threads:[~2026-10-08 1:47 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-07 2:03 Daejun Park via B4 Relay
2026-10-07 13:11 ` Christoph Hellwig
2026-10-07 14:58 ` Chuck Lever
2026-10-07 16:51 ` Darrick J. Wong
[not found] ` <CGME20261007131141epcas2p46e1bc1592a0789298bc9f7e13c7ad393@epcms2p8>
2026-10-08 1:43 ` Daejun Park
[not found] ` <CGME20261007165105epcas2p264fc1fd07bab1fb877a6695062f48322@epcms2p7>
2026-10-08 1:47 ` Daejun Park [this message]
2026-10-08 14:14 ` (2) " Chuck Lever
2026-10-12 2:52 ` Daejun Park
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261008014706epcms2p7f60dc9a1db6ca16a6fff03de67688c2e@epcms2p7 \
--to=daejun7.park@samsung.com \
--cc=Dai.Ngo@oracle.com \
--cc=amir73il@gmail.com \
--cc=cel@kernel.org \
--cc=cem@kernel.org \
--cc=djwong@kernel.org \
--cc=hch@lst.de \
--cc=jlayton@kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nfs@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=neil@brown.name \
--cc=okorniev@redhat.com \
--cc=sergeybashirov@gmail.com \
--cc=tom@talpey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®