From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f173.google.com (mail-pl1-f173.google.com [209.85.214.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 78B2C3A48C2 for ; Thu, 8 Oct 2026 02:28:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.173 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791426526; cv=none; b=l7R+IvQ7EXouHlYKP3soi7hEES3Gls1bMSMO/j1riVi53pVMwK+Kc1RixGZtEzJheZSjMj/3x96W6968Sx+rByco6x+JhcBBVABQ453pHtqZEIN9cyw/LC/TTT2/MFtVzTBUBDB1UmdaJMkJbmcTsl1NUnYr6oN0tbWmtGRllzI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791426526; c=relaxed/simple; bh=+qqYMONCE9zfOaSUDVMRLMJoba1FPx7keJ8McEB6vg8=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=jOtruEd3Mcjl0QdTFsMui+pXCFzD5fcPBVt7WuwxcIFgZSU6o1l3beCRRZMM5q4MymBercWBIi4uQevCSp++UXx+TxhHNev9T+GZy8nnTQcpKuDTnJ4CwUec16OilaiEP7nya+YAazvp0/yRVRE7qcIiJgzr20VwbJ0XY8QVo7Y= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=bf4LQfwi; arc=none smtp.client-ip=209.85.214.173 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="bf4LQfwi" Received: by mail-pl1-f173.google.com with SMTP id d9443c01a7336-2e5d0ee1951so14421475ad.0 for ; Wed, 07 Oct 2026 19:28:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1791426525; x=1792031325; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=fG18jr14L6KnLKy695S6jSOcJe/N8x7hOQ//xht6kkk=; b=bf4LQfwidkS1+pTLIX5gKW+zRTPfvbcyL3bj5gZhxOQkqRF0/NFTWN15xf2SqT4m3G ZHzjM1p9nbbV0gXk2E05dQyVsDHoJFZJy+JDMCs+FsZjD6o8k1PRV5w2IcmAtRBHd8jy K26ll00fDUFS0bQwKSegVcZKlZrTSZTNIi0wiyWHfkkXYti27S5Mo0yLqEywDupfI/qw RWdeB22NIUmZBlJTgLkebavJASu1Dz1nLSQP2cIONBG9Y77VoTGgmKRdpxPXkJnIjYSF Fgf26y8xYdBF8XF6cuc0d92LrlJrGk3HFGcptSXYfqe/K+jP4/g1O+/v+SJWpDDXBtw1 Wu1A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1791426525; x=1792031325; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=fG18jr14L6KnLKy695S6jSOcJe/N8x7hOQ//xht6kkk=; b=I/AXlpntKMn2/WKiqSHrq6RsE6sbd/nBpKePMGxzAJU/ZSY610TTQlE+iBWHEWPM0M Tk3YcF3yNuv6ZovCvEPLUGREXYDM4II3m9pBSPcXpAeF60Jw5PlWDjdFPf0y5/hYNVj5 sLMhO7Yym36IepNli59nX+e0ev1aXdxjYr6r1BWX484K8z+9N9AVUg6uDcvBHqJNqkVc 4j8YVWrB+6A24OcUmgMT3hOS40B9HfuIJSk8GaTI4sJX+F3uNLRB6W5Aq4il2SzffMGP ZwUykGHxYPov+FEoYRbvOgYiwBhI6Ru1n3KuaVKSWDZm55hmgHROwuKFiz3aaN+Ikt84 T/Dg== X-Forwarded-Encrypted: i=1; AKwUvBx+7yxyqgZI8+dIrvzAaY7Q2osgsjES1/76RTPH1kioMHvR7JyFnnESu1DITozCHdby/+XRK7wKCFsKJks=@vger.kernel.org X-Gm-Message-State: AFq9FYJyg8uSlzutGU1ByToB/K7Xv9V6kRWJooh7YwxMMCMpe1Uk6iFP 8m735oED3FkwYZoePydkpwdc9rwbN1HBHAkJ1IckBlMBd/NU65oYuJsd X-Gm-Gg: AYBFou3oyn6Gx6S0JRq3kuhXwNQLllNmxvWgUNAq+apMMsUu/fpS2Jwd7fzNQ0zzKNy WhqgTEQDmrHAnLGweMbgZ1t7skI3S0e2IjCYq1PqpSPytsf4aNfCWXtnVs+n+PMAtraaVWMcqsQ Crjqn+cjly+bPbEdxfIwJ/XXTIH8L/vScIpqWb2dyN5M5d8b0E/LZb5KxbW0aIt9QthkN7o0hOU lHdS5BAXiXd4MurV0e19qui3aweEmAba0z0RgHO5fV5gPgNB9TgYP1p3ZSPf2e5m7pctdHSM4ga fZOuBEqiDGksquXGTDiGOQ3kUvTSxVlKXsUUULNCFkUqweGTWMzQYDP1fc7a12pJ43r65eUUkZ4 dg3I92Hi7R03I4pHUoCSunskvT3a/TZhssARjsAnTVh9npBA0Y2xYE8CbPy01OXz+uBCkHUXEnI fQZtqmUfFnsWu2bwA41NSfrxaV5H0wXdNRfKwe/IC3gjYzTiAHfrsDaKF5dMvD7GEuUdjmvzFUG +h045KgMHrfJZMWpSWaN5vJKUo= X-Received: by 2002:a17:903:2b0b:b0:2dd:ad73:c93e with SMTP id d9443c01a7336-2e6003c0633mr35463525ad.31.1791426524768; Wed, 07 Oct 2026 19:28:44 -0700 (PDT) Received: from d.home.yangfl.dn42 ([2a09:bac5:661c:1246::1d2:d1]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2e60482cab0sm18045865ad.50.2026.10.07.19.28.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 07 Oct 2026 19:28:44 -0700 (PDT) From: David Yang To: netdev@vger.kernel.org Cc: David Yang , Jian Shen , Jijie Shao , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Nicolai Buchwitz , Maxime Chevallier , Stanislav Fomichev , linux-kernel@vger.kernel.org Subject: [PATCH net 01/10] net: hisilicon: hisi_femac: Move setting of netops to fix crash Date: Thu, 8 Oct 2026 10:26:43 +0800 Message-ID: <20261008022656.3592191-2-mmyangfl@gmail.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20261008022656.3592191-1-mmyangfl@gmail.com> References: <20261008022656.3592191-1-mmyangfl@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit hisi_femac_drv_probe() connects the PHY before dev->netdev_ops is assigned. phy_attach_direct() -> phy_link_topo_add_phy() reads dev->netdev_ops through netdev_need_ops_lock() since the commit in question, so probing crashes with a NULL pointer dereference when CONFIG_NET_SHAPER is enabled. phy_link_topo_add_phy from phy_attach_direct+0xec/0x37c of_phy_get_and_connect from hisi_femac_drv_probe+0x1f4/0x558 Kernel panic - not syncing: Attempted to kill init! exitcode=0x0000000b Assign netdev_ops before the PHY attach, as was done for emac in commit 7c9f391ec89c ("net: emac: move setting of netops to fix crash"). Fixes: ded86da4bbb7 ("net: ethtool: relax ethnl_req_get_phydev() locking assertion") Signed-off-by: David Yang --- drivers/net/ethernet/hisilicon/hisi_femac.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/net/ethernet/hisilicon/hisi_femac.c b/drivers/net/ethernet/hisilicon/hisi_femac.c index d244a40df430..016605e86f0b 100644 --- a/drivers/net/ethernet/hisilicon/hisi_femac.c +++ b/drivers/net/ethernet/hisilicon/hisi_femac.c @@ -830,6 +830,8 @@ static int hisi_femac_drv_probe(struct platform_device *pdev) hisi_femac_phy_reset(priv); } + ndev->netdev_ops = &hisi_femac_netdev_ops; + phy = of_phy_get_and_connect(ndev, node, hisi_femac_adjust_link); if (!phy) { dev_err(dev, "connect to PHY failed!\n"); @@ -850,7 +852,6 @@ static int hisi_femac_drv_probe(struct platform_device *pdev) ndev->watchdog_timeo = 6 * HZ; ndev->priv_flags |= IFF_UNICAST_FLT; - ndev->netdev_ops = &hisi_femac_netdev_ops; ndev->ethtool_ops = &hisi_femac_ethtools_ops; netif_napi_add_weight(ndev, &priv->napi, hisi_femac_poll, FEMAC_POLL_WEIGHT); -- 2.53.0