From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f179.google.com (mail-pf1-f179.google.com [209.85.210.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 47DE0369D71 for ; Thu, 8 Oct 2026 03:57:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.179 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791431826; cv=none; b=Ck4ubJrrMdcyqHlyAcgnXvNM1Vtpi0EMubqnLTnj30+hfx72HJC4Vm3FwCH1tftvIRODIbQdDJNJ0qKLUsVxd+MWXIPQMSv4JaN239rtyb56rL76sVAfo8nexmg8GXd9nYvqzAiv7ekTd1Vk6XYQRyP/oSIyhZp+ycMzix8UypE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791431826; c=relaxed/simple; bh=Zy3DQ2bg09l45QUdJegt9V4PSCAJQxSliXQ/WCsW8y8=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=iTWHKK+Mh3RRvjQ5DpjSWKhgqMq6SQnWP2mnJlcr6D4BKwtkPAN3xLd26POttmg4ruZ5T957YEOayThHIwo6e5ABzfLVzIllWSQTZUKdcwJACpXPNxdVLhlZbukNMp9r6/NFuL34WEaflXmJsc2OQ7NGC40V+XIovvUeRnLaG/M= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=ZUwxbU44; arc=none smtp.client-ip=209.85.210.179 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ZUwxbU44" Received: by mail-pf1-f179.google.com with SMTP id d2e1a72fcca58-886e61fa30fso1080383b3a.1 for ; Wed, 07 Oct 2026 20:57:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1791431825; x=1792036625; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=aVcS6UviFiqfW7v+A1P6aceXNanxZ3sihwct+0rMisI=; b=ZUwxbU44CPGwHL8KYYZwa/oNIcH69QzyiYVNlDe1r3bS5NssH3KBVnpZJ/r2axplma D+jt4G3k277kfOpxx99rlH7fz+ADnEUSSG7PE7LxLEfT0FxZ0HGhKorZzfNvLJw+poXJ //gM4Y1gaiLpr6lfer3352m1qhIe7KuYh7ppMyaN7N4o+7iuvCSli5WAv1J1P6vqmJTH KvvBSrTAqbB9Ku/SbW6ew1nR47bZmGXe9ZPkEJuBeX0Y3Vo3m+Tu3eXAxksKhVH4ahMX STgNQzxIOx2L6OgCohsrh62Ohr86sn7MQjbfv/XfgH/lj52C8xTajj5pS9QOMDTaL0yi +enQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1791431825; x=1792036625; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=aVcS6UviFiqfW7v+A1P6aceXNanxZ3sihwct+0rMisI=; b=Dsg/3AItk9eqSuWV73qp6OwEyjKEW/FQ3jGDqpLiddaCOSrEvw/zdCM2NTLeP38kKR OkkpQ12LAGRXLWrsZT2PQWYtW4z+gByMv8bjbmNIeGcXgA3TrHAaJ2vhR6ojUTobxB6h TGUua2LaZsCaVBNr3pC9fIyUJP0vLBsoGpyc2DkD2myb2JTxx1FEDU+G+RS1AJMQ6J5v wQZdNOmDHMMRf5lGe2+ciVEb4v1XQaLVgCmIoZsCBoZeileBBoUSsv39Tjaog6YQT7Yc 18rIaBBY7fXGseXsLJLVubMV4UoYVmAIFO3cWa8fKbCMt70N3mCnCM0vPC2hBia90rg9 X7xQ== X-Forwarded-Encrypted: i=1; AKwUvBxUK6+qEL1RMkwOqMtsrtY0q4NnvhDaU9nDJqajYta2h76MtTEoTB2NwUfSONPDiEU7uxyI3aJm7I2J7/c=@vger.kernel.org X-Gm-Message-State: AFq9FYIiqIM39mxMoPm/sCS80a9FT/3dzq/LWks4iidwwv7c65HX6I9X vFAK3Tau01yITAbIIWpre1NS3yBPLAa7FSSwm22ZtQnHY67DGWwrB+OW X-Gm-Gg: AYBFou0Fpb9uU9NQKYtXF6apj+h5plPhlBr2ddBtl7JvyH3SywMHxq+RLoz0sexoOa2 dIkMKNM62sWhcxIC1qSrxZd0IPFQeKouUyTLYZvG804pwsir8yekBisdqh/t39xUt01933HopYK bXkV5+7zXlJtgrzQQpn4qbcEaUi0iz4OKWZg9YcZrzRVxlYNrs5L/mQcZoVstv3jp8CIf2Jzxl1 3wtwREK2ybzThu3fHg9Dc6SWyWyqU/CfUOluK1a65a9gNfSXounnARv0IbDxDucPra6qvA5HcTs TVsbu3IsnVP6Z0d/IDdYPi4ZH/ssMt6Nms1DqrukDv0PC42eQKvfawje4PKQVy4rAw7+ZSfvUHh cJ6L3AFGhFTthuPAhSgMXXxH3Ke97Qt8Io6R+t9iEphJYvCwb5o0t+HeydcGLTlsStuPCUHBZAe WoJ/GXWiCexR2h77eP/alopZeFt4L/ORaxPyLxpEsHiozhdiwUW+mwwlK5U9CNbHAJSSBf0L9DQ KDfSQ== X-Received: by 2002:a05:6a00:a1f:b0:882:359f:ef42 with SMTP id d2e1a72fcca58-891b57c4d09mr2887938b3a.49.1791431824604; Wed, 07 Oct 2026 20:57:04 -0700 (PDT) Received: from dungbv.. ([116.98.134.138]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-892bac8e058sm1021934b3a.13.2026.10.07.20.57.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 07 Oct 2026 20:57:03 -0700 (PDT) From: Bui Viet Dung To: Stephen Hemminger , Jamal Hadi Salim , Jiri Pirko , "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni Cc: Simon Horman , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org, Bui Viet Dung Subject: [PATCH] net/sched: sch_netem: prevent packet length underflow with negative overhead Date: Thu, 8 Oct 2026 10:56:56 +0700 Message-ID: <20261008035656.330667-1-dungvn2345@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit packet_time_ns() calculates transmission time for netem rate shaping. It adds q->packet_overhead (signed 32-bit int) to len (unsigned 64-bit int). When userspace configures a negative packet overhead (via TCA_NETEM_RATE packet_overhead attribute) and an enqueued packet's length is smaller than the absolute overhead, (s64)len + q->packet_overhead is negative. Because len is u64, the addition wraps into an astronomical value (~2^64 - 1). When multiplied by NSEC_PER_SEC and divided by q->rate, the calculated delay spans hours or days, causing enqueued packets to be frozen in the qdisc indefinitely and stalling transmission. A similar underflow can occur in cell length calculation when (q->cell_size + q->cell_overhead) is non-positive. Clamp the effective packet length to 0 if the overhead adjustment would underflow, and return 0 delay if effective cell length is non-positive, matching the behavior in sch_cake and sch_tbf. Fixes: 7bc0f28c7a0c ("netem: rate extension") Cc: stable@vger.kernel.org Signed-off-by: Bui Viet Dung --- net/sched/sch_netem.c | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/net/sched/sch_netem.c b/net/sched/sch_netem.c index 8a1b89a289d..a3dcd33bec4 100644 --- a/net/sched/sch_netem.c +++ b/net/sched/sch_netem.c @@ -366,14 +366,20 @@ static s64 tabledist(s64 mu, s32 sigma, static u64 packet_time_ns(u64 len, const struct netem_sched_data *q) { + if ((s64)len + q->packet_overhead <= 0) + return 0; + len += q->packet_overhead; if (q->cell_size) { u32 cells = reciprocal_divide(len, q->cell_size_reciprocal); + s32 cell_len = (s32)q->cell_size + q->cell_overhead; if (len > cells * q->cell_size) /* extra cell needed for remainder */ cells++; - len = cells * (q->cell_size + q->cell_overhead); + if (cell_len <= 0) + return 0; + len = (u64)cells * cell_len; } return div64_u64(len * NSEC_PER_SEC, q->rate); -- 2.43.0