mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Saravanan D <saravanand@crusoe.ai>
To: linux-nvme@lists.infradead.org
Cc: Saravanan D <saravanand@crusoe.ai>,
	kbusch@kernel.org, hch@lst.de, sagi@grimberg.me, axboe@kernel.dk,
	nilay@linux.ibm.com, dwagner@suse.de,
	linux-kernel@vger.kernel.org, iyamahata@crusoe.ai,
	kiyer@crusoe.ai, ganbalagane@crusoe.ai, sj@crusoe.ai
Subject: Re: [PATCH v4 0/2] nvme-tcp: allow setting per-queue io_cpu through sysfs
Date: Wed,  7 Oct 2026 22:39:04 -0700	[thread overview]
Message-ID: <20261008053906.38005-1-saravanand@crusoe.ai> (raw)
In-Reply-To: <20260927070925.47209-1-saravanand@crusoe.ai>

The Sashiko review of this series [1] found lifecycle bugs in the
sysfs registration, including a use after free of ctrl->queues_kobj
after ops->free_ctrl() and a reference cycle that leaks the controller
on every disconnect. I will address all of its comments in v5, so
please hold off on applying v4.

[1] https://sashiko.dev/#/patchset/20260927070925.47209-1-saravanand%40crusoe.ai

Thanks,
Saravanan D.

      parent reply	other threads:[~2026-10-08  5:39 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-27  7:09 Saravanan D
2026-09-27  7:09 ` [PATCH v4 1/2] nvme: add per-queue sysfs directories Saravanan D
2026-10-08  9:59   ` Nilay Shroff
2026-09-27  7:09 ` [PATCH v4 2/2] nvme-tcp: allow setting per-queue io_cpu through sysfs Saravanan D
2026-10-08  9:45   ` Nilay Shroff
2026-10-09  2:01     ` Saravanan D
2026-10-11 20:27       ` Nilay Shroff
2026-10-17  2:34         ` Saravanan D
2026-10-08  5:39 ` Saravanan D [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261008053906.38005-1-saravanand@crusoe.ai \
    --to=saravanand@crusoe.ai \
    --cc=axboe@kernel.dk \
    --cc=dwagner@suse.de \
    --cc=ganbalagane@crusoe.ai \
    --cc=hch@lst.de \
    --cc=iyamahata@crusoe.ai \
    --cc=kbusch@kernel.org \
    --cc=kiyer@crusoe.ai \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-nvme@lists.infradead.org \
    --cc=nilay@linux.ibm.com \
    --cc=sagi@grimberg.me \
    --cc=sj@crusoe.ai \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®