From: Joey Lu <a0987203069@gmail.com>
To: sboyd@kernel.org
Cc: ychuang3@nuvoton.com, schung@nuvoton.com, yclu4@nuvoton.com,
bmasney+clk@redhat.com, jbrunet+clk@baylibre.com,
linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org,
linux-kernel@vger.kernel.org, Joey Lu <a0987203069@gmail.com>
Subject: [PATCH v2 0/1] clk: nuvoton: ma35d1-divider: use direct formula instead of divider table
Date: Thu, 8 Oct 2026 14:43:06 +0800 [thread overview]
Message-ID: <20261008064307.2757324-1-a0987203069@gmail.com> (raw)
The MA35D1 ADC clock divider register implements a simple closed-form
relation, rate = parent_rate / (2 * (N + 1)), but the driver models it
by building a clk_div_table with one entry per possible divider value
(up to 2^width entries) and feeding it through the generic
divider_recalc_rate()/divider_determine_rate()/divider_get_val() helpers.
Replace the table with direct arithmetic in recalc_rate()/determine_rate()/
set_rate(), and drop the unused mask_bit mechanism, whose only call site
passed a bitmask instead of a bit index, causing an out-of-range BIT()
shift.
Changes in v2 (addressing the Sashiko AI review of v1):
- Fix a possible division by zero: 2 * rate in determine_rate() and
set_rate() could overflow for very large requested rates, making the
divisor zero. Rates above parent_rate / 2 now short-circuit to a
divider of 1 before the multiplication.
- Fix the mismatch between determine_rate() and set_rate(): both used
a ceiling to pick the divider, yet determine_rate() reported a
closest-rounded rate, so set_rate() could program a different divider
than the one promised. Both now use closest rounding, as the original
CLK_DIVIDER_ROUND_CLOSEST code did, via a single shared helper
(ma35d1_clkdiv_get_val()) that also clamps the divider to its valid
range.
- Not changed: min_rate/max_rate are not checked in the driver, since
the clk core already applies them and the previous
divider_determine_rate() based code did not either.
Joey Lu (1):
clk: nuvoton: ma35d1-divider: use direct formula instead of divider
table
drivers/clk/nuvoton/clk-ma35d1-divider.c | 79 ++++++++++++------------
drivers/clk/nuvoton/clk-ma35d1.c | 2 +-
drivers/clk/nuvoton/clk-ma35d1.h | 2 +-
3 files changed, 42 insertions(+), 41 deletions(-)
--
2.43.0
next reply other threads:[~2026-10-08 6:43 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-08 6:43 Joey Lu [this message]
2026-10-08 6:43 ` [PATCH v2 1/1] " Joey Lu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261008064307.2757324-1-a0987203069@gmail.com \
--to=a0987203069@gmail.com \
--cc=bmasney+clk@redhat.com \
--cc=jbrunet+clk@baylibre.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sboyd@kernel.org \
--cc=schung@nuvoton.com \
--cc=ychuang3@nuvoton.com \
--cc=yclu4@nuvoton.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®