From: "Naveen N Rao (AMD)" <naveen@kernel.org>
To: Borislav Petkov <bp@alien8.de>,
Dave Hansen <dave.hansen@linux.intel.com>
Cc: <linux-kernel@vger.kernel.org>, <x86@kernel.org>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, Bharata B Rao <bharata@amd.com>,
Manali Shukla <manali.shukla@amd.com>,
Nikunj A Dadhania <nikunj@amd.com>,
"H. Peter Anvin" <hpa@zytor.com>,
Robert Richter <rrichter@amd.com>,
Christian Ludloff <ludloff@gmail.com>
Subject: [PATCH v6] x86/apic: Use EILVT register count from APIC_EFEAT
Date: Thu, 8 Oct 2026 14:48:50 +0530 [thread overview]
Message-ID: <20261008091850.1453093-1-naveen@kernel.org> (raw)
Future AMD processors will increase the number of EILVT registers. Track
the EILVT register max count in a variable. Use the current default of 4
EILVT max count from F10h times as the fallback.
Use the APIC_EILVT_NR_AMD_10H macro only in force_ibs_eilvt_setup()
which is F10 specific anyway.
Signed-off-by: Naveen N Rao (AMD) <naveen@kernel.org>
---
Since v5 (http://lore.kernel.org/r/20260925161706.1619042-1-naveen@kernel.org):
- Simplify commit log (Boris)
- Drop Tested-by tags (Boris)
- Naveen
arch/x86/include/asm/apic.h | 2 ++
arch/x86/include/asm/apicdef.h | 2 +-
arch/x86/events/amd/ibs.c | 4 ++--
arch/x86/kernel/apic/apic.c | 16 ++++++++++++++--
4 files changed, 19 insertions(+), 5 deletions(-)
diff --git a/arch/x86/include/asm/apic.h b/arch/x86/include/asm/apic.h
index 9cd493d467d4..578cc28b3134 100644
--- a/arch/x86/include/asm/apic.h
+++ b/arch/x86/include/asm/apic.h
@@ -317,6 +317,8 @@ struct apic {
void (*update_vector)(unsigned int cpu, unsigned int vector, bool set);
+ u32 eilvt_regs_count;
+
char *name;
};
diff --git a/arch/x86/include/asm/apicdef.h b/arch/x86/include/asm/apicdef.h
index bc125c4429dc..32a242ae0455 100644
--- a/arch/x86/include/asm/apicdef.h
+++ b/arch/x86/include/asm/apicdef.h
@@ -134,12 +134,12 @@
#define APIC_TDR_DIV_64 0x9
#define APIC_TDR_DIV_128 0xA
#define APIC_EFEAT 0x400
+#define APIC_EFEAT_XLC(x) (((x) >> 16) & 0xff)
#define APIC_ECTRL 0x410
#define APIC_SEOI 0x420
#define APIC_IER 0x480
#define APIC_EILVTn(n) (0x500 + 0x10 * n)
#define APIC_EILVT_NR_AMD_10H 4
-#define APIC_EILVT_NR_MAX APIC_EILVT_NR_AMD_10H
#define APIC_BASE (fix_to_virt(FIX_APIC_BASE))
#define APIC_BASE_MSR 0x800
diff --git a/arch/x86/events/amd/ibs.c b/arch/x86/events/amd/ibs.c
index 3531f9c23b8c..555912ac520f 100644
--- a/arch/x86/events/amd/ibs.c
+++ b/arch/x86/events/amd/ibs.c
@@ -1839,13 +1839,13 @@ static void force_ibs_eilvt_setup(void)
preempt_disable();
/* find the next free available EILVT entry, skip offset 0 */
- for (offset = 1; offset < APIC_EILVT_NR_MAX; offset++) {
+ for (offset = 1; offset < APIC_EILVT_NR_AMD_10H; offset++) {
if (get_eilvt(offset))
break;
}
preempt_enable();
- if (offset == APIC_EILVT_NR_MAX) {
+ if (offset == APIC_EILVT_NR_AMD_10H) {
pr_debug("No EILVT entry available\n");
return;
}
diff --git a/arch/x86/kernel/apic/apic.c b/arch/x86/kernel/apic/apic.c
index 90025451ace2..434e118b71c8 100644
--- a/arch/x86/kernel/apic/apic.c
+++ b/arch/x86/kernel/apic/apic.c
@@ -341,7 +341,7 @@ static void __setup_APIC_LVTT(unsigned int clocks, int oneshot, int irqen)
* necessarily a BIOS bug.
*/
-static atomic_t eilvt_offsets[APIC_EILVT_NR_MAX];
+static atomic_t *eilvt_offsets;
static inline int eilvt_entry_is_changeable(unsigned int old, unsigned int new)
{
@@ -354,7 +354,7 @@ static unsigned int reserve_eilvt_offset(int offset, unsigned int new)
{
unsigned int rsvd, vector;
- if (offset >= APIC_EILVT_NR_MAX)
+ if (!eilvt_offsets || offset >= apic->eilvt_regs_count)
return ~0;
rsvd = atomic_read(&eilvt_offsets[offset]);
@@ -410,6 +410,17 @@ int setup_APIC_eilvt(u8 offset, u8 vector, u8 msg_type, u8 mask)
}
EXPORT_SYMBOL_GPL(setup_APIC_eilvt);
+static __init void init_eilvt(void)
+{
+ if (cpu_feature_enabled(X86_FEATURE_EXTAPIC))
+ apic->eilvt_regs_count = APIC_EFEAT_XLC(apic_read(APIC_EFEAT));
+ else if (boot_cpu_data.x86_vendor == X86_VENDOR_AMD)
+ apic->eilvt_regs_count = APIC_EILVT_NR_AMD_10H;
+
+ if (apic->eilvt_regs_count)
+ eilvt_offsets = kzalloc_objs(atomic_t, apic->eilvt_regs_count);
+}
+
/*
* Program the next event, relative to now
*/
@@ -2345,6 +2356,7 @@ static void __init apic_bsp_setup(bool upmode)
if (upmode)
apic_bsp_up_setup();
setup_local_APIC();
+ init_eilvt();
enable_IO_APIC();
end_local_APIC_setup();
base-commit: 48437a9ff10dc31e479822d5efbf637690a215e9
--
2.55.0
reply other threads:[~2026-10-08 9:19 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261008091850.1453093-1-naveen@kernel.org \
--to=naveen@kernel.org \
--cc=bharata@amd.com \
--cc=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=ludloff@gmail.com \
--cc=manali.shukla@amd.com \
--cc=mingo@redhat.com \
--cc=nikunj@amd.com \
--cc=rrichter@amd.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®