From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: linux-input@vger.kernel.org
Cc: Support Opensource <support.opensource@diasemi.com>,
Roy Im <roy.im.opensource@diasemi.com>,
Dan Murphy <dmurphy@ti.com>,
Yegor Yefremov <yegorslists@googlemail.com>,
linux-kernel@vger.kernel.org
Subject: [PATCH 2/4] Input: drv2665 - fix input device parent assignment
Date: Thu, 8 Oct 2026 02:47:32 -0700 [thread overview]
Message-ID: <20261008094736.918137-2-dmitry.torokhov@gmail.com> (raw)
In-Reply-To: <20261008094736.918137-1-dmitry.torokhov@gmail.com>
Assigning the I2C bus controller (client->dev.parent) instead of the
I2C client (&client->dev) as the parent device after
devm_input_allocate_device() causes input_register_device() to attach
the devm unregistration action to the parent controller device rather
than the client device. This leaves the input device registered on
driver unbind, leading to use-after-free.
devm_input_allocate_device() already sets input_dev->dev.parent to
&client->dev. Drop the redundant and erroneous assignment.
Fixes: 4d10da13467e ("Input: add TI drv2665 haptics driver")
Assisted-by: LLM
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
---
drivers/input/misc/drv2665.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/input/misc/drv2665.c b/drivers/input/misc/drv2665.c
index 4f8c1f69aa63..134d65fdcf2d 100644
--- a/drivers/input/misc/drv2665.c
+++ b/drivers/input/misc/drv2665.c
@@ -180,7 +180,6 @@ static int drv2665_probe(struct i2c_client *client)
}
haptics->input_dev->name = "drv2665:haptics";
- haptics->input_dev->dev.parent = client->dev.parent;
haptics->input_dev->close = drv2665_close;
input_set_drvdata(haptics->input_dev, haptics);
input_set_capability(haptics->input_dev, EV_FF, FF_RUMBLE);
--
2.56.0.385.gd3acb90ef8-goog
next prev parent reply other threads:[~2026-10-08 9:47 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-08 9:47 [PATCH 1/4] Input: da7280 " Dmitry Torokhov
2026-10-08 9:47 ` Dmitry Torokhov [this message]
2026-10-08 9:47 ` [PATCH 3/4] Input: drv2667 " Dmitry Torokhov
2026-10-08 9:47 ` [PATCH 4/4] Input: tps6507x-ts " Dmitry Torokhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261008094736.918137-2-dmitry.torokhov@gmail.com \
--to=dmitry.torokhov@gmail.com \
--cc=dmurphy@ti.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=roy.im.opensource@diasemi.com \
--cc=support.opensource@diasemi.com \
--cc=yegorslists@googlemail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®