From: Thorsten Blum <blum@kernel.org>
To: Thomas Gleixner <tglx@kernel.org>, Ingo Molnar <mingo@redhat.com>,
Borislav Petkov <bp@alien8.de>,
Dave Hansen <dave.hansen@linux.intel.com>,
x86@kernel.org, "H. Peter Anvin" <hpa@zytor.com>
Cc: Thorsten Blum <blum@kernel.org>, linux-kernel@vger.kernel.org
Subject: [PATCH] x86/early_printk: Use bool for the keep flag
Date: Thu, 8 Oct 2026 12:00:46 +0200 [thread overview]
Message-ID: <20261008100047.184420-2-blum@kernel.org> (raw)
The keep flag is only used as a boolean. Change its type to bool. Use
pr_crit() instead of printk(KERN_CRIT) while at it.
No functional change.
Signed-off-by: Thorsten Blum <blum@kernel.org>
---
arch/x86/kernel/early_printk.c | 7 +++----
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/arch/x86/kernel/early_printk.c b/arch/x86/kernel/early_printk.c
index cba75306e5b6..28e4ed9de17f 100644
--- a/arch/x86/kernel/early_printk.c
+++ b/arch/x86/kernel/early_printk.c
@@ -370,11 +370,10 @@ static struct console early_serial_console = {
.index = -1,
};
-static void early_console_register(struct console *con, int keep_early)
+static void early_console_register(struct console *con, bool keep_early)
{
if (con->index != -1) {
- printk(KERN_CRIT "ERROR: earlyprintk= %s already used\n",
- con->name);
+ pr_crit("ERROR: earlyprintk= %s already used\n", con->name);
return;
}
early_console = con;
@@ -387,7 +386,7 @@ static void early_console_register(struct console *con, int keep_early)
static int __init setup_early_printk(char *buf)
{
- int keep;
+ bool keep;
if (!buf)
return 0;
reply other threads:[~2026-10-08 10:01 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261008100047.184420-2-blum@kernel.org \
--to=blum@kernel.org \
--cc=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@kernel.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®