From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-dy1-f174.google.com (mail-dy1-f174.google.com [74.125.82.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B013D497394 for ; Thu, 8 Oct 2026 10:43:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.174 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791456204; cv=none; b=KyGQAErApWYR75kpCKeo88ga5q/Uvch9qly6vgcO0S4aBZ0PdbJcsGIQEpoDCCFVwC11fizPe5AZnW2hRFZ7GQkjg9h1rPBE19vLhD68HB8gSpCrBmXvKGFMlOslBf330gOlEwhy8frGDEPAJLbgi2ZUBAkdysGcKvlzoaNZIU0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791456204; c=relaxed/simple; bh=aeGEPZ62WG1rYJ4UmaiX7V6fFIdooxIunanCDD+ki4c=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=oBZm+VkfzuA/MSOjSJVMdhbsVmSdmkIuu7bPd4KegYQnuHKosYWC6g/MsqsIu8ZXtT0b8rmBXM4qSDIPIBHL/tc1wK0K9M+9PbT6B0hveLpNM8PAUG70eN6qAwKcOL+tEpGirwJFwF+reUQL0C3D7WlJ28iL3N2LXU7DP/ADvuk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=QqbaLtvd; arc=none smtp.client-ip=74.125.82.174 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="QqbaLtvd" Received: by mail-dy1-f174.google.com with SMTP id 5a478bee46e88-3115c4451c8so4255127eec.1 for ; Thu, 08 Oct 2026 03:43:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1791456202; x=1792061002; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=tshzH2hs2YBcBixu+hfpqJYKGYNe4yJtAc6VriLVkyE=; b=QqbaLtvdeAG6Y1NhbTL0mnCEim129iFor3iYntr1lKwXCDkw52HzBg+IecyfOz8hn0 fRmJG+QLEmLhE8W3J9utOw7oxyLDW9+FarC8K+kMdbq8akphK6eJW4gFDHIYTOjKDEe8 mEuFmxtX3Yx1FQLNmTWrgay/q2JMhs0CgRidSPCZA0Q3LD4+8orSZQBAexakzbaLj/1F GmWV8iuVna+J5NSFH+Dmj8weZt2cTV56okL0EMlXVkmzWO4XhGCpfwynyiBjrMyk20We jJUpqrx6/uPDecWL0U+MW3zts7qn7WFJ/XdYU7GiJ/MXq+r8+7PF/Cun+afPxpoSB85q N4/Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1791456202; x=1792061002; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=tshzH2hs2YBcBixu+hfpqJYKGYNe4yJtAc6VriLVkyE=; b=D0S5Tbq5LVQKu8DxS87cjgzlpGHC0Ycvk/PYK6a2a7YvGvwbGHCckAnjIg++dMJb6s hJHAaa2aYxmRp5elocBWfzUuxQhA7W58gdhTvoLogqRcteBH5crYRR5Vk1pW1lZCr8// SrPAGT+UDDQobnqcwxx3YCgK12HkQQ55bfPZE2WFuR4XVsc6zeDJkSDuWZBBKWgA422D AC4lMCBi/qOIIwSjuc/i0p1PzHv1lqHntdMwCGTwPXoloBhXEqJsDXTMCFW3QsEeGfm5 ssAgQ5Pm+KlGaQggiuLnSbKJK1//doHn9Dv6qeI5m9IKert/SMZpYdVrheS22cRhjtsP 7CCw== X-Forwarded-Encrypted: i=1; AKwUvBxn++K8X/+g2kHQA0tydgvXayN5qo3gFNPF7NYRS/ckMLCL8DOPZnYl4OjDYL3uXfAhfsX81aCeOxAxv7I=@vger.kernel.org X-Gm-Message-State: AFq9FYIppYexXfeN8uU99Gdda4yyMQB9Btx8sUVjeUax+Bz/FpqTchVW CdVhqd4sd29+1e4Yy6utoOB9HkC+RL/LMbq62mYnZsdbOAqjPfWJhJxu X-Gm-Gg: AYBFou0ddYRO97Cm9P4vaUP49JsY8ZG65J4Am/IKEJsPJU06S8gXCdQcYRgXrfb5KlC 8hpMSJiXag3XdBBRIjXRQuXpyZCl6L01zFG391m+8lZt8mY5WB8vKhr4rT5lVA4idbDcBLKyRV4 L6bW0dZwNJZphlXe/gmU9nwixDrB9uut7uKF+7++ii+mbiUz0JXrVW/GdJmWWviMroAiE/Xfnwb g3CCNEeYrXivhzf2fz8SZOlu8dGJNOzDyUFttVHdcvPuZQq07Ghhf6cNadC5sIhuVUUmkVC7/tD Svd7fX2pJ+dzO3l4FYF/vKUwr6byzxhqiL/AemtXTdbNnX8Zi9G4xNgVDEn0yYBlPPrWoHXVxjw XHQk5jHPISHt3LDpizDgdTdryxC3wu7hdQ/RabP5SJ1b/W9qIfse5Fu503fvXwWid/HwP8NiEp9 CHdaDyvLy/1ATVHBQjKWv6Ob+AZSA5tdjLYQTMB/9xyNAYtEqcV9iaAJ39OdpNUt/YilJ3hIWKR PU/AADYqheihXfla7UNlKCNjy7tl1y8/RhFEgPaS5dZPFIsaSEwsBhI0V+g4XTfcgk68aq7WYw8 3qlUMsOWJCpj2w== X-Received: by 2002:a05:7300:601e:b0:351:2200:1cde with SMTP id 5a478bee46e88-35177712b66mr2416825eec.8.1791456201448; Thu, 08 Oct 2026 03:43:21 -0700 (PDT) Received: from phuc-desktop.. ([183.91.15.56]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-3517810b895sm7496369eec.17.2026.10.08.03.43.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 08 Oct 2026 03:43:20 -0700 (PDT) From: phucduc.bui@gmail.com To: Vijendar Mukunda , Venkata Prasad Potturu , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , povik+lin@cutebit.org, Claudiu Beznea , Andrei Simion , Nicolas Ferre , Alexandre Belloni , David Rhodes , Richard Fitzgerald , Shengjiu Wang , Xiubo Li , Fabio Estevam , Nicolin Chen , Frank Li , Sascha Hauer , Pengutronix Kernel Team , Cezary Rojewski , Peter Ujfalusi , Bard Liao , Kai Vehmanen , Pierre-Louis Bossart , Kuninori Morimoto , Geert Uytterhoeven , Magnus Damm , Biju Das , Lad Prabhakar , Heiko Stuebner Cc: Kees Cook , Syed Saba Kareem , wangdicheng , Chris Bainbridge , Linus Walleij , Charles Keepax , Neo Chang , Krzysztof Kozlowski , u.kleine-koenig@baylibre.com, Pengpeng Hou , Cristian Ciocaltea , Hemanth Selam , Md Shofiqul Islam , Bjorn Helgaas , Zain Aboobacker , Sang-Heon Jeon , Ajit Kumar Pandey , Ravulapati Vishnu vardhan rao , Bo Shen , Vinod Koul , linux-sound@vger.kernel.org, asahi@lists.linux.dev, linux-arm-kernel@lists.infradead.org, patches@opensource.cirrus.com, linuxppc-dev@lists.ozlabs.org, imx@lists.linux.dev, linux-rockchip@lists.infradead.org, linux-renesas-soc@vger.kernel.org, linux-kernel@vger.kernel.org, bui duc phuc Subject: [PATCH 17/24] ASoC: codecs: wm8782: Ensure the DAI is marked as started on success Date: Thu, 8 Oct 2026 17:38:24 +0700 Message-ID: <20261008103831.542533-18-phucduc.bui@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20261008103831.542533-1-phucduc.bui@gmail.com> References: <20261008103831.542533-1-phucduc.bui@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: bui duc phuc snd_pcm_hw_constraint_minmax() may return 1, which is then returned from wm8782_dai_startup(). ASoC only marks the DAI as started when .startup() returns 0. This currently has no functional impact, as wm8782_dai_ops has no .shutdown() callback. Still, return 0 explicitly on success to match what ASoC expects and ensure the DAI is correctly marked as started. Signed-off-by: bui duc phuc --- sound/soc/codecs/wm8782.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/sound/soc/codecs/wm8782.c b/sound/soc/codecs/wm8782.c index 3a2acdfa9b85..767251ac4f89 100644 --- a/sound/soc/codecs/wm8782.c +++ b/sound/soc/codecs/wm8782.c @@ -39,9 +39,14 @@ static int wm8782_dai_startup(struct snd_pcm_substream *sub, struct snd_soc_dai struct snd_pcm_runtime *runtime = sub->runtime; struct wm8782_priv *priv = snd_soc_component_get_drvdata(dai->component); + int ret; - return snd_pcm_hw_constraint_minmax(runtime, SNDRV_PCM_HW_PARAM_RATE, + ret = snd_pcm_hw_constraint_minmax(runtime, SNDRV_PCM_HW_PARAM_RATE, 8000, priv->max_rate); + if (ret < 0) + return ret; + + return 0; } static const struct snd_soc_dapm_widget wm8782_dapm_widgets[] = { -- 2.43.0