From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-dy1-f173.google.com (mail-dy1-f173.google.com [74.125.82.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AEEE23BB133 for ; Thu, 8 Oct 2026 10:39:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.173 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791455995; cv=none; b=GgtSN5HQ1sFUWa9ZN5cEB5GdiPhtBFzeGiMkhUI/ClEqgrQIwiFZPs0vZAvL2COQGhMQG+dvnwYB9GQi9beknR1O/GK+MdET9m+rgT6xM8VjRL6oB7JLpZyUngd83lD6K5czbSis+ILAOxfB3EiLhK1lcRwKoKzwukFRYfG3N1k= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791455995; c=relaxed/simple; bh=xzwyXU0svYILi7ZURG5eXIdZab9K6St2c6iN68qi5hU=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=rNQelLtVEGuoJLYdEZ77eQIGJqA2BN4OeATDwpartpeZIsxTUd7rD07wIKLztt3Nxf473rqXIC6xtB4lSusOsfkcaLPrBhIFE6UwflZ2d0fj5THcbIV3Kkf82Wg4HGbqH4BG0BusHJtAkhx0ldsGSzhrXBAKpmQkzhklkIIPjTc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=InfXuhe/; arc=none smtp.client-ip=74.125.82.173 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="InfXuhe/" Received: by mail-dy1-f173.google.com with SMTP id 5a478bee46e88-30b6dad2382so6456329eec.0 for ; Thu, 08 Oct 2026 03:39:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1791455992; x=1792060792; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=mFcTZ+kGWiuWqdZS5yC9jJRo6WNRtV/WgwZSDkO0NF0=; b=InfXuhe/12nFPm7KmD7iXxOo+6KagYCF2jn0U1wId0Vd2eihi2uONyt8pbJB+4KGlB tNfV8wCtG7otyRHZKdezvRYYC6NvumQxXA+8E9B2QnISuM751TF+GcbA8RJsctlmyH8B lp6vIlOtzYY/j+G279Vv6X0Qjx7fuT7RJXlgfSHBhFxeaf4iAa+bhSzoNSj7srUOeNst M1LzctJeY++ZEGjmW/nInIzfCoNVrKDNyB7NHwj/GxfJ65IewbX8WO/0hwQHNoBQZ7B1 N4Mazk1iWxNvK6JEP1DBNupqqnEa5ePxhfHZEntRznJgNNW+H4wQkL/sDld0rUUTWxsJ +Aog== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1791455992; x=1792060792; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=mFcTZ+kGWiuWqdZS5yC9jJRo6WNRtV/WgwZSDkO0NF0=; b=k74cuw7NfbNGbxt6eU7gUkUrTAVvIbnzyMUg+CA2G+wt8SH1W50bFdSarD2OV5wXF4 4BOh3FS5Pu/2PlFVXsKxK2pwwVUgNoYm1E7xM1mKs8P/Ca54OjrebdbP8jAhF0dgYEpG gZ4AAixGB3nqlAhYzVu0Tgj+EW6PIhlWRFrq7hhFzPyO6gC3GFnyIKwyNhRdGGSm4lEb 6abJkcX0qfeAp6fyRR5w8xTS0OAo0qrQLV1pFDa/WxCvtsgne/ZuckyzPerHIAuge+g/ gObW8uRQI4IR1yccdfCQbMQBGT2ZLsQK+LWtiyYiud40I2wlWhhvKZOVdT+PyoqFEvVm wKmQ== X-Forwarded-Encrypted: i=1; AKwUvBzQnLVAy7xhUK1iHt9VKcu0QAWsso/4MkP2qXXJOtm4rheihPsindd5m4342VCUgXqr4pwr2vIHyvuc8D0=@vger.kernel.org X-Gm-Message-State: AFq9FYLy8Gkm2L8v3dFplblygO2wygYRd86biYk9bKjPXOc4+NF5lJZ6 0T6HOP5Nx6UMaAFzycoMPvCrrigIrQX4nkcmq5O/77E7ZyDxfEmw6b1i X-Gm-Gg: AYBFou2Vx8a0g+uJSX3MUtD35gby2AmKD/1IY2UVhFPqaQO4GnlA0eDPxTpMrQlIynr UjgPIhWEFUEvRfasiw1+eXI4aQz90vlmSH+arwIkvIBEzvj0UAQwOq6hVTbzqpKQWkY4HgvExW2 ce0n3x0Oq/3+mV3sQu/RFQoR06vgnQl+aeh5DOHEhRS6MrdTC7ssT/FZqIaHVk02HfvyO6Bwu2w 3C5od3bHXpMGxWjCFzlA/tZQ8N+V8OQsQp4D/fF4qiyEGu4QwcImbd9PN0wjWrK1brZqyg1t9gr h742i9YmJAqISK1EAqsYioofbCS6ElgW04mpfnPGdkIiDeagLsg48Vip4PxaZgzZoOPUE4lRgUx wvu+BnvoeS8gTlt2FfTq5UcTxLeZRP9XV7F7CbigeUKTa985j9EbsLC7NbFFFqBOQ9XyXIbZVZW pzUDthvhbS39oSZJe2jtmMzI89vSdcCrnOU+ZIuJnrnT+/oLb2APiqQyEfQeh+F15l+/5K8n9J0 WuVRUcTeB+FGB9iH2RMteCN0W0Z5LVVJ6MmJ4ukvLkjYgv12e7FcPm7rzIBUiPVsjvEPM55n9DG DTTHGyHV5T3U1Xs= X-Received: by 2002:a05:7301:3d0e:b0:351:5112:ec4b with SMTP id 5a478bee46e88-3515da5dc10mr5687961eec.2.1791455992008; Thu, 08 Oct 2026 03:39:52 -0700 (PDT) Received: from phuc-desktop.. ([183.91.15.56]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-3517810b895sm7496369eec.17.2026.10.08.03.39.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 08 Oct 2026 03:39:51 -0700 (PDT) From: phucduc.bui@gmail.com To: Vijendar Mukunda , Venkata Prasad Potturu , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , povik+lin@cutebit.org, Claudiu Beznea , Andrei Simion , Nicolas Ferre , Alexandre Belloni , David Rhodes , Richard Fitzgerald , Shengjiu Wang , Xiubo Li , Fabio Estevam , Nicolin Chen , Frank Li , Sascha Hauer , Pengutronix Kernel Team , Cezary Rojewski , Peter Ujfalusi , Bard Liao , Kai Vehmanen , Pierre-Louis Bossart , Kuninori Morimoto , Geert Uytterhoeven , Magnus Damm , Biju Das , Lad Prabhakar , Heiko Stuebner Cc: Kees Cook , Syed Saba Kareem , wangdicheng , Chris Bainbridge , Linus Walleij , Charles Keepax , Neo Chang , Krzysztof Kozlowski , u.kleine-koenig@baylibre.com, Pengpeng Hou , Cristian Ciocaltea , Hemanth Selam , Md Shofiqul Islam , Bjorn Helgaas , Zain Aboobacker , Sang-Heon Jeon , Ajit Kumar Pandey , Ravulapati Vishnu vardhan rao , Bo Shen , Vinod Koul , linux-sound@vger.kernel.org, asahi@lists.linux.dev, linux-arm-kernel@lists.infradead.org, patches@opensource.cirrus.com, linuxppc-dev@lists.ozlabs.org, imx@lists.linux.dev, linux-rockchip@lists.infradead.org, linux-renesas-soc@vger.kernel.org, linux-kernel@vger.kernel.org, bui duc phuc Subject: [PATCH 03/24] ASoC: amd: ps: Fix acp63_sdw_dma_close() being skipped on rollback Date: Thu, 8 Oct 2026 17:38:10 +0700 Message-ID: <20261008103831.542533-4-phucduc.bui@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20261008103831.542533-1-phucduc.bui@gmail.com> References: <20261008103831.542533-1-phucduc.bui@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: bui duc phuc snd_pcm_hw_constraint_integer() may return 1, which is then returned from acp63_sdw_dma_open(). ASoC only marks the component as opened when .open() returns 0, so .close() can be skipped on rollback. Return 0 explicitly on success. Fixes: f722917350ee ("ASoC: amd: ps: add SoundWire dma driver dma ops") Signed-off-by: bui duc phuc --- sound/soc/amd/ps/ps-sdw-dma.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/soc/amd/ps/ps-sdw-dma.c b/sound/soc/amd/ps/ps-sdw-dma.c index f27ebbd21379..553fe11a2e50 100644 --- a/sound/soc/amd/ps/ps-sdw-dma.c +++ b/sound/soc/amd/ps/ps-sdw-dma.c @@ -337,7 +337,7 @@ static int acp63_sdw_dma_open(struct snd_soc_component *component, stream->stream_id = cpu_dai->id; stream->instance = amd_manager->instance; runtime->private_data = stream; - return ret; + return 0; } static int acp63_sdw_dma_hw_params(struct snd_soc_component *component, -- 2.43.0