From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-dy1-f174.google.com (mail-dy1-f174.google.com [74.125.82.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6418942E41B for ; Thu, 8 Oct 2026 10:40:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.174 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791456038; cv=none; b=SSxisTxH0WPpeGe2fj58NGT3sJ48QuUTRb0ru2//UKWeR30qooj5YwaPMymfeBs64NadMj28Jr01consqxsRFee0DwBoCoGtfZ30kyP2oTMFm/gnN8h2+wBRzuDIswWO8BNk5R7TldOHpbPbGFxv0eF2uXkSRHtab3PjDr7Q13I= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791456038; c=relaxed/simple; bh=nJhvrGr3lgVZ8FMtw/5ZoBJyNuHoH9T5gKcidfHw3xc=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=lhwFzGTXssI/k5+8ffU0TbuSugBXSLYCnzh0XSqjJQgibmlbOl7yjDZXVQfejSlid9n62UoNVq7BjI/mGH+CwVMcALY20fm1+rKpifggq9VoRQlo9oi+MVv6eKRU0RaIYqWauLY89p2bfltJhwUyFkdqLJ4KMIW9ICcjGOoS1Jo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=dQ+yFa9q; arc=none smtp.client-ip=74.125.82.174 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="dQ+yFa9q" Received: by mail-dy1-f174.google.com with SMTP id 5a478bee46e88-34bb8b31647so7925689eec.0 for ; Thu, 08 Oct 2026 03:40:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1791456036; x=1792060836; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=DCoq+QQx3kZdKIK7QgXRpmYJ03Qsfh2Iq2ERtZh+EYs=; b=dQ+yFa9qP9fusDVYGXiBSV8aiH3dg2a/H6kRFXfSdod9dxSUYanLrGwSL5H9cZHEQ6 vXkF1a8yfb6EjXlRXLQkwOcq1OOPmvmcwkOy5+3VyYnI5OGhTmbircUrgxtCi5iwxJMf /HADZQjoLL2fLq6QVlbiGLT+MIxg7BlEbpwNZZ6FvKlNJmIhTUG5zdC0LoFYnxHSXsBB vjgw+0th4yZUYL6lPb+gQcvGuLMoDojvDoaI1KxR3YOoFSSIEv6mAFDdZYyB9aI5nr1M jbINA73VhAkbN0DM7SF1I6zdmZSwNWA8MCrw/b5SYnzZQ0slfpOBRrXxVE/tLTXeg5y3 xatA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1791456036; x=1792060836; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=DCoq+QQx3kZdKIK7QgXRpmYJ03Qsfh2Iq2ERtZh+EYs=; b=qobrbS4qF6FMLivx3Fejo6iOapwEjWyscr695ftXoeNJI99VvU0A1okWKMHMxtp85A 25RroIAvf5FGE4w4UU82uwyRK4vuIWNEpZ/zYQVAn2PXuNO5cnaoB80ybTBQYJSZpiiZ UQZDzZcroIqm1eZEOcp/P0US7jh9n15tqxrKCKvnjPTfzS6/4hP0IKfnSaGIYkW7Hx4i k3/WkrIuitXvBgobqP+nGmNND0wcxDo/Ey2aB1ySw0LuEsB997kGPWwi9EhuC/ybKe5b xRt9h+eTD2OaIm0YWmpx8d037jOKZaznesA1tGZNeDYN2IuQQKp+6+TugHSbmHNzr+WY YF4g== X-Forwarded-Encrypted: i=1; AKwUvBxdkNmbQi+xuFSBVMqL09/D8tBdQ9VtFutaJ5YQ0KXJmHNbIef1DFb4DeHGIteycjbIY890bLBJpHr5sGU=@vger.kernel.org X-Gm-Message-State: AFq9FYLzrKbODrF/2H3mL+icPBn/1GEaBnkd10LRP73I+q7cU8pnlAn6 A5JNexItmXvasNFv1FCRUOcAP67Ban4fgn1jIXxbO0oDLpXvBQzOpPDh X-Gm-Gg: AYBFou2LA446akvKzo2e5S+Fyyzwf8zqXWmJ0+U7UOSbSIpomDhM7+u+edVA1Il2wPk alIvAior6OHN3Rmo1vWfcHg1X1ehuj5Uda3a0EY8bakInH8hPXbdMvCg/4zOeaswAfbILRtFPQa Ta3GAsrCZ+chXZp5KkTORifcL/Nlo6q4pjN2PEuS9GWhnZidi2qkd592gi2QJZ3B0b3gsjdCM5b qJtL0PZUt/PqAP3HTZ4Y8sYI3CwGwOobexcUVD+p0mgmrnK+rhqBcOY/gQ7ntTMUoKAzosepDEG xt6jsIsWIQtTyKAcz/3G7eQoouhE95KQkjjaZfL4ayNFgPiJo0ULSDEZFTAZR8RGXkQW6gE0UQE wa1A1H43lBFNjQejZDtZ2X5wW+tXYGYeMV4dqaG4hYA48Uc/jJe3xEBka28g4sWJd6GArJh5DUG kpyNcHl1Ae0bsgjiBjxkVhhPc6VVhUe8qIJr+xz7qHwbXXpuFWkw/Z+AjMyIY8Geg6gXVZou7qm bb4W3nnytEbuLQrnGIHDVPo+iA6BXBbI7TJC+SYvrrygpr6SPONtxDdOk7hT9JNsc0DFPoz4tgc 7VmC4dY1SINWssK0MkPEO+SJ X-Received: by 2002:a05:7300:b088:b0:34c:b75a:ac1e with SMTP id 5a478bee46e88-3515df70a46mr6358739eec.33.1791456036268; Thu, 08 Oct 2026 03:40:36 -0700 (PDT) Received: from phuc-desktop.. ([183.91.15.56]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-3517810b895sm7496369eec.17.2026.10.08.03.40.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 08 Oct 2026 03:40:35 -0700 (PDT) From: phucduc.bui@gmail.com To: Vijendar Mukunda , Venkata Prasad Potturu , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , povik+lin@cutebit.org, Claudiu Beznea , Andrei Simion , Nicolas Ferre , Alexandre Belloni , David Rhodes , Richard Fitzgerald , Shengjiu Wang , Xiubo Li , Fabio Estevam , Nicolin Chen , Frank Li , Sascha Hauer , Pengutronix Kernel Team , Cezary Rojewski , Peter Ujfalusi , Bard Liao , Kai Vehmanen , Pierre-Louis Bossart , Kuninori Morimoto , Geert Uytterhoeven , Magnus Damm , Biju Das , Lad Prabhakar , Heiko Stuebner Cc: Kees Cook , Syed Saba Kareem , wangdicheng , Chris Bainbridge , Linus Walleij , Charles Keepax , Neo Chang , Krzysztof Kozlowski , u.kleine-koenig@baylibre.com, Pengpeng Hou , Cristian Ciocaltea , Hemanth Selam , Md Shofiqul Islam , Bjorn Helgaas , Zain Aboobacker , Sang-Heon Jeon , Ajit Kumar Pandey , Ravulapati Vishnu vardhan rao , Bo Shen , Vinod Koul , linux-sound@vger.kernel.org, asahi@lists.linux.dev, linux-arm-kernel@lists.infradead.org, patches@opensource.cirrus.com, linuxppc-dev@lists.ozlabs.org, imx@lists.linux.dev, linux-rockchip@lists.infradead.org, linux-renesas-soc@vger.kernel.org, linux-kernel@vger.kernel.org, bui duc phuc Subject: [PATCH 06/24] ASoC: amd: vangogh: Fix acp5x_dma_close() being skipped on rollback Date: Thu, 8 Oct 2026 17:38:13 +0700 Message-ID: <20261008103831.542533-7-phucduc.bui@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20261008103831.542533-1-phucduc.bui@gmail.com> References: <20261008103831.542533-1-phucduc.bui@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: bui duc phuc snd_pcm_hw_constraint_integer() may return 1, which is then returned from acp5x_dma_open(). ASoC only marks the component as opened when .open() returns 0, so .close() can be skipped on rollback. Return 0 explicitly on success. Fixes: cab396d8b22c ("ASoC: amd: add ACP5x pcm dma driver ops") Signed-off-by: bui duc phuc --- sound/soc/amd/vangogh/acp5x-pcm-dma.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/soc/amd/vangogh/acp5x-pcm-dma.c b/sound/soc/amd/vangogh/acp5x-pcm-dma.c index 831e30e9b042..33d59d992ee0 100644 --- a/sound/soc/amd/vangogh/acp5x-pcm-dma.c +++ b/sound/soc/amd/vangogh/acp5x-pcm-dma.c @@ -231,7 +231,7 @@ static int acp5x_dma_open(struct snd_soc_component *component, } i2s_data->acp5x_base = adata->acp5x_base; runtime->private_data = i2s_data; - return ret; + return 0; } static int acp5x_dma_hw_params(struct snd_soc_component *component, -- 2.43.0