From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-dy1-f170.google.com (mail-dy1-f170.google.com [74.125.82.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 031243BFAEE for ; Thu, 8 Oct 2026 10:40:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.170 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791456054; cv=none; b=p48MekSQJhjHqjoneIOlrjgy2E2PrPYzTcUOD6tW3RwXBAQIGwzzJKYq8MhRkNy09TFkjsYwTLId9eBHwmvE3m0/8+p8YyVrlx/1TCUN1xV38FLYzp5UzKQIjtCx8dBGH7ZLmubTSujqo6teFtCngtYpQPck7Hb6/sjb2jQZ9ys= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791456054; c=relaxed/simple; bh=sAh2gdTD9duOj8WLvoGxiHxj5o2kOrdYeBV4NBuiVSQ=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=myJ1Pmfe8T+c1SNpyRj4apAJeVv8chPJTu0t8XL8+jkS4EZZBGKlbVQj4oNA8oLQIABx8dHER9d5dSy7I9GC9VlXlNXhIFS7++RW+Sm1iO+fhNLtzl/LSaJI7DcFaaalTNR17uj4BdO06Jxn6XJ1TqjnEEKrgdhfS5mZllrZQxY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=O5Cfxy5m; arc=none smtp.client-ip=74.125.82.170 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="O5Cfxy5m" Received: by mail-dy1-f170.google.com with SMTP id 5a478bee46e88-34bb8b31647so7926005eec.0 for ; Thu, 08 Oct 2026 03:40:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1791456051; x=1792060851; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=A3hFCOdGFcpARJPE61Pz7wx4lXLyiEMweFG5G2TuDs0=; b=O5Cfxy5mIDM8VmdPakK61HLiUvgqI+Gp3+lLOxj/cd0sCfTrDvMpdFI6ogQxuIq8XH Vdi3eEgcyRUK+LH4FbR1IdwdpmNtKK5yU6yldJyOFUe1PTHmanBZmOmWOjVUWUonCnNO gQTfYYn2l34y8ZVivQxY6QYgGM6sbAQ9dr4wIhXp6IibsLRzTWkA40LMaEce11NBsaN6 /KZbcr0ioMroT4PD44mIezUxdy9oxMYi8cYWxvDAYsqQIPI/GG0S1WYoN9dh+11FiGoC ltyhheaKCTnp0bXTj8G9st6NLuVZnEYudEpINBFw+NnoEYaSe/eGs1i2CirtozcW1Hll 5Tgw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1791456051; x=1792060851; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=A3hFCOdGFcpARJPE61Pz7wx4lXLyiEMweFG5G2TuDs0=; b=GjTW6XcdazZ4m84Xhzq6U/hxokfm2bNfofLs8lFkqnZe5fhBCRaS2scRyYtbBJgmkT b7rj7aVrN/eh/Gh6Jma0Iv1Xjc6J3ILlUFcDXwr7Rx4FoytpnDoETsJSfcJOqk+ZQla1 XZZXi66dKLu2KTGlpo3G7SSFjNxLna0Sr806GsaH5aaTKvdyI2y7nAx3hhAhcGR+s2+u byhNAEPTqp5nMCzCiqqrBF9PQ5Fp1gaIXKy7CMhNDMNzz6Zc+bKOncnb+sXRdX1JiDeT 04i9Dwa4GsfI3QywRcR8KV8DDoSJm/zE+TZNQwLM/u8RdtJqdFF4EkJGcDlJ4KTxjQ4E zYVg== X-Forwarded-Encrypted: i=1; AKwUvBznuM8uhB6z/kGuIFsR41i03tOKtgPLXfI0IoHU/ugANfh+Q9XL0A4IcgqHEtbidq0vBYeTz3dlZJlqTRk=@vger.kernel.org X-Gm-Message-State: AFuF++l21T2aP3NSN/uiXa0W+EhxawkEY1BMm9qijjIVLxpsGwo5ocrO UcK89d3Lb3DS8jlaYFal3XWJdOX1OHKO2TGq8JEeFY4g9NNT5tI3Zgf9 X-Gm-Gg: AYBFou2eHkblScc2mr1bYnur6i2Hi+sbhtg2dkR09jL8CBbGiQDwQe3UN43fLiOAv7n Zde/LXmi69piK72YHyvvZPRuj+9USOmi6Er1mC+xa3YXK23ljQV512gisb2gWdEYfSn5laL4qEk yn9jIYCKB7PLZy9hwVgz39FVDm31xRlOcEttd5xcmw4kjkxnxg9DUxvOJTI35mPVBaERqD1UuFg c0lBYxTlveSR3YrOJO+7BVxuucExekGvbDRtNTdajch6GnHhj/rXmXpzeDRFAgqRuFtxLSlpQWX EoVBFYLUj+3jL8Bu8QxGvaNkwqlEgXRUij1kpjjPIQ67Iub0qn98Fi25MZJN+/MFu9Z1ukSTKr7 EhpCwRdnNGtWVb6qTJRhE7x7TDhP2J2FzjXqZZleIuqaiQCeunOLLBg3/ed0i0jK0XwcmGQKhKN dwV86zvBlUoncXsAkEVvDl9/Hog/15J4SOumZfx02xFkaOF459l/LxWUy8jGmX25NUrYEnfIZ+4 8/4bB54kAWk6i+ngan55GlWT6w2VaojMrA1dG6kIPs6j33aKaSsh4v5EONL/p/IwdXFemQV1k17 eyZlvAzN836PEO0GB+ndKQyN X-Received: by 2002:a05:693c:41d2:10b0:351:62fe:62 with SMTP id 5a478bee46e88-35162fe0200mr5293677eec.19.1791456050997; Thu, 08 Oct 2026 03:40:50 -0700 (PDT) Received: from phuc-desktop.. ([183.91.15.56]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-3517810b895sm7496369eec.17.2026.10.08.03.40.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 08 Oct 2026 03:40:49 -0700 (PDT) From: phucduc.bui@gmail.com To: Vijendar Mukunda , Venkata Prasad Potturu , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , povik+lin@cutebit.org, Claudiu Beznea , Andrei Simion , Nicolas Ferre , Alexandre Belloni , David Rhodes , Richard Fitzgerald , Shengjiu Wang , Xiubo Li , Fabio Estevam , Nicolin Chen , Frank Li , Sascha Hauer , Pengutronix Kernel Team , Cezary Rojewski , Peter Ujfalusi , Bard Liao , Kai Vehmanen , Pierre-Louis Bossart , Kuninori Morimoto , Geert Uytterhoeven , Magnus Damm , Biju Das , Lad Prabhakar , Heiko Stuebner Cc: Kees Cook , Syed Saba Kareem , wangdicheng , Chris Bainbridge , Linus Walleij , Charles Keepax , Neo Chang , Krzysztof Kozlowski , u.kleine-koenig@baylibre.com, Pengpeng Hou , Cristian Ciocaltea , Hemanth Selam , Md Shofiqul Islam , Bjorn Helgaas , Zain Aboobacker , Sang-Heon Jeon , Ajit Kumar Pandey , Ravulapati Vishnu vardhan rao , Bo Shen , Vinod Koul , linux-sound@vger.kernel.org, asahi@lists.linux.dev, linux-arm-kernel@lists.infradead.org, patches@opensource.cirrus.com, linuxppc-dev@lists.ozlabs.org, imx@lists.linux.dev, linux-rockchip@lists.infradead.org, linux-renesas-soc@vger.kernel.org, linux-kernel@vger.kernel.org, bui duc phuc Subject: [PATCH 07/24] ASoC: amd: yc: Fix acp6x_pdm_dma_close() being skipped on rollback Date: Thu, 8 Oct 2026 17:38:14 +0700 Message-ID: <20261008103831.542533-8-phucduc.bui@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20261008103831.542533-1-phucduc.bui@gmail.com> References: <20261008103831.542533-1-phucduc.bui@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: bui duc phuc snd_pcm_hw_constraint_integer() may return 1, which is then returned from acp6x_pdm_dma_open(). ASoC only marks the component as opened when .open() returns 0, so .close() can be skipped on rollback. Return 0 explicitly on success. Fixes: ceb4fcc13ae5 ("ASoC: amd: add acp6x pdm driver dma ops") Signed-off-by: bui duc phuc --- sound/soc/amd/yc/acp6x-pdm-dma.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/soc/amd/yc/acp6x-pdm-dma.c b/sound/soc/amd/yc/acp6x-pdm-dma.c index 40c4d833f4ed..afa9f66533e3 100644 --- a/sound/soc/amd/yc/acp6x-pdm-dma.c +++ b/sound/soc/amd/yc/acp6x-pdm-dma.c @@ -209,7 +209,7 @@ static int acp6x_pdm_dma_open(struct snd_soc_component *component, pdm_data->acp6x_base = adata->acp6x_base; runtime->private_data = pdm_data; - return ret; + return 0; } static int acp6x_pdm_dma_hw_params(struct snd_soc_component *component, -- 2.43.0