From: Anton Karasev <uselessfire@gmail.com>
To: Mingyou Chen <qby140326@gmail.com>
Cc: ilpo.jarvinen@linux.intel.com, hansg@kernel.org,
ilya.gladyshev@linux.dev, kento@kekto.ru,
platform-driver-x86@vger.kernel.org, ericted8810@gmail.com,
W_Armin@gmx.de, linux-kernel@vger.kernel.org, chris@miget.com,
matias.civadda2342001@gmail.com, btx342@gmail.com,
wleizc7319@gmail.com, wolf109909@outlook.com,
vlku.milos.fun@gmail.com, i@rsplwe.com, bozhenpeng93@gmail.com,
nika@nikableh.moe
Subject: Re: [PATCH v9 3/5] platform/x86: bitland-mifs-wmi: Add Redmi mic-mute key entries
Date: Thu, 8 Oct 2026 18:26:51 +0300 [thread overview]
Message-ID: <20261008152651.1510220-1-uselessfire@gmail.com> (raw)
In-Reply-To: <20261001133705.69244-4-qby140326@gmail.com>
Hi Mingyou,
> - 0x00002101 (Fn-lock disabled state)
> - 0x00012101 (Fn-lock enabled state)
These are mic mute states, not Fn Lock ones. On the Redmi Book Pro 16
2024 (TM2309), EV20 puts the new mic state from the EC field MIUT into
the third byte, 0 for muted and 1 for unmuted, and Nika's report [1]
has 0x00002101 as muted and 0x00012101 as unmuted. In a test of v9 on
this machine, F4 gave KEY_MICMUTE with exactly these two payloads, so
the entries are right for these Xiaomi machines; only the commit
message needs the change.
> + { KE_KEY, BI_HOTKEY_CODE(0x21, 0, 0), { KEY_MICMUTE } },
> + { KE_KEY, BI_HOTKEY_CODE(0x21, 1, 0), { KEY_MICMUTE } },
Note that 0x21 is WMI_EVENT_WIN_KEY_LOCK in this driver's own enum.
Does your machine send 0x00002101 / 0x00012101 for the Win key lock? If
so, it would now report KEY_MICMUTE there.
[1] https://lore.kernel.org/all/20260531123345.237521-1-nika@nikableh.moe/
Thanks,
Anton Karasev
next prev parent reply other threads:[~2026-10-08 15:26 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-01 13:37 [PATCH v9 0/5] Merge redmi-wmi into bitland-mifs-wmi Mingyou Chen
2026-10-01 13:37 ` [PATCH v9 1/5] MAINTAINERS: Add maintainer entry of bitland-mifs-wmi driver Mingyou Chen
2026-10-01 13:37 ` [PATCH v9 2/5] platform/x86: bitland-mifs-wmi: Merge the function of redmi-wmi into the bitland driver Mingyou Chen
2026-10-08 15:26 ` Anton Karasev
2026-10-01 13:37 ` [PATCH v9 3/5] platform/x86: bitland-mifs-wmi: Add Redmi mic-mute key entries Mingyou Chen
2026-10-08 15:26 ` Anton Karasev [this message]
2026-10-01 13:37 ` [PATCH v9 4/5] platform/x86: redmi-wmi: Drop redmi-wmi driver Mingyou Chen
2026-10-01 13:37 ` [PATCH v9 5/5] platform/x86: bitland-mifs-wmi: Add per-machine ops table Mingyou Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261008152651.1510220-1-uselessfire@gmail.com \
--to=uselessfire@gmail.com \
--cc=W_Armin@gmx.de \
--cc=bozhenpeng93@gmail.com \
--cc=btx342@gmail.com \
--cc=chris@miget.com \
--cc=ericted8810@gmail.com \
--cc=hansg@kernel.org \
--cc=i@rsplwe.com \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=ilya.gladyshev@linux.dev \
--cc=kento@kekto.ru \
--cc=linux-kernel@vger.kernel.org \
--cc=matias.civadda2342001@gmail.com \
--cc=nika@nikableh.moe \
--cc=platform-driver-x86@vger.kernel.org \
--cc=qby140326@gmail.com \
--cc=vlku.milos.fun@gmail.com \
--cc=wleizc7319@gmail.com \
--cc=wolf109909@outlook.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®