From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj2-f11.google.com (mail-pj2-f11.google.com [74.125.227.139]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 79A613AAF5D for ; Thu, 8 Oct 2026 17:52:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.227.139 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791481970; cv=none; b=Tr0VJ2KKzd46gi5PUxSIvPWLOQDquV6HcoBZk8ie6RCokuTyDq87GHIzNfhkzDQRoZm5lH2bSmH/MODgncIZjMnkZOaloAqE11iwlupZmxSNxx0t67KMe5Kdt1VKIS0uH5kNhHY6jtu8/dBHHy1s8Rz4uULWBe29unNByPv0RsU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791481970; c=relaxed/simple; bh=prJ7nICdPY2rXNL3i/aciFMCMxkYdjelmYxtge20GFU=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version:Content-Type; b=l8QkHLU7vFkKXqpIxoWpqsK+VhrYT+HeF9yz+pCNgupiz9PuL0vW1nKVDUInjXAUk9nr0tZZaiU6/Op/CTEFlny9klmzQI34Z5SvAsPoEvU74+M4EjxF7phQbw6NxMWzHBylVxbnWpifoWiaRXZtUM2e2C576h+uAy9FZc2CWz0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=fPj1zzbQ; arc=none smtp.client-ip=74.125.227.139 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="fPj1zzbQ" Received: by mail-pj2-f11.google.com with SMTP id 98e67ed59e1d1-398a384b5f7so892733a91.0 for ; Thu, 08 Oct 2026 10:52:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1791481969; x=1792086769; darn=vger.kernel.org; h=content-transfer-encoding:content-type:mime-version:message-id:date :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to :content-type; bh=9BwFMzvpnh5keZRavPMezlpByqLkrvmuKFAvrVdTgl0=; b=fPj1zzbQGU/revicvYgvxZrVqpNK4xpcAMA0EfYibT3Bn5dA7yLXS+2v/qJmAjpQ3r bVUzEE7I0RUwh/63/mLee5th9aWC6hMLsDopUXUmiDj/7vRBDI8LKjci1X8n2tuNGPKT Oh4ue6+fU3c5G1iAwc83G5hJ7R5+ObEsC0G1wP4maltZfVikshi4gvL1YlrdBEN8nE+Q 5Fj3GyLtyaf5WyukAuQKV+ty82WRkrMXEYzGO24Esr2hbTZ2RRGyarhSI0HNg5c08+ce KEwi+c3bt5bLVgapL2RG71m7OjjGHiv4IKyaUHn9aPzKv0yzy2fH4US9H9bMAapzuzH5 q5fA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1791481969; x=1792086769; h=content-transfer-encoding:content-type:mime-version:message-id:date :subject:cc:to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to:content-type; bh=9BwFMzvpnh5keZRavPMezlpByqLkrvmuKFAvrVdTgl0=; b=yfLdE9tY54G84ezXSz+X9LHLGMHDcM1Py0GgsRcL+aF8gwQUBRWIdVlQJOOmYVQZK3 HaLWNjEf/6yWx8HpLlZ1WQdP2O1/rAiO5ubZptJ97mSB8Z4PIVbMozoD6REy7SYfWv6h BMUZvTs94xUTe8l/jiYx7YDzo2jbqP4pXbVu1piYRr0puk8+ESJ069GRUTXSaLuOzH8V cPdKAGvvDP7XbcnySEJl47Mbvp5anYIo3VsRgoRSp9DRK0NeeiNv0UR6i406J4ijKUxu B+JVVoFxHAZoxXCHCPjZko5+6Pydz9JkgCzvL8Z3G3vxOVtY4Px2tyN68UoqBS5fgaM0 L9Ew== X-Forwarded-Encrypted: i=1; AKwUvBxDC122ONjg8aOJfTkosmfKokxkCcEKekBM0HMaz/ED0le4k9uqGUzad+vlZcUrYCXznx3+PuwQC0DJOUI=@vger.kernel.org X-Gm-Message-State: AFq9FYJU18v+wAEfO1U7hBShpM+UVaYi0XSisahO/Ojip8hxiSfYhurC jrlImbUpU1Py/VVjj9yit7mHAbyMWJL13NLch2q/+RbjMgz8AvZ63gNI X-Gm-Gg: AYBFou3Pqc9hNwEOU5S6x5vHE+nlpaYPsTe/bQ/mqQnYri0+7a0TmhyhsU1tUBeH62J LXWGqfq6n31bBd7ZkS2+cs9qztwNx0Vla70I/wdz/PjkTxsois/7W7+NQEzl2r7HrXXsbZWTrS4 QYcSImRUGBNXsDVUytxiDZi+WD6IcdUMfzXvWQ3z5orPnCVqYnnZMpbU/3c2Gh2Y5Yva4uwbOVl 7gOGZDhxvWu3y527ryaZZc/JSaCiXewKT9SWi1TPyCBMBZNUZx+Q9TyMcqycn1dryhDHiupIo45 rnvf483F29ZZ8EbnWDYmo3kfDN6Cgv2FXG+vOa2hKpwz3Sn2Dkn1ugZ3S0q/a+GU3uCasGRufMM zeDiCfh+PzFk35WeLVg1PecIgKjAzQO30xYHpF8m64Lgpav8OJAGObHE+SsdNrAqlqjUNsGu2dc OWEzlXcgU6Cc2oVlvG3q5c06Dt669MrI/w03x9AFcztTBWRjHCHfJL5LBsZDmbTLd3PWL8 X-Received: by 2002:a17:90b:288c:b0:3a6:fec5:c186 with SMTP id 98e67ed59e1d1-3a8a0f3be3emr5184679a91.46.1791481968566; Thu, 08 Oct 2026 10:52:48 -0700 (PDT) Received: from server.lan ([168.138.199.194]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-3ab3277c459sm144332a91.16.2026.10.08.10.52.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 08 Oct 2026 10:52:48 -0700 (PDT) From: Coia Prant To: Jakub Kicinski , netdev@vger.kernel.org Cc: Andrew Lunn , "David S . Miller" , Eric Dumazet , Paolo Abeni , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Heiko Stuebner , Maxime Chevallier , Maxime Coquelin , Alexandre Torgue , Heiner Kallweit , Russell King , David Wu , linux-rockchip@lists.infradead.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Coia Prant Subject: [PATCH net-next v11 0/6] net: pcs: add basic support for RK3568 XPCS Date: Fri, 9 Oct 2026 01:51:54 +0800 Message-ID: <20261008175225.3375274-1-coiaprant@gmail.com> X-Mailer: git-send-email 2.47.3 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit This series adds proper SGMII support for the Rockchip RK3568 SoC using the integrated Synopsys DesignWare XPCS, along with necessary fixes and refactoring in the stmmac core and XPCS driver. Motivation ========== The RK3568 integrates a DW XPCS accessed via APB3 and connected to a Naneng Combo SerDes PHY. Several boards (e.g., Ariaboard Photonicat) use this interface for Gigabit Ethernet. However, the current upstream stmmac driver does not support this configuration, and the XPCS driver has issues in SGMII poll mode that cause the link to be reported incorrectly. This series addresses these issues by: - Adding ANRESTART support for SGMII link recovery - Adding a Rockchip XPCS platform glue driver and wiring it up in dwmac-rk Series overview =============== RK3568 XPCS/SGMII: Patch 1: add ANRESTART support for SGMII link recovery Patch 2: DT binding for Rockchip RK3568 XPCS Patch 3: implement the Rockchip XPCS platform glue driver Patch 4: DT binding for Rockchip DWMAC PCS Patch 5: wire up SGMII support in dwmac-rk Patch 6: update MAINTAINERS Dependencies ============ - Generic PM domain (genpd) changes: https://lore.kernel.org/all/20260925041751.495818-1-coiaprant@gmail.com/ - PHY binding+driver (Naneng Combo PHY SGMII MAC selection): https://lore.kernel.org/all/20261006162807.2843858-1-coiaprant@gmail.com/ - stmmac XPCS lifetime management fix: https://lore.kernel.org/all/20261005221749.1104430-1-coiaprant@gmail.com/ The DTS changes using the PHY property are sent separately to Heiko/linux-rockchip. There is no hard build dependency; the pieces can converge during the merge window. Changelog ========= Changes since v10: - XPCS binding: drop the ethernet-pcs-mii child nodes and the phy-names property. The MII port used by SGMII is derived from the MAC it is routed to (GMAC0 -> port 0, GMAC1 -> port 1), so the ports do not need to be described. - dwmac binding: require phy-mode for rockchip,rk3568-gmac, and require pcs-handle only when phy-mode is "sgmii". Without the explicit required: [ phy-mode ], the "if" would match even when phy-mode is absent (Rob). - XPCS glue driver: use pdev->dev.links.status instead of link->supplier->links.status, and drop the unused reg argument from the read remapping helper. - dwmac-rk: document that the MII port passed to xpcs_rk_create() is the GMAC id, matching the hardware routing. Rewrite the in-band vs out-of-band section of the commit message to match the driver behavior and the actual clock rates. - DTS: drop the ethernet-pcs-mii sub-nodes; pcs-handle now points at the XPCS node itself. - Commit messages updated. Key design decisions ==================== - The stmmac core now delegates XPCS creation entirely to platform drivers via pcs_init/pcs_exit. This is necessary because the generic XPCS creation logic would override any XPCS set up by the platform driver. - The Rockchip XPCS driver creates a virtual MDIO bus over the APB3 registers and implements address remapping. The generic XPCS core handles all PCS configuration via phylink_pcs_ops. - On RK3568 in SGMII mode, the MAC clock is fixed at 125 MHz and cannot be dynamically changed. In-band mode is used, and the generic stmmac set_clk_tx_rate callback is disabled to prevent incorrect clock updates that would break RX. - The SerDes and power domain are attached to the XPCS device tree node rather than the MAC node. This reflects the actual hardware topology and simplifies the dwmac-rk driver by keeping all PCS-related resources self-contained. It also prepares for possible future QSGMII support, where a single SerDes serves multiple MACs and would be more naturally managed under the XPCS node. Testing ======= Board: Ariaboard Photonicat (RK3568) OS: Armbian (trixie) Kernel: 6.18 (backports) Result: The SGMII interface obtains an IP address, SSH works, and ping traffic passes without loss. Notes ===== - When testing out-band mode with set_clk_tx_rate, only 1000Mbps works on both TX/RX; 10/100Mbps only works on TX side. Acknowledgments =============== This work was inspired by and builds upon the excellent work of others: - Serge Semin's Synopsys DesignWare XPCS platform driver (pcs-xpcs-plat.c) - Clément Léger's Renesas MIIC driver (pcs-rzn1-miic.c) - The Rockchip TRM and downstream OEM drivers Thanks in advance, Coia Prant --- Coia Prant (6): net: pcs: xpcs: add ANRESTART support for SGMII link recovery dt-bindings: net: pcs: add rockchip,rk3568-xpcs support net: pcs: xpcs: add Rockchip RK3568 platform glue driver dt-bindings: net: rockchip-dwmac: document pcs-handle net: stmmac: dwmac-rk: add SGMII support for RK3568 MAINTAINERS: add entry for Rockchip XPCS driver .../net/pcs/rockchip,rk3568-xpcs.yaml | 69 ++ .../bindings/net/rockchip-dwmac.yaml | 27 + MAINTAINERS | 9 + drivers/net/ethernet/stmicro/stmmac/Kconfig | 1 + .../net/ethernet/stmicro/stmmac/dwmac-rk.c | 131 +++- drivers/net/pcs/Kconfig | 25 + drivers/net/pcs/Makefile | 5 +- drivers/net/pcs/pcs-xpcs-rk.c | 598 ++++++++++++++++++ drivers/net/pcs/pcs-xpcs.c | 35 +- include/linux/pcs/pcs-xpcs-rk.h | 11 + 10 files changed, 883 insertions(+), 28 deletions(-) create mode 100644 Documentation/devicetree/bindings/net/pcs/rockchip,rk3568-xpcs.yaml create mode 100644 drivers/net/pcs/pcs-xpcs-rk.c create mode 100644 include/linux/pcs/pcs-xpcs-rk.h -- 2.47.3