From: Heiko Carstens <hca@linux.ibm.com>
To: Gerald Schaefer <gerald.schaefer@linux.ibm.com>
Cc: Alexander Gordeev <agordeev@linux.ibm.com>,
Sven Schnelle <svens@linux.ibm.com>,
Vasily Gorbik <gor@linux.ibm.com>,
Christian Borntraeger <borntraeger@linux.ibm.com>,
linux-kernel@vger.kernel.org, linux-s390@vger.kernel.org
Subject: Re: [PATCH v2 1/2] s390/appldata: Emulate virtual timer with delayed work
Date: Thu, 8 Oct 2026 19:52:50 +0200 [thread overview]
Message-ID: <20261008175250.13419A96-hca@linux.ibm.com> (raw)
In-Reply-To: <20261008190827.1b9762c0@thinkpad-T15>
On Thu, Oct 08, 2026 at 07:08:27PM +0200, Gerald Schaefer wrote:
> On Tue, 6 Oct 2026 16:01:12 +0200
> Heiko Carstens <hca@linux.ibm.com> wrote:
>
> > Emulate the virtual timer in appldata using delayed work: the work is
> > scheduled for the minimum possible wall-clock time until the
> > configured CPU-time interval elapses (remaining CPU time / number of
> > online CPUs), with a minimum delay of 100ms. The work then reads
> > per-CPU statistics of all online CPUs to check whether enough CPU time
> > has elapsed, and if so runs the registered callbacks.
> >
> > This is slightly more expensive, but allows to subsequently remove the
> > entire vtimer infrastructure.
> >
> > Signed-off-by: Heiko Carstens <hca@linux.ibm.com>
> > ---
> > arch/s390/appldata/appldata_base.c | 171 ++++++++++++++++++-----------
> > 1 file changed, 107 insertions(+), 64 deletions(-)
>
> Nice improvement, with minimum wall-clock interval 100ms. Specifying a 1ms
> CPU-time interval was possible, but did not make much sense in practice.
> On very idle systems, the resulting wall-clock interval would also have
> been around 100ms, but as soon as they do some work, it would have become
> far too frequent.
>
> Also tested it, and on a busy system there is now no noticeable difference
> for interval values 1-100, while idle systems still behave like before.
>
> Reviewed-by: Gerald Schaefer <gerald.schaefer@linux.ibm.com>
> Tested-by: Gerald Schaefer <gerald.schaefer@linux.ibm.com>
Thanks a lot! Applied :)
next prev parent reply other threads:[~2026-10-08 17:52 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-06 14:01 [PATCH v2 0/2] s390: Remove vtimer infrastructure Heiko Carstens
2026-10-06 14:01 ` [PATCH v2 1/2] s390/appldata: Emulate virtual timer with delayed work Heiko Carstens
2026-10-08 17:08 ` Gerald Schaefer
2026-10-08 17:52 ` Heiko Carstens [this message]
2026-10-06 14:01 ` [PATCH v2 2/2] s390/vtime: Remove vtimer infrastructure Heiko Carstens
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261008175250.13419A96-hca@linux.ibm.com \
--to=hca@linux.ibm.com \
--cc=agordeev@linux.ibm.com \
--cc=borntraeger@linux.ibm.com \
--cc=gerald.schaefer@linux.ibm.com \
--cc=gor@linux.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=svens@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®