mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Haotian Zhang <vulab@iscas.ac.cn>
To: Stephen Boyd <sboyd@kernel.org>,
	Brian Masney <bmasney+clk@redhat.com>,
	Jerome Brunet <jbrunet+clk@baylibre.com>
Cc: linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH] clk: composite: fix NULL dereference when the parent clock is not set
Date: Fri,  9 Oct 2026 02:06:52 +0800	[thread overview]
Message-ID: <20261008180652.2756849-1-vulab@iscas.ac.cn> (raw)

clk_composite_determine_rate() reads the parent clock with
clk_hw_get_parent() and hands it to
clk_composite_determine_rate_for_parent() without checking it.
clk_hw_get_parent() returns NULL when the clock has no parent yet, for
example while the parent is still an orphan, and the helper dereferences
that NULL pointer in clk_hw_get_rate(), which reads parent_hw->core and
oopses the kernel.

Return -EINVAL when the parent clock is NULL.

Fixes: 2f508a955a67 ("clk: Convert basic types to clk_hw based provider APIs")
Assisted-by: DeepSeek-V4.1-Flash
Signed-off-by: Haotian Zhang <vulab@iscas.ac.cn>
---
 drivers/clk/clk-composite.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/clk/clk-composite.c b/drivers/clk/clk-composite.c
index 11842bce5918..40d64ef2d325 100644
--- a/drivers/clk/clk-composite.c
+++ b/drivers/clk/clk-composite.c
@@ -75,6 +75,8 @@ static int clk_composite_determine_rate(struct clk_hw *hw,
 			struct clk_rate_request tmp_req;
 
 			parent = clk_hw_get_parent(mux_hw);
+			if (!parent)
+				return -EINVAL;
 
 			clk_hw_forward_rate_request(hw, req, parent, &tmp_req, req->rate);
 			ret = clk_composite_determine_rate_for_parent(rate_hw,
-- 
2.25.1


             reply	other threads:[~2026-10-08 18:06 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-08 18:06 Haotian Zhang [this message]
2026-10-09  6:10 ` Krzysztof Kozlowski
2026-11-02 15:38 ` Jerome Brunet

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261008180652.2756849-1-vulab@iscas.ac.cn \
    --to=vulab@iscas.ac.cn \
    --cc=bmasney+clk@redhat.com \
    --cc=jbrunet+clk@baylibre.com \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sboyd@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®