From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-00364e01.pphosted.com (mx0a-00364e01.pphosted.com [148.163.135.74]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2EB3246EF71 for ; Fri, 9 Oct 2026 16:50:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=148.163.135.74 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791564633; cv=none; b=StmrMDtD2bZl0ipHaekytGEZPwBF8pmhsL42mK683WxFopMCUJt5ouaxkd1F2IBtsd/ZSAZ1X64gepX9v8lqgLw3e9C6OkvUKzgVm4a+byuPVpapBbuvgCE/JxTBYXUjABitNXiNgJNkIdIhVQuLXtBnwvvwqLFnpptlJDdSZfs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791564633; c=relaxed/simple; bh=TjEmrIwoDfGD/tJl+VVnQl6XHOIQk68grd/DlzMzZsM=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=JeQobDUPk5gaiNkzFk/CNa8f7hYW88+glvrRMNejQbQzlP/Y6cm6aaHCaPq5QqfUZFsovwVoOAZIYr/ub/WE0rj1FooIucsu3a7TZNp/4hhL3AgCVJXpFflwyAxYEQOro2jVvtE3zLziiMdaNLFvG4N5lpIGa8PKr8nGfg5+yHY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=columbia.edu; spf=pass smtp.mailfrom=columbia.edu; dkim=pass (2048-bit key) header.d=columbia.edu header.i=@columbia.edu header.b=KjFOJMlh; dkim=pass (2048-bit key) header.d=columbia.edu header.i=@columbia.edu header.b=CGM4Tlkx; arc=none smtp.client-ip=148.163.135.74 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=columbia.edu Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=columbia.edu Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=columbia.edu header.i=@columbia.edu header.b="KjFOJMlh"; dkim=pass (2048-bit key) header.d=columbia.edu header.i=@columbia.edu header.b="CGM4Tlkx" Received: from pps.filterd (m0499199.ppops.net [127.0.0.1]) by mx0a-00364e01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 699GZiLZ4092268 for ; Fri, 9 Oct 2026 12:50:31 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=columbia.edu; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=pps01; bh=YGcz I1vSHasliXD66Zjo2T9yKyc6ElYvYCgnRIuVKQY=; b=KjFOJMlhN1+3lGbf0LpR No0/4aMtdq6WbA9PKdTRS6CMrn4lWqPrvC1gWTjcPwgDef0/tKi+mSIaD2u6FKBk T77LqQcgz4L4VAoTaN+/A5QzTj9LiSAhoPFNAqfc20Rl17rRJKt/UzSkJOkpCBCx EMza0toduGjnEt+5u2FLIf8zuRmUgBaziKPWyIKnb9uuFmV0UavqGGtwnnqJyrOm DVyAzCGblDPduVqjQNzmnyhIIo+t/F33HJtPdv9ifFMzW+tLcEiJJQvMUsK4XQXw vIRGcd9Ka/4v+2JBYuc7nEOS68OxSRaQ/B3XzVOE0Vfo82ov9jp7HmcNOYpnDXoF 4w== Received: from mail-qt1-f197.google.com (mail-qt1-f197.google.com [209.85.160.197]) by mx0a-00364e01.pphosted.com (PPS) with ESMTPS id 4h6qgavh8g-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 09 Oct 2026 12:50:31 -0400 (EDT) Received: by mail-qt1-f197.google.com with SMTP id d75a77b69052e-532dc3793easo45272551cf.0 for ; Fri, 09 Oct 2026 09:50:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=columbia.edu; s=lionmail; t=1791564630; x=1792169430; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=YGczI1vSHasliXD66Zjo2T9yKyc6ElYvYCgnRIuVKQY=; b=CGM4Tlkx2j9os9joEuyGTQXgvVrYq+mU6PiOkIAOWt/YTk4w9amjaoUHmFj6TC2zlP ohYem+p7w1Ju3WJoAUPjZAcijzgRAQiLez0//kOwBFKd8gISJAfons9PWlt8o+qPYFYa Fi+5UyW30YQZi0qMEEaQeoaMyG/eZ+pBAT6JZL1LP646c7rmNSAu+VOOZ4/8TbUvX9VL l4ByKCTO5JFbwglm0eqgsXfpa3FWYhMPdQE3AgnHyIp7A0/tt5n+Qt475Es9MLgUfTHD F/tHpIIWotmK+/UteUhL8qw9UmPfkNt9CiXye0+kjaZt06zYmLVHlQDs9yNni0ghjK2g m4Bw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1791564630; x=1792169430; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=YGczI1vSHasliXD66Zjo2T9yKyc6ElYvYCgnRIuVKQY=; b=TDHaE8ir7uFqksBp1/xTCPyGUEraLDgworFkaA7KncvbdjWcblX34Rn0IGtr9T80dh YR274AS0mAzNtycfdxQqA3ECqvZ07wnhBTbRG5ssUs3+C+Nj/U8JCcCljt86T0tswv6r awagk43V72xDecx171+z4SNWuyt7m4hv5c5/jkSBrZMvs+2JA6TdsG1jD1sRaYyVujNB NCr2Cggvv0FUud3IOWPMqWQoWQfPnzpyXhnGhFMtILNYdQ6YDxQXHMTzy8bJH2h3bzyz mYE/+cgdkMcuyJMm7QL0KPZwTWD/k3KW9qtBfca2eP16FbZFjBorArGZtfhSEjBw5yyt PozQ== X-Forwarded-Encrypted: i=1; AKwUvBzbSL5Ek/DkHvf2cw1nRV3T/iP/9blYzKTSNRx7yPVcNlvuSnKdVK9JA1l8thinev+/Y3xvTmIolVCfRKs=@vger.kernel.org X-Gm-Message-State: AFuF++lt9m77eU0c9ASrF/EQoAbcHzQiyto+63sstNOBwQZylVVkQUsu h3K7zZobn7/IHAHihRIY+NV8ZL23fbBavkzA2CAeGjjO7GeK05aV6/MfwbnWAVy/auYiowrECVE pjWU8x5ElDnaU/V5udW95QfTS/S6iTWW8FdypeJTpy4HrHkQvu4Djlh7mLaOVcQ== X-Gm-Gg: AYBFou28u1rfIev1kzWuGt5CgQZZNjeELaDT8IMT1g9WbDX3L6ioU/uMl4SZ4iXS6hi SYM6ExtG9XuhhArl0J81MJ5BJODkY5Kaacrf0Xyagms0C0BxzmjW1SJpT6KJbpOpg7I7vKiB1IC iaUcxnZTPmFYTUthOg25mivC0Yd+hBvZktvAHD2++ZJ81MOGMuipt7KZkwFLM1dXx1skW/JQhnY UA99+gATbDA9sQekTYKm0KL9FH2RpEqn3py8sb6RDIkgqqbxCHUpRYZ+OTstippKcOmYpKQ1q/I LmLc1mtpGSP6p106yUECtMd9EjgpjCUXsJQo7VGtk4QFsFKNod6RGtF2onpSf+xAy8+hZuLwsFE mk3pEFNnvuFcf9V//siAqdSwfzwo5jSjDDutC+YrvtWPTtIA= X-Received: by 2002:a05:622a:1b03:b0:533:3274:60c with SMTP id d75a77b69052e-5359dd26620mr40806001cf.29.1791564630456; Fri, 09 Oct 2026 09:50:30 -0700 (PDT) X-Received: by 2002:a05:622a:1b03:b0:533:3274:60c with SMTP id d75a77b69052e-5359dd26620mr40805501cf.29.1791564629868; Fri, 09 Oct 2026 09:50:29 -0700 (PDT) Received: from [127.0.1.1] (nat-128-59-178-194.net.columbia.edu. [128.59.178.194]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-5359b77d0eesm22234701cf.19.2026.10.09.09.50.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 09 Oct 2026 09:50:29 -0700 (PDT) From: Tal Zussman Date: Fri, 09 Oct 2026 12:50:17 -0400 Subject: [PATCH v6 9/9] block: remove dead metadata handling from the async direct I/O path Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20261009-blkdev-fixes-v6-9-307939c387df@columbia.edu> References: <20261009-blkdev-fixes-v6-0-307939c387df@columbia.edu> In-Reply-To: <20261009-blkdev-fixes-v6-0-307939c387df@columbia.edu> To: Jens Axboe , Christoph Hellwig , Johannes Thumshirn , Luis Chamberlain , Hannes Reinecke , "Matthew Wilcox (Oracle)" , John Garry , Christian Brauner , "Darrick J. Wong" , Keith Busch , "Martin K. Petersen" Cc: Shin'ichiro Kawasaki , linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org, Tal Zussman X-Mailer: b4 0.17-dev X-Developer-Signature: v=1; a=ed25519-sha256; t=1791564615; l=1396; i=tz2294@columbia.edu; s=20250528; h=from:subject:message-id; bh=TjEmrIwoDfGD/tJl+VVnQl6XHOIQk68grd/DlzMzZsM=; b=kyR/6+0uUpySOm5+kLC7PnMLFfMvdbxJB3gn4ywQjE3A653IQAONvgDLa5uwCFOb8cb81Gxki mgjkL5Zh7XwBFha5mPhJAYuM10mgmerANhTN+Si/GE2JLVdD1jnvnyH X-Developer-Key: i=tz2294@columbia.edu; a=ed25519; pk=BIj5KdACscEOyAC0oIkeZqLB3L94fzBnDccEooxeM5Y= X-Proofpoint-Spam-Info: AW1haW4tMjYxMDA5MDA2NyBTYWx0ZWRfX8PhvyvP/tHpW FaTzXYFfT9gEhlwtaS68E1oFDuL1tkcp+juBpP1gZndDyZt4AKq9uWgfncIpqTXreKY6ancBQl6 u9+FYPYudkIVazXP3fjTszadQ9igS+s2okZiEOMPi9SyBpp73d5U X-Authority-Analysis: v=2.4 cv=WLHqzXsR c=1 sm=1 tr=0 ts=6ac91b57 cx=c_pps a=EVbN6Ke/fEF3bsl7X48z0g==:117 a=u0MKzLA9JmpizDwXU9Rxjg==:17 a=IkcTkHD0fZMA:10 a=660iZSQnnn4A:10 a=x7bEGLp0ZPQA:10 a=A0y_DWxS2BwA:10 a=VkNPw1HP01LnGYTKEx00:22 a=Da8U98TiO7q1upZEImrf:22 a=G--0XuH5328wxK7v7Suf:22 a=VwQbUJbxAAAA:8 a=-GSYpVTsbc7fiOcD5ogA:9 a=QEXdDO2ut3YA:10 a=a_PwQJl-kcHnX1M80qC6:22 X-Proofpoint-GUID: DQ61RbbZeZAuOiPHQ4HwvWw0ox82HmVx X-Proofpoint-ORIG-GUID: DQ61RbbZeZAuOiPHQ4HwvWw0ox82HmVx X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYxMDA5MDA2NyBTYWx0ZWRfX42gkpgcddGE3 MfLCQMmkkYAfsbUcsOpIp1x92fd2NBcfl23SZORV1GZR4B745R7Lc+8kXqkkkYdtaFe5ZWrPFJn iIZFm1aoQ3QaN7Z73dp5iei0upZTBLnWRnkh/Oo0Tb/F8/NnJYkuQb6QJCQ95Jc2CS+nNCpBx3B ShoI4kVgfHsmDjs1y5tiFOG4X4zkWcrpKxRJiT59QHycKIHDQlRO9E1IATCUel8P4kBJSNW6ZR+ BaE0R53sX7+DIHQEwbzQjs5vMgrSQoWJhLunjGkoAyojtmPiefKuR+UsmMLJiEbe95Qh/SQ6e76 pK37ckHkwDJbUdbmYueyq7chOMutRkEh4v6it9md5T06255jUVy1F88/noif/dmDrcfL3TkViL9 hd8BRoUmJRqgTtLG3eMFsTyipuWs1GBBVfsXbkB16KfNiiOC6kA4T/TSH2OsHZm+DmfMH2kF7MD p0/NDDzsSexHw5IuIeA== X-Proofpoint-Virus-Version: vendor=nai engine=6900 definitions=11930 signatures=596817 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 clxscore=1015 malwarescore=0 spamscore=0 bulkscore=10 lowpriorityscore=10 priorityscore=1501 impostorscore=10 phishscore=0 adultscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2610020000 definitions=main-2610090067 Since commit 2729a60bbfb9 ("block: don't silently ignore metadata for sync read/write"), blkdev_direct_IO() sends every IOCB_HAS_METADATA request to __blkdev_direct_IO(). Remove the now unreachable metadata mapping in __blkdev_direct_IO_async() and the unmap in its completion handler. No functional change. Assisted-by: Claude:claude-fable-5 Reviewed-by: Christoph Hellwig Reviewed-by: Hannes Reinecke Signed-off-by: Tal Zussman --- block/fops.c | 10 ---------- 1 file changed, 10 deletions(-) diff --git a/block/fops.c b/block/fops.c index 41fa0c663f77..f3ff4e62413b 100644 --- a/block/fops.c +++ b/block/fops.c @@ -321,9 +321,6 @@ static void blkdev_bio_end_io_async(struct bio *bio) ret = blk_status_to_errno(bio->bi_status); } - if (bio_integrity(bio)) - bio_integrity_unmap_user(bio); - iocb->ki_complete(iocb, ret); if (dio->flags & DIO_SHOULD_DIRTY) { @@ -385,13 +382,6 @@ static ssize_t __blkdev_direct_IO_async(struct kiocb *iocb, task_io_account_write(bio->bi_iter.bi_size); } - if (iocb->ki_flags & IOCB_HAS_METADATA) { - ret = bio_integrity_map_iter(bio, iocb->private); - WRITE_ONCE(iocb->private, NULL); - if (unlikely(ret)) - goto out_bio_put; - } - if (iocb->ki_flags & IOCB_HIPRI) { bio->bi_opf |= REQ_POLLED; submit_bio(bio); -- 2.39.5