mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Ricardo B. Marlière (SUSE)" <ricardo@marliere.net>
To: Steven Rostedt <rostedt@goodmis.org>,
	 John Hawley <warthog9@eaglescrag.net>
Cc: linux-kernel@vger.kernel.org,
	"Ricardo B. Marlière (SUSE)" <ricardo@marliere.net>
Subject: [PATCH] ktest: Accept quoted bad term in git bisect output
Date: Fri, 09 Oct 2026 22:13:23 -0300	[thread overview]
Message-ID: <20261009-ktest-git-bisect-v1-1-1d1428f6cbf4@marliere.net> (raw)

Git commit 0c0f93e7fa64 ("bisect: print bisect terms in single quotes")
changed the completion message to put single quotes around the bisect term.
run_git_bisect() only recognizes "is the first bad commit", so it misses
completion and continues the bisect loop with newer Git.

Accept both quoted and unquoted forms to retain compatibility with older
Git versions.

Link: https://git.kernel.org/pub/scm/git/git.git/commit/?id=0c0f93e7fa645c1058226a9bfde9e2b4441edf96
Assisted-by: LLM
Signed-off-by: Ricardo B. Marlière (SUSE) <ricardo@marliere.net>
---
 tools/testing/ktest/ktest.pl | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/testing/ktest/ktest.pl b/tools/testing/ktest/ktest.pl
index f94ed2e98887..9d63a1dcdb3e 100755
--- a/tools/testing/ktest/ktest.pl
+++ b/tools/testing/ktest/ktest.pl
@@ -3019,7 +3019,7 @@ sub run_git_bisect {
     doprint "SUCCESS\n";
     if ($output =~ m/^(Bisecting: .*\(roughly \d+ steps?\))\s+\[([[:xdigit:]]+)\]/) {
 	doprint "$1 [$2]\n";
-    } elsif ($output =~ m/^([[:xdigit:]]+) is the first bad commit/) {
+    } elsif ($output =~ m/^([[:xdigit:]]+) is the first (?:bad|'bad') commit/) {
 	$bisect_bad_commit = $1;
 	doprint "Found bad commit... $1\n";
 	return 0;

---
base-commit: af32da41b0327b9c6a37856ba82b6760d6c8d10e
change-id: 20261009-ktest-git-bisect-a894f472843e

Best regards,
--  
Ricardo B. Marlière (SUSE) <ricardo@marliere.net>


             reply	other threads:[~2026-10-10  1:13 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-10  1:13 Ricardo B. Marlière (SUSE) [this message]
2026-10-20 18:02 ` Steven Rostedt
2026-10-20 18:17 ` Steven Rostedt
2026-10-20 19:29   ` Ricardo B. Marlière (SUSE)
2026-10-20 19:34     ` Steven Rostedt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261009-ktest-git-bisect-v1-1-1d1428f6cbf4@marliere.net \
    --to=ricardo@marliere.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rostedt@goodmis.org \
    --cc=warthog9@eaglescrag.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®