From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B3E623D092F for ; Fri, 9 Oct 2026 04:50:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791521438; cv=none; b=IQxbV8bx0e4x3ODp9Qzsak+WY8ps2Z/nposKY0gBmTFBO3a38CHRdvrhcvCDA9FJXebeR8Qplj9IcFlvhP8awUsSEu66jPWYZseQ+3R87sCQH5iFv3/Js8GYzdUK7Nz5PmBadOQbM0eUEU0g+ZLYGCuH383vquBSf2XZx1DT4Fs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791521438; c=relaxed/simple; bh=Swbffk7gSaWY0Wx8h7GWibLTdR+plzDCp23uNbU2Mss=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=pAfkT4M73kg14nI7Wm6UhKePM2lA/rbcw7AGN5qdjZZiUkG+ZVnIUWZyqM19qPDPOhwkVXyiTwjf0YP01vV6YRapzGtseq05myico/E1Si3Echeo068o85Zgy/C1M7y5bQ4dIlFksP+EyUaTH2Gq8Uvj/yLx4C4OJxk3JumuVDU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=kP0nvFZC; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=a7hfbsmz; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="kP0nvFZC"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="a7hfbsmz" Received: from pps.filterd (m0279865.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 6993HAaa1598043 for ; Fri, 9 Oct 2026 04:50:36 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= qUVEH4qPe/WvTV01E7edf1dmd38bUwh693Oze6d4mZM=; b=kP0nvFZCcq/POuD5 B36ovih/5KeWFVqfYzFKvk4wMHHiqs0cpla4FQ5oXsPWRyj6mMg1dBs/GQw4JsI1 V48td2D7LEIE6GjLTaxHumkY/GV2W4o6P4Duavi7/uhCalyDyV6P5PfJBPq91jFL 9FTlzqa+i3rhaZYINIGztrTB5qJIct+v+dku14JojW2a9ihJJ8MhFITSbNgM0VXB gms/ohg137/Dg7DZZvbPEHeN1/2Hx2N5aITNmiDe+xeLmpyeRq+KTXcJJros2TWr 2BQajE1Sz56trN3cBjSmUlM7tQYH0mAQLZR+I4WGHAHTx5SgGi+VDhi3C/Ft5Lx6 OT0grg== Received: from mail-dl1-f72.google.com (mail-dl1-f72.google.com [74.125.82.72]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4h6nufrqqx-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 09 Oct 2026 04:50:35 +0000 (GMT) Received: by mail-dl1-f72.google.com with SMTP id a92af1059eb24-168a8884006so967962c88.0 for ; Thu, 08 Oct 2026 21:50:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1791521435; x=1792126235; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=qUVEH4qPe/WvTV01E7edf1dmd38bUwh693Oze6d4mZM=; b=a7hfbsmztKLPqv4th00Ruk/Ksdvzllv/uBp+eFbXeVfvO8P0LPtOhsGq8uzED+is4g r3J9eFNSCy13nJGMSd13uQMEJOKS42acXTmhq5S44vqg9fK9Sb70naBbX3UR95ervND/ UT1m+gqP2mfIKKYMhlcr4xqvAltcHNkPd4T4Mr5wqJTJIiTs/uoxIoVbz6uRMdUrdGwr oddk8C6D7opZJoyp9h9zrUptrwLEwRv04vAECIJgMyiHUs1PjfNG4VaAJHiN3kJwNoKY lcnaToc0qfogE3MDYJKWKsUOmaLsSLcPx7E2B7KDHDnXE1ZLQFnAB8a3SssESUBWX4J3 n3rw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1791521435; x=1792126235; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :content-type:mime-version:subject:date:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=qUVEH4qPe/WvTV01E7edf1dmd38bUwh693Oze6d4mZM=; b=RMOtQA1JYHB+UDByn3MVaurokd1hxK3yVfD78x636Nb6Tk361V9e2papR4nEFSNg6X l7zXWRJIyHgrSx5a/dYE9mZoBKr0a9e287yjIoXAE7tCGXQ2Q9mWkjQer1s5JSdEE4Hj Nfn63VJQ1VirLL0j5gYtHbnty1b0JmC3rFYiJ0n4UNTOScKPl1mNssCbCgUXhKDb5SfR qI+Ig1Jo8ZkGUNfPgbirRh4elP8U2Re0pYRyr+rh4afYICHG1dr864mEHf+E2YY2WQD1 ux3UHlqOdhX49JGysTZp/ghreZOVyR4ncoFSKRmtoseDT5ZDhWhMvm6GpL1zYNUAizHG KExw== X-Forwarded-Encrypted: i=1; AKwUvBxQl1zraKMzpGDe+L5SBrPNn1MuZDLx+k+c50B/Pelz8hyWC63PQm4WujjQuSsuJPbItVanceBljA7Mymg=@vger.kernel.org X-Gm-Message-State: AFuF++npt7r/mWm6p4tSp4qUNPnQJe3n1C2n8FCzPqJPUdQtWaLrdTh5 m5Qe1TBBtrRldhnFrfBhTyIbjywiJfwm95DI1kBX/5Yt4UoOCSu9tV+SrDTBKEBfDL5xko2KNla /tAkEqQpz2HqtEgNlOwFw5RjS92lK3zGklV0zhJUPgu9CegTTI1C/Tbqe+l5PHSGhiCqKVBiiG8 I= X-Gm-Gg: AYBFou3shbP745SbyVB7quT4qHxtBpoZKudLQK/3dOu68N4acJxgvPDJti3y7R7BUTW qmy/fnig3Jwp0DuePAPmV1rTNJH3STuKcnmRKuT+3Wvn+yCP0VXUgbKlIOi6TudSffcuhyWjXjn qPIXnLUdwDq94fYJIS1IP6y1IjpVe68ske4u1LJeQMqUMAJhg9bkUnS/5+wAJztW9IE2WKeGB1s 7UbyVpXQxMNmNfRBNL2oa+bsHCJHPVMSbeWvrxqa8xVXR4GvsaCMxhQ23odNJF6B8F9EkpxRWP8 wEp410ezr6OZtt7gjmSzNSWQ8TLcq88RBV4Cosuhz32eTYZWHhUjUZHflxVHKucBCGXwtq3+Sef y4DLaQeqntG0Rgbd6exPyBN/Z+lca9O/H0VHl9cbgM561qdUfXe0elXBeLmWaHdujQEqOdpvmAq DEOKETdPldfiDnXii+V/T60czbr1ySBw== X-Received: by 2002:a05:701b:4518:20b0:163:d97f:96f3 with SMTP id a92af1059eb24-16a55481281mr929352c88.4.1791521434992; Thu, 08 Oct 2026 21:50:34 -0700 (PDT) X-Received: by 2002:a05:701b:4518:20b0:163:d97f:96f3 with SMTP id a92af1059eb24-16a55481281mr929330c88.4.1791521434444; Thu, 08 Oct 2026 21:50:34 -0700 (PDT) Received: from hu-varada-blr.qualcomm.com (blr-bdr-fw-01_GlobalNAT_AllZones-Outside.qualcomm.com. [103.229.18.19]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-169a442956asm4151609c88.16.2026.10.08.21.50.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 08 Oct 2026 21:50:34 -0700 (PDT) From: Varadarajan Narayanan Date: Fri, 09 Oct 2026 10:19:59 +0530 Subject: [PATCH v6 5/6] phy: qcom: snps-femto-v2: Move PHY init registers to config tables Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20261009-phy-v6-5-50408e45bcc1@oss.qualcomm.com> References: <20261009-phy-v6-0-50408e45bcc1@oss.qualcomm.com> In-Reply-To: <20261009-phy-v6-0-50408e45bcc1@oss.qualcomm.com> To: Vinod Koul , Neil Armstrong , Manivannan Sadhasivam , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Wesley Cheng , Manu Gautam , Stephen Boyd , Philipp Zabel Cc: linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Varadarajan Narayanan X-Mailer: b4 0.14.3 X-Authority-Analysis: v=2.4 cv=afn0Dhot c=1 sm=1 tr=0 ts=6ac8729b cx=c_pps a=bS7HVuBVfinNPG3f6cIo3Q==:117 a=Ou0eQOY4+eZoSc0qltEV5Q==:17 a=IkcTkHD0fZMA:10 a=660iZSQnnn4A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=Um2Pa8k9VHT-vaBCBUpS:22 a=EUspDBNiAAAA:8 a=dpbSYRCFOxhwq305YcMA:9 a=QEXdDO2ut3YA:10 a=vBUdepa8ALXHeOFLBtFW:22 X-Proofpoint-Spam-Info: AW1haW4tMjYxMDA5MDAxOSBTYWx0ZWRfX5YoF5govRLOb nSSzSwhkZgJWbtBDWk8HGkAgNFbc8texKWjPFJupYJW2qE6s5rK6uB5/R612rfQaBuoOMdhjOiA g7VtTWRIAgUYWF84zzLI15LfO84SVTc= X-Proofpoint-GUID: 9FCsdXIJqenDhGFmxzxTfexM-8ESSkjx X-Proofpoint-ORIG-GUID: 9FCsdXIJqenDhGFmxzxTfexM-8ESSkjx X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYxMDA5MDAxOSBTYWx0ZWRfX6tD0s4pEFvmL n7IJyZHHhHFk2TT6r/tnktUUALLFHob/S6BmnOCfX7dX5x+DZgkgHBjJ2np6GiuR6QWHO8qbifw 8sfSSKH3fLbB+pal5Z/NM3yOQtVWmohOVglP/pg+uws+uvS8TSoS6aQKStQY0AEoeOWNd1qD7fN YgKFUE+qQh13udzPeiD98gEUebKpfx8VPoo67/SHKDJmEvDK9t0aLqPa211MkeapBBPZOZbWRCi /O8gnZfBVWMEe4GLKI2yFcEEefuMB15uqiS2uqK47gAFv9t3yAnqT/KG4KANcjrL8mDAG18oaem Mf0YM0x/j5XwbSlfE2SybiPMlVVx46W7iBBNpF/39Kn4UH20jrXJPvAvCuwq2uuop6V80R/KRBC eQYiu9fqjdHMyiuWXhQiDZVdlYcvZ3tXccNbeMZKOK8wZhaLDigDOhxPhSJfV89YRGYXiPK2SS4 WIFpvAJ0WCgFybPhzTQ== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-10-09_02,2026-10-08_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 adultscore=0 suspectscore=0 impostorscore=0 bulkscore=0 phishscore=0 clxscore=1015 priorityscore=1501 spamscore=0 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2610020000 definitions=main-2610090019 The driver currently programs the common PHY register sequence directly in qcom_snps_hsphy_init(), with the fixed register writes split around the override parameter handling. This makes it hard to support SoCs that need a different sequence or different values. Move the fixed pre- and post-override register programming into per- compatible configuration tables, and keep the 7 nm override parameters in the same match-data structure. This allows the driver to share the common sequence while adding SoC-specific sequences for future platforms such as IPQ9650. Signed-off-by: Varadarajan Narayanan --- drivers/phy/qualcomm/phy-qcom-snps-femto-v2.c | 129 +++++++++++++++++--------- 1 file changed, 83 insertions(+), 46 deletions(-) diff --git a/drivers/phy/qualcomm/phy-qcom-snps-femto-v2.c b/drivers/phy/qualcomm/phy-qcom-snps-femto-v2.c index 0ead37c0dcfd..2e37b39dabba 100644 --- a/drivers/phy/qualcomm/phy-qcom-snps-femto-v2.c +++ b/drivers/phy/qualcomm/phy-qcom-snps-femto-v2.c @@ -104,6 +104,20 @@ struct phy_override_seq { u8 mask; }; +struct phy_reg_config { + u32 offset; + u32 mask; + u32 val; +}; + +struct phy_config_data { + const struct phy_reg_config *pre_tuning; + const struct override_param_map *override; + const struct phy_reg_config *post_tuning; + const u32 num_pre_tuning; + const u32 num_post_tuning; +}; + #define NUM_HSPHY_TUNING_PARAMS (9) /** @@ -383,13 +397,39 @@ static const struct override_param_map sc7280_snps_7nm_phy[] = { {}, }; +static const struct phy_reg_config hs_5nm_phy_pre_tuning[] = { + { USB2_PHY_USB_PHY_CFG0, UTMI_PHY_CMN_CTRL_OVERRIDE_EN, UTMI_PHY_CMN_CTRL_OVERRIDE_EN }, + { USB2_PHY_USB_PHY_UTMI_CTRL5, POR, POR }, + { USB2_PHY_USB_PHY_HS_PHY_CTRL_COMMON0, FSEL_MASK, 0 }, + { USB2_PHY_USB_PHY_HS_PHY_CTRL_COMMON1, PLLBTUNE, PLLBTUNE }, + { USB2_PHY_USB_PHY_REFCLK_CTRL, REFCLK_SEL_MASK, REFCLK_SEL_DEFAULT }, + { USB2_PHY_USB_PHY_HS_PHY_CTRL_COMMON1, VBUSVLDEXTSEL0, VBUSVLDEXTSEL0 }, + { USB2_PHY_USB_PHY_HS_PHY_CTRL1, VBUSVLDEXT0, VBUSVLDEXT0 }, +}; + +static const struct phy_reg_config hs_5nm_phy_post_tuning[] = { + { USB2_PHY_USB_PHY_HS_PHY_CTRL_COMMON2, VREGBYPASS, VREGBYPASS }, + { USB2_PHY_USB_PHY_HS_PHY_CTRL2, USB2_SUSPEND_N_SEL | USB2_SUSPEND_N, + USB2_SUSPEND_N_SEL | USB2_SUSPEND_N }, + { USB2_PHY_USB_PHY_UTMI_CTRL0, SLEEPM, SLEEPM }, + { USB2_PHY_USB_PHY_HS_PHY_CTRL_COMMON0, SIDDQ, 0 }, + { USB2_PHY_USB_PHY_UTMI_CTRL5, POR, 0 }, + { USB2_PHY_USB_PHY_HS_PHY_CTRL2, USB2_SUSPEND_N_SEL, 0 }, + { USB2_PHY_USB_PHY_CFG0, UTMI_PHY_CMN_CTRL_OVERRIDE_EN, 0 }, +}; + static int qcom_snps_hsphy_init(struct phy *phy) { struct qcom_snps_hsphy *hsphy = phy_get_drvdata(phy); + const struct phy_config_data *data; int ret, i; dev_vdbg(&phy->dev, "%s(): Initializing SNPS HS phy\n", __func__); + data = of_device_get_match_data(hsphy->dev); + if (!data) + return -ENODEV; + ret = regulator_bulk_enable(ARRAY_SIZE(hsphy->vregs), hsphy->vregs); if (ret) return ret; @@ -414,24 +454,11 @@ static int qcom_snps_hsphy_init(struct phy *phy) goto disable_clks; } - qcom_snps_hsphy_write_mask(hsphy->base, USB2_PHY_USB_PHY_CFG0, - UTMI_PHY_CMN_CTRL_OVERRIDE_EN, - UTMI_PHY_CMN_CTRL_OVERRIDE_EN); - qcom_snps_hsphy_write_mask(hsphy->base, USB2_PHY_USB_PHY_UTMI_CTRL5, - POR, POR); - qcom_snps_hsphy_write_mask(hsphy->base, - USB2_PHY_USB_PHY_HS_PHY_CTRL_COMMON0, - FSEL_MASK, 0); - qcom_snps_hsphy_write_mask(hsphy->base, - USB2_PHY_USB_PHY_HS_PHY_CTRL_COMMON1, - PLLBTUNE, PLLBTUNE); - qcom_snps_hsphy_write_mask(hsphy->base, USB2_PHY_USB_PHY_REFCLK_CTRL, - REFCLK_SEL_MASK, REFCLK_SEL_DEFAULT); - qcom_snps_hsphy_write_mask(hsphy->base, - USB2_PHY_USB_PHY_HS_PHY_CTRL_COMMON1, - VBUSVLDEXTSEL0, VBUSVLDEXTSEL0); - qcom_snps_hsphy_write_mask(hsphy->base, USB2_PHY_USB_PHY_HS_PHY_CTRL1, - VBUSVLDEXT0, VBUSVLDEXT0); + for (i = 0; i < data->num_pre_tuning; i++) + qcom_snps_hsphy_write_mask(hsphy->base, + data->pre_tuning[i].offset, + data->pre_tuning[i].mask, + data->pre_tuning[i].val); for (i = 0; i < ARRAY_SIZE(hsphy->update_seq_cfg); i++) { if (hsphy->update_seq_cfg[i].need_update) @@ -441,28 +468,11 @@ static int qcom_snps_hsphy_init(struct phy *phy) hsphy->update_seq_cfg[i].value); } - qcom_snps_hsphy_write_mask(hsphy->base, - USB2_PHY_USB_PHY_HS_PHY_CTRL_COMMON2, - VREGBYPASS, VREGBYPASS); - - qcom_snps_hsphy_write_mask(hsphy->base, USB2_PHY_USB_PHY_HS_PHY_CTRL2, - USB2_SUSPEND_N_SEL | USB2_SUSPEND_N, - USB2_SUSPEND_N_SEL | USB2_SUSPEND_N); - - qcom_snps_hsphy_write_mask(hsphy->base, USB2_PHY_USB_PHY_UTMI_CTRL0, - SLEEPM, SLEEPM); - - qcom_snps_hsphy_write_mask(hsphy->base, USB2_PHY_USB_PHY_HS_PHY_CTRL_COMMON0, - SIDDQ, 0); - - qcom_snps_hsphy_write_mask(hsphy->base, USB2_PHY_USB_PHY_UTMI_CTRL5, - POR, 0); - - qcom_snps_hsphy_write_mask(hsphy->base, USB2_PHY_USB_PHY_HS_PHY_CTRL2, - USB2_SUSPEND_N_SEL, 0); - - qcom_snps_hsphy_write_mask(hsphy->base, USB2_PHY_USB_PHY_CFG0, - UTMI_PHY_CMN_CTRL_OVERRIDE_EN, 0); + for (i = 0; i < data->num_post_tuning; i++) + qcom_snps_hsphy_write_mask(hsphy->base, + data->post_tuning[i].offset, + data->post_tuning[i].mask, + data->post_tuning[i].val); hsphy->phy_initialized = true; @@ -495,14 +505,38 @@ static const struct phy_ops qcom_snps_hsphy_gen_ops = { .owner = THIS_MODULE, }; +static const struct phy_config_data hs_5nm_phy = { + .pre_tuning = hs_5nm_phy_pre_tuning, + .num_pre_tuning = ARRAY_SIZE(hs_5nm_phy_pre_tuning), + .post_tuning = hs_5nm_phy_post_tuning, + .num_post_tuning = ARRAY_SIZE(hs_5nm_phy_post_tuning), +}; + +static const struct phy_config_data hs_7nm_phy = { + .pre_tuning = hs_5nm_phy_pre_tuning, + .num_pre_tuning = ARRAY_SIZE(hs_5nm_phy_pre_tuning), + .override = sc7280_snps_7nm_phy, + .post_tuning = hs_5nm_phy_post_tuning, + .num_post_tuning = ARRAY_SIZE(hs_5nm_phy_post_tuning), +}; + static const struct of_device_id qcom_snps_hsphy_of_match_table[] = { - { .compatible = "qcom,sm8150-usb-hs-phy", }, - { .compatible = "qcom,usb-snps-hs-5nm-phy", }, + { + .compatible = "qcom,sm8150-usb-hs-phy", + .data = &hs_5nm_phy, + }, + { + .compatible = "qcom,usb-snps-hs-5nm-phy", + .data = &hs_5nm_phy, + }, { .compatible = "qcom,usb-snps-hs-7nm-phy", - .data = &sc7280_snps_7nm_phy, + .data = &hs_7nm_phy, + }, + { + .compatible = "qcom,usb-snps-femto-v2-phy", + .data = &hs_5nm_phy, }, - { .compatible = "qcom,usb-snps-femto-v2-phy", }, { } }; MODULE_DEVICE_TABLE(of, qcom_snps_hsphy_of_match_table); @@ -541,11 +575,14 @@ static void qcom_snps_hsphy_read_override_param_seq(struct device *dev) s32 val; int ret, i; struct qcom_snps_hsphy *hsphy; - const struct override_param_map *cfg = of_device_get_match_data(dev); + const struct phy_config_data *data = of_device_get_match_data(dev); + const struct override_param_map *cfg; - if (!cfg) + if (!data || !data->override) return; + cfg = data->override; + hsphy = dev_get_drvdata(dev); for (i = 0; cfg[i].prop_name != NULL; i++) { -- 2.34.1