mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Tuo Li <islituo@gmail.com>
To: akpm@linux-foundation.org
Cc: linux-kernel@vger.kernel.org, Tuo Li <islituo@gmail.com>
Subject: [PATCH] lib/test_meminit: handle kmem_cache_alloc() failure
Date: Fri,  9 Oct 2026 15:30:40 +0800	[thread overview]
Message-ID: <20261009073040.2995938-1-islituo@gmail.com> (raw)

In do_kmem_cache_size(), kmem_cache_alloc() may fail and return NULL.
The returned pointer is subsequently passed to check_buf() and
fill_with_garbage_skip() without being checked, which may result in a
NULL pointer dereference.

Handle the allocation failure by marking the test as failed and
continuing with the next iteration.

Fixes: 5015a300a522 ("lib: introduce test_meminit module")
Signed-off-by: Tuo Li <islituo@gmail.com>
---
 lib/test_meminit.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/lib/test_meminit.c b/lib/test_meminit.c
index 68c3b9da090e..db4b4398e1c1 100644
--- a/lib/test_meminit.c
+++ b/lib/test_meminit.c
@@ -241,6 +241,10 @@ static int __init do_kmem_cache_size(size_t size, bool want_ctor,
 		}
 
 		buf = kmem_cache_alloc(c, alloc_mask);
+		if (!buf) {
+			fail = true;
+			continue;
+		}
 		/* Check that buf is zeroed, if it must be. */
 		fail |= check_buf(buf, size, want_ctor, want_rcu, want_zero);
 		fill_with_garbage_skip(buf, size, want_ctor ? CTOR_BYTES : 0);
-- 
2.43.0


             reply	other threads:[~2026-10-09  7:31 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-09  7:30 Tuo Li [this message]
2026-10-10 23:08 ` Andrew Morton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261009073040.2995938-1-islituo@gmail.com \
    --to=islituo@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®