From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-dl1-f51.google.com (mail-dl1-f51.google.com [74.125.82.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7CF0937F00D for ; Fri, 9 Oct 2026 09:11:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.51 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791537073; cv=none; b=usQWLA3YBSmxBvbLJqIo5A2MW1s/42Kvs6zAHr/fPfoTtcPz+LO/uyoeuK5wmPuMSnpbQZcj1EUvsPeXbzG6YC0GTDeBR9mlX2/446kspcsbE/AOsbZXaVdmNH09KBT+w2LObbsjJ4b8v9MjqL91MSlz2y2ZE2Ec5PLwiHXPdv4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791537073; c=relaxed/simple; bh=jXxgq9abOLg2kmwgNbaljQUPQ/KD0BTdZQTllhbjBbo=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=PbBtJxlqNEybCTGwMtGjQAgrAp+pCYv0ZyyodzqbHdB6fU6Yfk+iJOkgSQCDKVSAU8hg+E8NctM3Xc728o1Mr6OQx9x9WguWQGi6vDWTUc4QxalJx48gcsaenG8UqVVR57XFUDjXs7bLT6+Xrf3TiXPGQWUStmSplZ6sjpLJkeI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=VcVNGaq9; arc=none smtp.client-ip=74.125.82.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="VcVNGaq9" Received: by mail-dl1-f51.google.com with SMTP id a92af1059eb24-154e9d2d979so3932752c88.1 for ; Fri, 09 Oct 2026 02:11:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1791537071; x=1792141871; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=yqkm1HxfTq1FvqOE6B6FS72pIuLdd3xBnpZcNmBPGCs=; b=VcVNGaq9vmns6Oy+ekhYBQlT3JFZ+XBTRxW8g2AumHtBGSQD+05baClgr2pVPb2i9z OKJ319aOi8sERyaxmXvxFK54YUbK3yx6vj1zggWJX0VY4b3q44xFlnT4+y0/7HyR2gBa DHzH0ksg02ppzldt30/dOuygKtfj0noT0pHgLDOOH9+9kdY5ttPXZFuFBRnomcCRrj1F msu5hI/mb2rHYpv9Wtp88EnPFUSU89AbgRzQcBfBJ//gFou1ce0ZXzEOWfVHjwrS0S7E zKdZEIpTFUAItwxi31Cn4w8nHfDwIDh7b99u7Ix04qxj9AXpF8nsCPKhdMXaZ5kXNCDp AjMg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1791537071; x=1792141871; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=yqkm1HxfTq1FvqOE6B6FS72pIuLdd3xBnpZcNmBPGCs=; b=mgLTYgiJAgdN3/+GKbXXHNUNmMNtBLPDnPIGbAqjr+mCX+dFzC1rPBeZIiQCtPyQf2 5QdLljPvjhdPmHc6XsIiiz0IvMUA4vGrm7EELLgQ9cpyPKQ+aPmRa0lXa6FPJWyTsjKe A/Y2YtYPSUgulHnuqTBNXWIxWCJN3U3vg+Sy+eNOinJoeNBQbpWO2TzOrbZhxEC6pCtU FHkIhTu30qiapHTM2aq1PDaPfHdYpzX3oTLwBhQysuwd76ZHOANiVrLei5m5hGGeU3ho NSNZsD9BhgiK/ke4O1vDCrADVmkvNGad53tjAEQIweEsgysmjIfXY34GjHLz2DPrdqLL nPow== X-Forwarded-Encrypted: i=1; AKwUvByGZGyvEAU8p471snvLYPfSOxGi3JMLYzxjkZsUJ+fW8zugKOpCG63cnJ7HtL8loVV37xGdjZOFTyJw+PI=@vger.kernel.org X-Gm-Message-State: AFuF++m4JXA7B5qCmklLs13UicFAdmDF7mMWhPVSqzgw2A2vlceiB0EG IMe/D5hiNTyJ8upYhgvTITZqG9gMbdXUlHsLsbWm6wsYbohj0PeH0ubN X-Gm-Gg: AYBFou1MUdKk8QIrUPK3Ewwej+jhS/k2gntPPeg6UfLWGfbR71uGCpPpyjJ1yZpjBoz X7un/u7vshhz82fgBe8Q4wGn2e3WNGly4PJP9LHIkiqrxhRUjwo2WRHlAUtUGcdeOwXgYrUUNaF 7QLy2oJFQTvZk2Ez/4nOvY72GzvwYFevc1LdxSJdSnbQx0kp7LERuJQFsTw9rKT9Pmxz3Lo6Edw osDBWZ59LNKuBs42ZhMBjRkFOVpLiunq0Qilx4wRk8zn37m7SJYxHKQb8ZoTCC2/QsC9Yg3UEKw FLjOOjRpoNNUezHz9MUuhyqoEV4K2sBZCwjcHH3/e1OaTuakPgBC9yj01udnGuqPdHUwewoNd/B lPFwBIka8hAbn4Z6A8rYldVe69R6upfMMJ/mSZ09qK+W1uCjfPQ+eq8NaGG79FZmO1gdBe0CGCj y0A6ZO9YNm6NAj+0ZNmLvbSEBr6tRBC7StjTh0xIk+DKI3aOVxPIoIFSnmDLYgHR3a5kXO5UMJy a2rQ7Df03RwnmYiq7i5Z1XCAHgSd4E24p9YTKwj4x/Z9ECKwMzMcEwP2N1owJCTEjS3w6mbFgY4 ijmyyD/uqQrbww== X-Received: by 2002:a05:7022:c84:b0:146:5f73:d45b with SMTP id a92af1059eb24-16a54fab691mr1538668c88.3.1791537071275; Fri, 09 Oct 2026 02:11:11 -0700 (PDT) Received: from phuc-desktop.. ([183.91.15.56]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-169a1becefdsm5125444c88.7.2026.10.09.02.11.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 09 Oct 2026 02:11:10 -0700 (PDT) From: phucduc.bui@gmail.com To: Lee Jones , Pavel Machek , linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Jacek Anaszewski , Dan Murphy , bui duc phuc Subject: [PATCH v2 1/2] leds: lm3532: Propagate enable GPIO errors Date: Fri, 9 Oct 2026 16:10:58 +0700 Message-ID: <20261009091059.25729-1-phucduc.bui@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: bui duc phuc devm_gpiod_get_optional() returns NULL when the optional GPIO is not present, but may return -EPROBE_DEFER or other errors. lm3532_parse_node() currently treats GPIO lookup errors as if the GPIO were not present. Check the return value and propagate errors from the enable GPIO lookup. Fixes: bc1b8492c764 ("leds: lm3532: Introduce the lm3532 LED driver") Signed-off-by: bui duc phuc --- Changes in v2: - Capitalize the first letter of the commit message subject drivers/leds/leds-lm3532.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/leds/leds-lm3532.c b/drivers/leds/leds-lm3532.c index b51496910b08..a3bc9680dc4c 100644 --- a/drivers/leds/leds-lm3532.c +++ b/drivers/leds/leds-lm3532.c @@ -560,7 +560,8 @@ static int lm3532_parse_node(struct lm3532_data *priv) priv->enable_gpio = devm_gpiod_get_optional(&priv->client->dev, "enable", GPIOD_OUT_LOW); if (IS_ERR(priv->enable_gpio)) - priv->enable_gpio = NULL; + return dev_err_probe(&priv->client->dev, PTR_ERR(priv->enable_gpio), + "failed to get enable GPIO\n"); if (priv->enable_gpio) { ret = devm_add_action(&priv->client->dev, gpio_set_low_action, priv); -- 2.43.0