From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 61F494E9C11; Fri, 9 Oct 2026 14:44:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=213.167.242.64 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791557080; cv=none; b=U+mZZ2Iqgf4UeijM6ReTyaWjZZDTxci3XvrLY4RHg3waA9FDDQYOYV3txDWW1lfvdLDp2WAz4vec5p/7y37JqsYppsiEEwYprz8sJI41NN6P65bZJmzZLJ7Gvr4hs35cgxU5LiiWnY/5LDIGjyspBEeWpu2qu5atBsP9+TcJBqA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791557080; c=relaxed/simple; bh=blrsm518AbY7gsS1Fe/wV9oYiBIEFkxhkrxPCpHO4uU=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=tVuyLRhK1zdjLmMQGofhKR9aaEj8X2oU70nXDxXzHecorQQneNSUbZLO4FU8tiysM1AYS9+k+kSVJ9fHwnhhA3awZVArjQ8drYSA/jIf6MbIRBL3r1CcK8qiGw7wf13KPIvRLVf27yYkqPC9abjA+Crj9UvdOq2+KjPezT5JD/k= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=ideasonboard.com; spf=pass smtp.mailfrom=ideasonboard.com; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b=d3wW/zEo; arc=none smtp.client-ip=213.167.242.64 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=ideasonboard.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ideasonboard.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="d3wW/zEo" Received: from killaraus.ideasonboard.com (dynamic-2a00-1028-8389-0276-8139-a635-2d39-b80f.ipv6.o2.cz [IPv6:2a00:1028:8389:276:8139:a635:2d39:b80f]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id C5C35346; Fri, 9 Oct 2026 16:42:37 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1791556958; bh=blrsm518AbY7gsS1Fe/wV9oYiBIEFkxhkrxPCpHO4uU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=d3wW/zEolVEpicLWTjYVHNvptXBe3prTygHVLJCx+disI2aDOh2v4BUdSFDAMAtD6 /fOCQzoNZOazwKjpSJ1/91L0OMR9OprtBQBgNlLIG2WpVBg/D+BBpWEO2UiyjNRgnC Z/jLFoZKS6C0NlIuGxuHbQy9mHwh32m7HRG3X/oc= Date: Fri, 9 Oct 2026 16:44:34 +0200 From: Laurent Pinchart To: Conor Dooley Cc: Quchaosheng , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Tomi Valkeinen , dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/3] dt-bindings: display: ti,tpd12s015: Convert to DT schema Message-ID: <20261009144434.GD622105@killaraus.ideasonboard.com> References: <20261009105601.301891-1-quchaosheng000406@163.com> <20261009105601.301891-2-quchaosheng000406@163.com> <20261009-2f34bbada2c463c78b2c05a7@squawk> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20261009-2f34bbada2c463c78b2c05a7@squawk> On Fri, Oct 09, 2026 at 03:25:49PM +0100, Conor Dooley wrote: > On Fri, Oct 09, 2026 at 06:55:59PM +0800, Quchaosheng wrote: > > From: Chaosheng Qu > > > > Convert the TPD12S015 HDMI level shifter binding to DT schema. > > > > The TI TPD12S015 is an HDMI companion chip that combines a level shifter > > and ESD protection circuitry. Document the two ports it exposes between > > the HDMI transmitter and the connector. > > > > The tpd12s016 is software compatible with the tpd12s015 and is listed as > > a fallback compatible by am57xx-idk-common.dtsi, so accept it as a > > fallback of "ti,tpd12s015". The driver matches on "ti,tpd12s015" only, so > > a board using the tpd12s016 must list both compatibles. > > > > Assisted-by: LLM > > Signed-off-by: Chaosheng Qu > > No idea if the sashiko reply is valid, because I have no clue if > providing a subset of the gpios is functional. Really this should have > multiple different gpios properties, Definitely. > but this binding is really old and > not worth changing IMO. > Acked-by: Conor Dooley > pw-bot: not-applicable I'm getting annoyed be the LLM-assisted individual conversions. Can we start requiring people who convert text bindings to YAML to at least handle whole groups in one go ? If they're going to do a bad job, I'd rather have to review it once only. > > --- > > .../bindings/display/ti/ti,tpd12s015.txt | 44 --------- > > .../bindings/display/ti/ti,tpd12s015.yaml | 90 +++++++++++++++++++ > > 2 files changed, 90 insertions(+), 44 deletions(-) > > delete mode 100644 Documentation/devicetree/bindings/display/ti/ti,tpd12s015.txt > > create mode 100644 Documentation/devicetree/bindings/display/ti/ti,tpd12s015.yaml > > > > diff --git a/Documentation/devicetree/bindings/display/ti/ti,tpd12s015.txt b/Documentation/devicetree/bindings/display/ti/ti,tpd12s015.txt > > deleted file mode 100644 > > index 26e6d32e3f20..000000000000 > > --- a/Documentation/devicetree/bindings/display/ti/ti,tpd12s015.txt > > +++ /dev/null > > @@ -1,44 +0,0 @@ > > -TPD12S015 HDMI level shifter and ESD protection chip > > -==================================================== > > - > > -Required properties: > > -- compatible: "ti,tpd12s015" > > - > > -Optional properties: > > -- gpios: CT CP HPD, LS OE and HPD gpios > > - > > -Required nodes: > > -- Video port 0 for HDMI input > > -- Video port 1 for HDMI output > > - > > -Example > > -------- > > - > > -tpd12s015: encoder@1 { > > - compatible = "ti,tpd12s015"; > > - > > - gpios = <&gpio2 28 GPIO_ACTIVE_HIGH>, /* 60, CT CP HPD */ > > - <&gpio2 9 GPIO_ACTIVE_HIGH>, /* 41, LS OE */ > > - <&gpio2 31 GPIO_ACTIVE_HIGH>; /* 63, HPD */ > > - > > - ports { > > - #address-cells = <1>; > > - #size-cells = <0>; > > - > > - port@0 { > > - reg = <0>; > > - > > - tpd12s015_in: endpoint@0 { > > - remote-endpoint = <&hdmi_out>; > > - }; > > - }; > > - > > - port@1 { > > - reg = <1>; > > - > > - tpd12s015_out: endpoint@0 { > > - remote-endpoint = <&hdmi_connector_in>; > > - }; > > - }; > > - }; > > -}; > > diff --git a/Documentation/devicetree/bindings/display/ti/ti,tpd12s015.yaml b/Documentation/devicetree/bindings/display/ti/ti,tpd12s015.yaml > > new file mode 100644 > > index 000000000000..1927da3bd736 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/display/ti/ti,tpd12s015.yaml > > @@ -0,0 +1,90 @@ > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > > +%YAML 1.2 > > +--- > > +$id: http://devicetree.org/schemas/display/ti/ti,tpd12s015.yaml# > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > + > > +title: TI TPD12S015 HDMI level shifter and ESD protection chip > > + > > +maintainers: > > + - Tomi Valkeinen > > + > > +description: | > > + The TPD12S015 is an HDMI companion chip that combines a level shifter and > > + ESD protection circuitry. It sits between an HDMI transmitter and the HDMI > > + connector, and provides control over the level shifter enable and the > > + hot-plug detect signals. > > + > > +properties: > > + compatible: > > + oneOf: > > + - const: ti,tpd12s015 > > + - items: > > + - const: ti,tpd12s016 > > + - const: ti,tpd12s015 > > + > > + gpios: > > + description: > > + The CT CP HPD, LS OE and HPD GPIOs, in that order. The first controls > > + the level shifter, the second enables the level shifter outputs and > > + the third reads the hot-plug detect line. > > + maxItems: 3 > > + > > + ports: > > + $ref: /schemas/graph.yaml#/properties/ports > > + > > + properties: > > + port@0: > > + $ref: /schemas/graph.yaml#/$defs/port-base > > + unevaluatedProperties: false > > + description: HDMI input from the transmitter. > > + > > + port@1: > > + $ref: /schemas/graph.yaml#/$defs/port-base > > + unevaluatedProperties: false > > + description: HDMI output to the connector. > > + > > + required: > > + - port@0 > > + - port@1 > > + > > +required: > > + - compatible > > + - ports > > + > > +additionalProperties: false > > + > > +examples: > > + - | > > + #include > > + > > + encoder1 { > > + compatible = "ti,tpd12s015"; > > + > > + gpios = <&gpio2 28 GPIO_ACTIVE_HIGH>, /* 60, CT CP HPD */ > > + <&gpio2 9 GPIO_ACTIVE_HIGH>, /* 41, LS OE */ > > + <&gpio2 31 GPIO_ACTIVE_HIGH>; /* 63, HPD */ > > + > > + ports { > > + #address-cells = <1>; > > + #size-cells = <0>; > > + > > + port@0 { > > + reg = <0>; > > + > > + tpd12s015_in: endpoint { > > + remote-endpoint = <&hdmi_out>; > > + }; > > + }; > > + > > + port@1 { > > + reg = <1>; > > + > > + tpd12s015_out: endpoint { > > + remote-endpoint = <&hdmi_connector_in>; > > + }; > > + }; > > + }; > > + }; > > + > > +... -- Regards, Laurent Pinchart