From: Amit Machhiwal <amachhiw@linux.ibm.com>
To: Steven Rostedt <rostedt@goodmis.org>,
Masami Hiramatsu <mhiramat@kernel.org>,
linux-trace-kernel@vger.kernel.org,
linuxppc-dev@lists.ozlabs.org
Cc: "Amit Machhiwal" <amachhiw@linux.ibm.com>,
"Michal Suchánek" <msuchanek@suse.de>,
"Mathieu Desnoyers" <mathieu.desnoyers@efficios.com>,
"Madhavan Srinivasan" <maddy@linux.ibm.com>,
"Ritesh Harjani (IBM)" <ritesh.list@gmail.com>,
"Harsh Prateek Bora" <harshpb@linux.ibm.com>,
linux-kernel@vger.kernel.org, kvm@vger.kernel.org,
kvm-ppc@vger.kernel.org,
"Mark-PK Tsai" <mark-pk.tsai@mediatek.com>,
stable@vger.kernel.org
Subject: [PATCH 0/2] tracing: Fix early boot trace buffer allocation and tracefs init crash
Date: Fri, 9 Oct 2026 22:05:55 +0530 [thread overview]
Message-ID: <20261009163557.88467-1-amachhiw@linux.ibm.com> (raw)
This series addresses an early boot crash and trace buffer allocation
failure reported on ppc64le KVM guests [1] (and reproducible under
CONFIG_DEFERRED_STRUCT_PAGE_INIT=y with large static kernel footprints).
Patch 1 fixes the crash (NULL pointer dereference in __find_event_file()):
When trace buffer allocation fails during early boot, tracing is left
disabled. However, tracer_init_tracefs_work_func() runs asynchronously via
fs_initcall and traverses uninitialized event lists without checking
tracing_disabled. Checking tracing_disabled early averts the crash.
Patch 2 fixes the root cause of the early allocation failure:
During early_trace_init(), __rb_allocate_pages() performs a heuristic check
using si_mem_available(). Under CONFIG_DEFERRED_STRUCT_PAGE_INIT=y,
NR_FREE_PAGES only reflects the initial non-deferred pool (e.g. 1 section
per node) because the remaining memory has not yet been initialized. On
kernels with large static binary footprints (debug configs, early
SLUB/vmalloc/ftrace records), this pool is quickly consumed, causing
si_mem_available() to return 0 and trigger a false -ENOMEM before the buddy
allocator has the opportunity to grow the zone on demand via
deferred_grow_zone(). Skipping the check during SYSTEM_BOOTING allows the
allocation to succeed.
Both fixes have been verified by Michal Suchánek.
[1] https://lore.kernel.org/all/arYskzbiaNzBR9MD@kunlun.suse.cz/
Amit Machhiwal (2):
tracing: Do not initialize tracefs work if tracing is disabled
ring-buffer: Do not check si_mem_available() during SYSTEM_BOOTING
kernel/trace/ring_buffer.c | 8 +++++++-
kernel/trace/trace.c | 6 ++++++
2 files changed, 13 insertions(+), 1 deletion(-)
base-commit: af32da41b0327b9c6a37856ba82b6760d6c8d10e
--
2.54.0 (Apple Git-157)
next reply other threads:[~2026-10-09 16:36 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-09 16:35 Amit Machhiwal [this message]
2026-10-09 16:35 ` [PATCH 1/2] tracing: Do not initialize tracefs work if tracing is disabled Amit Machhiwal
2026-10-09 16:35 ` [PATCH 2/2] ring-buffer: Do not check si_mem_available() during SYSTEM_BOOTING Amit Machhiwal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261009163557.88467-1-amachhiw@linux.ibm.com \
--to=amachhiw@linux.ibm.com \
--cc=harshpb@linux.ibm.com \
--cc=kvm-ppc@vger.kernel.org \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=maddy@linux.ibm.com \
--cc=mark-pk.tsai@mediatek.com \
--cc=mathieu.desnoyers@efficios.com \
--cc=mhiramat@kernel.org \
--cc=msuchanek@suse.de \
--cc=ritesh.list@gmail.com \
--cc=rostedt@goodmis.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®