From: Eric Biggers <ebiggers@kernel.org>
To: linux-crypto@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, Ard Biesheuvel <ardb@kernel.org>,
"Jason A . Donenfeld" <Jason@zx2c4.com>,
Herbert Xu <herbert@gondor.apana.org.au>,
stable@vger.kernel.org, Sashiko <sashiko-bot@kernel.org>
Subject: Re: [PATCH] lib/crypto: poly1305: Use memzero_explicit() in poly1305_final()
Date: Fri, 9 Oct 2026 19:24:58 +0200 [thread overview]
Message-ID: <20261009172458.GA73965@quark> (raw)
In-Reply-To: <20261006122546.GB3185@quark>
On Tue, Oct 06, 2026 at 02:25:46PM +0200, Eric Biggers wrote:
> On Tue, Oct 06, 2026 at 10:34:32AM +0200, Eric Biggers wrote:
> > Use memzero_explicit() instead of a plain struct assignment to guarantee
> > zeroization of the 'struct poly1305_desc_ctx'.
> >
> > Note that dead store elimination was only theoretically possible with
> > link-time optimization here. But it's still worth fixing.
> >
> > Fixes: a1d93064094c ("crypto: poly1305 - expose init/update/final library interface")
> > Cc: stable@vger.kernel.org
> > Reported-by: Sashiko <sashiko-bot@kernel.org>
> > Closes: https://sashiko.dev/#/bug/linux-c3a6bd76-f6ab-4203-892a-cd06f7aa0c34
> > Signed-off-by: Eric Biggers <ebiggers@kernel.org>
> > ---
> > lib/crypto/poly1305.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
>
> Applied to https://git.kernel.org/pub/scm/linux/kernel/git/ebiggers/linux.git/log/?h=libcrypto-next
Moved to libcrypto-fixes, since will be a fixes pull request with other
Poly1305 fixes anyway.
- Eric
prev parent reply other threads:[~2026-10-09 17:25 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-06 8:34 Eric Biggers
2026-10-06 10:10 ` Ard Biesheuvel
2026-10-06 12:25 ` Eric Biggers
2026-10-09 17:24 ` Eric Biggers [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261009172458.GA73965@quark \
--to=ebiggers@kernel.org \
--cc=Jason@zx2c4.com \
--cc=ardb@kernel.org \
--cc=herbert@gondor.apana.org.au \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sashiko-bot@kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®