From: Nathan Chancellor <nathan@kernel.org>
To: Kuan-Wei Chiu <visitorckw@gmail.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Nick Desaulniers <ndesaulniers@google.com>,
Bill Wendling <morbo@google.com>,
Justin Stitt <justinstitt@google.com>,
Guan-Chun Wu <409411716@gms.tku.edu.tw>,
linux-kernel@vger.kernel.org, llvm@lists.linux.dev,
stable@vger.kernel.org
Subject: Re: [PATCH] lib/base64: Silence clang-24 -Wconstant-conversion with diag pragmas
Date: Fri, 9 Oct 2026 22:38:01 +0200 [thread overview]
Message-ID: <20261009203801.GA774682@ax162> (raw)
In-Reply-To: <askdVfevxztHMyGN@google.com>
On Sat, Oct 10, 2026 at 12:59:01AM +0800, Kuan-Wei Chiu wrote:
> Reading the issue comment in the link, it seems somewhat subjective and
> controversial whether the compiler should emit a warning in this
> scenario. I'm not a compiler expert, but from a user's perspective,
> it's a bit disappointing when we have to deal with this. When we are
> confident that the code is correct and have provided the compiler with
> enough context to determine that there is no runtime issue, suddenly
> getting a new warning after an upgrade is a bit frustrating. But
> anyway, let's go with this workaround to keep the compiler happy.
Yes, I 100% agree. I have tried to make that a little clearer to the
clang folks, I guess we will see where that goes. Thanks for being
pragmatic here. We can always revisit this depending on how the upstream
discussions go but I would rather get this rolling on our side now, as
our CI has been broken for over three weeks and has missed other
regressions in the meantime.
--
Cheers,
Nathan
prev parent reply other threads:[~2026-10-09 20:38 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-08 11:08 Nathan Chancellor
2026-10-09 16:59 ` Kuan-Wei Chiu
2026-10-09 20:38 ` Nathan Chancellor [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261009203801.GA774682@ax162 \
--to=nathan@kernel.org \
--cc=409411716@gms.tku.edu.tw \
--cc=akpm@linux-foundation.org \
--cc=justinstitt@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=llvm@lists.linux.dev \
--cc=morbo@google.com \
--cc=ndesaulniers@google.com \
--cc=stable@vger.kernel.org \
--cc=visitorckw@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®