From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f49.google.com (mail-wm1-f49.google.com [209.85.128.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0FD9D35C188 for ; Sat, 10 Oct 2026 10:16:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.49 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791627408; cv=none; b=mDGfTHboe8vNKMAQPIME3I/VzFCZLzxjh3EQ996BPLpLNWWepAva6aTJfJP47a9HdZGIcKk1tFaivA1GHi/ZGkkPRuHkleBuhTzpFNcfMGYhSp70ic5XlkdMIwI0F8juWXIdeXWJvW4N/zZOcWgC2VOOCIGqj+NTuUxwA9tpuv8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1791627408; c=relaxed/simple; bh=sCljAVWLjKOLm7IfEi0mbyqGtrODlKofnZw7AfHjiIo=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=k7dQTvKf98sDRjQiIh/UWy9N79N1B4bV8vkexI/SfkOb1/IG81JL5oOizVi1vBV0Hy/7GPCXSJOTcv859rLTwePMvMRckcGzPN3tIr88Qg3bHVAaDqTMgWlhMH8fE3HHDZ0sagULMCiMrgK5BNVbqC7Zz841PGR7E8I/qdf1pQg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=dt8UK+xY; arc=none smtp.client-ip=209.85.128.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="dt8UK+xY" Received: by mail-wm1-f49.google.com with SMTP id 5b1f17b1804b1-49e73611928so16872635e9.1 for ; Sat, 10 Oct 2026 03:16:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1791627405; x=1792232205; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=360Ah81wzUt84jPWuHxVGQCsAvtIkeDp95VvPwcByPc=; b=dt8UK+xYV3af/mOP+RBdZXW+r5mO30lcCsoTNkl/rBAX+AvUjRQXK3je8El8+ZI6cS xyAcGc5KU0Uelos8Y0PXkgL7jkdDR48Ef4VrFW4YChSP2Xs1J4W1bTZYNow1e8lb8kfH xfmCpKIDiax9s54hmo3REjRg7R+n1Mqms75bTZ3LDlhFOdzxEdqKC+34ivCy54eYewp4 P6k9slgLrm5KxYwtyWlxYh/NWGXuz2Ur9E9dvws8GrDZQcm3I8o+hzoasfN/Z84vUDF/ P2NVlR1xieDOtwCP5oV7zkSIaAng6+34LHBHB/JKFFXjBH71SoHoGd2PP3Vy2Rn1WtLp 0//Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1791627405; x=1792232205; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=360Ah81wzUt84jPWuHxVGQCsAvtIkeDp95VvPwcByPc=; b=WiihrlH9H60H1l4t9IfyZUYoBIeYluVZgVxHgXJacBMPaNHyOJ1GsXTnMfIldL0KuH 4yPJ+elDMP+wzgWJEUWUqhpSCE1yMEslAVL2RCFJMs3RAK6I/mNl9bYQPy2pDjipagfc qGdjTCrxezGyFwX501R0QKHONG40ksUZQZV9GP017d6byC8MUVnPEvbusLHKLzBftY6H 7pGJ33LCkVpHe0YGQyW52QNVtLMXHI9eUKtLyDTXTOpDwgJqz3GsXFtz3qjztRt6LuH7 R2j2zvARmZLYi2uFoy/eApfDDcgV0mIxV+V/mFgUmPsx6h+RyGRWsEcHI/fNmpWx/YjD Cr2A== X-Forwarded-Encrypted: i=1; AKwUvBw8Ihw4NhuLIjqWUDakEP1VeYZNLlR05QLwmphx6VjYuj8jmaqjFouvQWiaH1f8gx2L5VzOVuBZKNpEI60=@vger.kernel.org X-Gm-Message-State: AFq9FYI7fFVHQormMT9ulacok4vW3VfiRSo2So35qg51XlwqXOhFETQI JQ3NJf+rXiDAGKlmzK+uceSwYPy0RlHgdJ91JjkSHaZjr/0wfQCu6h1C X-Gm-Gg: AYBFou01NVH7rpDlyowIC3cq27OyMZuNCP4TcSO2qR2dUJFewSHcBIjS9OY4D7ll5mu O9L/hP3uOiwIHXLsd2227Xe6eLMWdDNQ81paE8/h09ALQowcTXIYUY5mzjifBjZSrnyIh1lfdeM KDx2iO8vI6czLH/kAkdDyCaD4Q4zN9VtnAuARB73tlCCkke30scRICLGSFU7246ZdUsc7AZH/sp k59RJAVIQ4qGSCY63f05oryHwQEMqIhH7xwOLz2C+TVXfljWj1MlR3hQkCPH1gytixlWKkF7S+u +G9uLlEMJNes3KgEl6aeIwieRcLIs4LUAEzhTh65gasRdGduNQVzcXTq7eTtAOsiR4ljxj5ZKo2 pChcP0iuHgNXIOPomiaTPGDQofOBVWa9C6ONGrAxbWqpIrPMpblmmixl0L5fRiVVKmGp+uvj3H1 Qy0sEhASyHbWy4IiNoPyoGlIXsIicOHlNC8ksyj1LksmagflRNBTfDy+aL3QE= X-Received: by 2002:a05:6000:dc2:b0:48d:659d:f8a3 with SMTP id ffacd0b85a97d-48db949033dmr6700203f8f.23.1791627405144; Sat, 10 Oct 2026 03:16:45 -0700 (PDT) Received: from ASUS ([85.105.252.11]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-48db98c38f4sm9417856f8f.27.2026.10.10.03.16.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 10 Oct 2026 03:16:43 -0700 (PDT) From: Bartu Alev To: platform-driver-x86@vger.kernel.org Cc: ilpo.jarvinen@linux.intel.com, hansg@kernel.org, luke@ljones.dev, denis.benato@linux.dev, benato.denis96@gmail.com, corentin.chary@gmail.com, linux-api@vger.kernel.org, linux-kernel@vger.kernel.org, Bartu Alev Subject: [PATCH v3 1/5] platform/x86: asus-wmi: rename TUF RGB state DEVID to _CMD Date: Sat, 10 Oct 2026 13:15:57 +0300 Message-ID: <20261010101601.888709-2-bartualev@gmail.com> X-Mailer: git-send-email 2.56.0 In-Reply-To: <20261010101601.888709-1-bartualev@gmail.com> References: <20261010101601.888709-1-bartualev@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The pre-existing TUF RGB state DEVID (0x00100057) is a write-only command used with the DEVS method. Rename it to make clear it is a command rather than a readable state, avoiding confusion with the upcoming readback support. Suggested-by: Denis Benato Signed-off-by: Bartu Alev --- drivers/platform/x86/asus-wmi.c | 4 ++-- include/linux/platform_data/x86/asus-wmi.h | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/platform/x86/asus-wmi.c b/drivers/platform/x86/asus-wmi.c index a65090429ca7..5adf7a289f82 100644 --- a/drivers/platform/x86/asus-wmi.c +++ b/drivers/platform/x86/asus-wmi.c @@ -1140,7 +1140,7 @@ static ssize_t kbd_rgb_state_store(struct device *dev, /* 0xbd is the required default arg0 for the method. Nothing happens otherwise */ err = asus_wmi_evaluate_method3(ASUS_WMI_METHODID_DEVS, - ASUS_WMI_DEVID_TUF_RGB_STATE, 0xbd | cmd << 8 | (flags << 16), 0, NULL); + ASUS_WMI_DEVID_TUF_RGB_CMD, 0xbd | cmd << 8 | (flags << 16), 0, NULL); if (err) return err; @@ -5153,7 +5153,7 @@ static int asus_wmi_add(struct platform_device *pdev) asus->egpu_enable_available = asus_wmi_dev_is_present(asus, ASUS_WMI_DEVID_EGPU); asus->dgpu_disable_available = asus_wmi_dev_is_present(asus, ASUS_WMI_DEVID_DGPU); - asus->kbd_rgb_state_available = asus_wmi_dev_is_present(asus, ASUS_WMI_DEVID_TUF_RGB_STATE); + asus->kbd_rgb_state_available = asus_wmi_dev_is_present(asus, ASUS_WMI_DEVID_TUF_RGB_CMD); if (asus_wmi_dev_is_present(asus, ASUS_WMI_DEVID_MINI_LED_MODE)) asus->mini_led_dev_id = ASUS_WMI_DEVID_MINI_LED_MODE; diff --git a/include/linux/platform_data/x86/asus-wmi.h b/include/linux/platform_data/x86/asus-wmi.h index b5ed8c83ace1..ecf8b5e6cbae 100644 --- a/include/linux/platform_data/x86/asus-wmi.h +++ b/include/linux/platform_data/x86/asus-wmi.h @@ -159,7 +159,7 @@ #define ASUS_WMI_DEVID_TUF_RGB_MODE2 0x0010005A /* TUF laptop RGB power/state */ -#define ASUS_WMI_DEVID_TUF_RGB_STATE 0x00100057 +#define ASUS_WMI_DEVID_TUF_RGB_CMD 0x00100057 /* Bootup sound control */ #define ASUS_WMI_DEVID_BOOT_SOUND 0x00130022 -- 2.56.0